From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F90BC2D0D5 for ; Tue, 24 Dec 2019 09:03:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04ECD2071E for ; Tue, 24 Dec 2019 09:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="EJ2m8BgG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726195AbfLXJCE (ORCPT ); Tue, 24 Dec 2019 04:02:04 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50846 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbfLXJCA (ORCPT ); Tue, 24 Dec 2019 04:02:00 -0500 Received: by mail-wm1-f67.google.com with SMTP id a5so1877559wmb.0 for ; Tue, 24 Dec 2019 01:01:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JpIUPsCQ4mUZV8clqM6x3//3zxhuxnyUCEItvWS4lIE=; b=EJ2m8BgGEtcQm8iSYsrb6jbllbscoKNSW55IMHI0wPcev4mLznd5VMRKwg2/sTmJx7 6B0CFsO0Hi5zcoPBFR5UJazH++6qulEdmR+LgsQTpX43ge6h4U8J8ZJNVTYRJqa9zOoX KHYdGmdBFl3qmjTINlKlX73vsGbpXDplIawOo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JpIUPsCQ4mUZV8clqM6x3//3zxhuxnyUCEItvWS4lIE=; b=UisLHRN35je9P/VYRH28p1MJDKY0ylDpZ22oSj9SY0S+j0X7LWcknG73h2cuFh6Je2 1vZn0mO6ywD10AToVnTPuvlbuJTeUdmKEHSyMdzMbtKYYFuUSCytoSLs5D4Dv1sgnJiU Ib+8lHiwHzhyq4L0951Gyt6ZP6yquClB3zJ262Hnmv2a9szcWbb9pHv6Mpu5JZT+Qxr6 BuvdcvYIh3Blyq1HnFeKko3igvBGrnO/UWlh3jgkQHaDbUJ9+JqHxResEHmkPjAeYy01 JSC8/L46X6a9oiwgPhyU4YxoDVDTFK5rj4d+fCoqj+Ls3LyGLqKnDUgaDc6ZldMx76za SkdA== X-Gm-Message-State: APjAAAXYJKh9BGrLjnLtbBrTAAFXqtgdSUmQMBu27yp791VJIhNSN73X j/7SC+c+aVmk4t6VGjOwuYvhCQ== X-Google-Smtp-Source: APXvYqwaDJpckqJ1JrVbZPbh8vFZ6XADgxx76CNzAlm8TnNSIoHONxdbgCmk6gW2sYiAbh73ok449A== X-Received: by 2002:a1c:4b01:: with SMTP id y1mr3010277wma.12.1577178118405; Tue, 24 Dec 2019 01:01:58 -0800 (PST) Received: from [10.230.41.59] ([192.19.215.251]) by smtp.gmail.com with ESMTPSA id v22sm1942400wml.11.2019.12.24.01.01.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2019 01:01:57 -0800 (PST) Subject: Re: [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset To: Christian Hewitt , Soeren Moch Cc: Kalle Valo , Heiko Stuebner , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong References: <20191211235253.2539-1-smoch@web.de> <47DB71CE-ACC4-431D-9E66-D28A8C18C0A4@gmail.com> From: Arend Van Spriel Message-ID: <3c42d6de-670d-fee8-aa81-99f44d447e87@broadcom.com> Date: Tue, 24 Dec 2019 10:01:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <47DB71CE-ACC4-431D-9E66-D28A8C18C0A4@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 12/22/2019 5:35 AM, Christian Hewitt wrote: > >> On 19 Dec 2019, at 2:04 am, Soeren Moch wrote: >> >> I guess you need similar enhancements of the board device tree as in >> patch 8 of this series for your VIM3 board. > > Wider testing now points to a known SDIO issue (SoC bug) with Amlogic G12A/B hardware. The merged workaround for the bug was only tested with bcmdhd and brcmfmac may require tweaking as the same issue exhibits on an Amlogic G12B device with BCM4356 chip. Testing the series with Amlogic GXM (older) and SM1 (newer) hardware to exclude the SoC bug shows everything working as expected. Hi Christian, Can you elaborate on the "known SDIO issue"? Is it an issue with ADMA or something else. I am asking because there is a workaround in brcmfmac to avoid scatter-gather lists, which may or may not address the issue. Regards, Arend From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend Van Spriel Subject: Re: [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Date: Tue, 24 Dec 2019 10:01:56 +0100 Message-ID: <3c42d6de-670d-fee8-aa81-99f44d447e87@broadcom.com> References: <20191211235253.2539-1-smoch@web.de> <47DB71CE-ACC4-431D-9E66-D28A8C18C0A4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47DB71CE-ACC4-431D-9E66-D28A8C18C0A4@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Christian Hewitt , Soeren Moch Cc: brcm80211-dev-list.pdl@broadcom.com, Heiko Stuebner , Neil Armstrong , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, brcm80211-dev-list@cypress.com, Kalle Valo List-Id: linux-rockchip.vger.kernel.org On 12/22/2019 5:35 AM, Christian Hewitt wrote: > >> On 19 Dec 2019, at 2:04 am, Soeren Moch wrote: >> >> I guess you need similar enhancements of the board device tree as in >> patch 8 of this series for your VIM3 board. > > Wider testing now points to a known SDIO issue (SoC bug) with Amlogic G12A/B hardware. The merged workaround for the bug was only tested with bcmdhd and brcmfmac may require tweaking as the same issue exhibits on an Amlogic G12B device with BCM4356 chip. Testing the series with Amlogic GXM (older) and SM1 (newer) hardware to exclude the SoC bug shows everything working as expected. Hi Christian, Can you elaborate on the "known SDIO issue"? Is it an issue with ADMA or something else. I am asking because there is a workaround in brcmfmac to avoid scatter-gather lists, which may or may not address the issue. Regards, Arend From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63147C2D0CF for ; Tue, 24 Dec 2019 09:02:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 224F220643 for ; Tue, 24 Dec 2019 09:02:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nDjYY+7K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="EJ2m8BgG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 224F220643 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M7ZrNzJHLkzlqEzpo9Jw4f17RLdIDR5webJLCDxxnCQ=; b=nDjYY+7KUB5w7CtwLTxtaAgXn mDKovbKnRhAEoZy111UvHu5ZcG3ZsTYYUFpQ1dwJsZBrQ4/sxpwm4Ms/FHfNT1UJTxDQKwVrW/ICH v4wyzwAroBvt2AvfkjeGeCe3iJtFZmCqkGBEETeyTNciq6uHCjoVnyp0pCroRFTQbkSVZSWtVNJ3d LuWz7ZxwZrqqKwTm0n88tvAK/FUV7k/e1WV5Yn6OznaYdluzhOqbjIiA4Ir+tMLFY5ZF6D1175pAb r9Xx4zXsk5Wb30x4xqTdy8A51JHYdXBAuPOVKTrmTyOFyMDQzMsLCnT4LURyDUhub3ZsJkXHIr5pT 3Ygv7YKeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijg4r-0000Qp-BC; Tue, 24 Dec 2019 09:02:05 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijg4n-0000P7-7s for linux-arm-kernel@lists.infradead.org; Tue, 24 Dec 2019 09:02:02 +0000 Received: by mail-wm1-x341.google.com with SMTP id p9so1868604wmc.2 for ; Tue, 24 Dec 2019 01:01:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JpIUPsCQ4mUZV8clqM6x3//3zxhuxnyUCEItvWS4lIE=; b=EJ2m8BgGEtcQm8iSYsrb6jbllbscoKNSW55IMHI0wPcev4mLznd5VMRKwg2/sTmJx7 6B0CFsO0Hi5zcoPBFR5UJazH++6qulEdmR+LgsQTpX43ge6h4U8J8ZJNVTYRJqa9zOoX KHYdGmdBFl3qmjTINlKlX73vsGbpXDplIawOo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JpIUPsCQ4mUZV8clqM6x3//3zxhuxnyUCEItvWS4lIE=; b=s5crMWSMuVL4VHOzRdXNEEYj03tq3wqyxfopMlKuomYlVoLJKd8w61NmtkD/sTneXK JqRAurWkRqSUY/Wc/CLYZdjH3iO8QwKv+N3ajTPoFddiw6f71M+AzjvcNHnyZGIhSmiC uXqNKHLnU8z1aHBw/CCvsuFQI5v6NbmH0tvgDR0txNAh7FKOBfS9S2uMa8DB21YpH2ew l5hW7VYWTJa5ZdwOfKaYvQIqSpp8Vato9R4rrxjCRJwLrpzuOZfBAGpgVCOrvtastTsg Ok1+LYrUU4N/bD+0p1R6FX+dFpc6WTZIKSxWiQJtlR6B6XTR8s7eKEZzLxJd7yu7Ppkn hDCA== X-Gm-Message-State: APjAAAXenvgPA0RRjbTMyP4YNK/AEFKnhrtQV9i2Z9Q+1/hIutKbCg1c LwBuspzUv4LMXR6mSngdkABVkQ== X-Google-Smtp-Source: APXvYqwaDJpckqJ1JrVbZPbh8vFZ6XADgxx76CNzAlm8TnNSIoHONxdbgCmk6gW2sYiAbh73ok449A== X-Received: by 2002:a1c:4b01:: with SMTP id y1mr3010277wma.12.1577178118405; Tue, 24 Dec 2019 01:01:58 -0800 (PST) Received: from [10.230.41.59] ([192.19.215.251]) by smtp.gmail.com with ESMTPSA id v22sm1942400wml.11.2019.12.24.01.01.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2019 01:01:57 -0800 (PST) Subject: Re: [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset To: Christian Hewitt , Soeren Moch References: <20191211235253.2539-1-smoch@web.de> <47DB71CE-ACC4-431D-9E66-D28A8C18C0A4@gmail.com> From: Arend Van Spriel Message-ID: <3c42d6de-670d-fee8-aa81-99f44d447e87@broadcom.com> Date: Tue, 24 Dec 2019 10:01:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <47DB71CE-ACC4-431D-9E66-D28A8C18C0A4@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191224_010201_287584_F876BF70 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: brcm80211-dev-list.pdl@broadcom.com, Heiko Stuebner , Neil Armstrong , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, brcm80211-dev-list@cypress.com, Kalle Valo Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/22/2019 5:35 AM, Christian Hewitt wrote: > >> On 19 Dec 2019, at 2:04 am, Soeren Moch wrote: >> >> I guess you need similar enhancements of the board device tree as in >> patch 8 of this series for your VIM3 board. > > Wider testing now points to a known SDIO issue (SoC bug) with Amlogic G12A/B hardware. The merged workaround for the bug was only tested with bcmdhd and brcmfmac may require tweaking as the same issue exhibits on an Amlogic G12B device with BCM4356 chip. Testing the series with Amlogic GXM (older) and SM1 (newer) hardware to exclude the SoC bug shows everything working as expected. Hi Christian, Can you elaborate on the "known SDIO issue"? Is it an issue with ADMA or something else. I am asking because there is a workaround in brcmfmac to avoid scatter-gather lists, which may or may not address the issue. Regards, Arend _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel