From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] drm/i915: Make vblank evade warnings optional Date: Sun, 7 May 2017 11:46:07 -0600 Message-ID: <3c44fef6-751a-b322-3b84-eef192012606@kernel.dk> References: <20170507171252.5149-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170507171252.5149-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Linus Torvalds List-Id: dri-devel@lists.freedesktop.org T24gMDUvMDcvMjAxNyAxMToxMiBBTSwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3Jv dGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiAKPiBBZGQgYSBuZXcgS2NvbmZpZyBvcHRpb24gdG8gZW5hYmxlL2Rpc2FibGUgdGhlIGV4 dHJhIHdhcm5pbmdzCj4gZnJvbSB0aGUgdmJsYW5rIGV2YWRlIGNvZGUuIEZvciBub3cgd2UnbGwg a2VlcCB0aGUgd2FybmluZwo+IGFib3V0IGFuIGFjdHVhbGx5IG1pc3NlZCB2YmxhbmsgYWx3YXlz IGVuYWJsZWQgYXMgdGhhdCBjYW4gaGF2ZQo+IGFuIGFjdHVhbCB1c2VyIHZpc2libGUgaW1wYWN0 LiBCdXQgaWYgd2UgbWlzcyB0aGUgZGVhZGxpbmUKPiBvdGhyd2lzZSB0aGVyZSdzIG5vIHJlYWwg bmVlZCB0byBib3RoZXIgdGhlIHVzZXIgd2l0aCB0aGF0Lgo+IFdlJ2xsIHdhbnQgdGhlc2Ugd2Fy bmluZ3MgZW5hYmxlZCBkdXJpbmcgZGV2ZWxvcG1lbnQgaG93ZXZlcgo+IHNvIHRoYXQgd2UgY2Fu IGNhdGNoIHJlZ3Jlc3Npb25zLgo+IAo+IEJhc2VkIG9uIHRoZSByZXBvcnRzIGl0IGxvb2tzIGxp a2UgdGhpcyBpcyBzdGlsbCB2ZXJ5IGVhc3kKPiB0byBoaXQgb24gU0tMLCBzbyB3ZSBoYXZlIG1v cmUgd29yayBhaGVhZCBvZiB1cyB0byBvcHRpbWl6ZQo+IHRoZSBjcnRpaWNhbCBzZWN0aW9uIGZ1 cnRoZXIuCgpTaG91bGRuJ3QgaXQganVzdCBiZSBhIGRlYnVnIHByaW50ayBvciBzb21ldGhpbmcg aW5zdGVhZCwgc28gdGhhdCBub3JtYWwKcGVvcGxlIGRvbid0IHNlZSBpdCwgYnV0IHRoZSBmb2xr cyB0aGF0IHR1cm4gb24gZGVidWdnaW5nIGNhbiBnZXQgdGhlCmluZm8gdGhleSBuZWVkPyBTZWVt cyBzaWxseSB0byBhZGQgYSBrY29uZmlnIG9wdGlvbiBmb3IgdGhpcy4KCi0tIApKZW5zIEF4Ym9l CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754544AbdEGVuy (ORCPT ); Sun, 7 May 2017 17:50:54 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:33509 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbdEGVuw (ORCPT ); Sun, 7 May 2017 17:50:52 -0400 Subject: Re: [PATCH] drm/i915: Make vblank evade warnings optional To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org References: <20170507171252.5149-1-ville.syrjala@linux.intel.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , Jani Nikula , Dave Airlie , Linus Torvalds , Maarten Lankhorst From: Jens Axboe Message-ID: <3c44fef6-751a-b322-3b84-eef192012606@kernel.dk> Date: Sun, 7 May 2017 11:46:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170507171252.5149-1-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2017 11:12 AM, ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä > > Add a new Kconfig option to enable/disable the extra warnings > from the vblank evade code. For now we'll keep the warning > about an actually missed vblank always enabled as that can have > an actual user visible impact. But if we miss the deadline > othrwise there's no real need to bother the user with that. > We'll want these warnings enabled during development however > so that we can catch regressions. > > Based on the reports it looks like this is still very easy > to hit on SKL, so we have more work ahead of us to optimize > the crtiical section further. Shouldn't it just be a debug printk or something instead, so that normal people don't see it, but the folks that turn on debugging can get the info they need? Seems silly to add a kconfig option for this. -- Jens Axboe