From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Sireesh Kodali <sireeshkodali1@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 4/9] arm64: dts: qcom: msm8953: Add device tree for Motorola G5 Plus
Date: Mon, 21 Nov 2022 12:17:08 +0100 [thread overview]
Message-ID: <3c8dc34f-c0db-82df-1fed-b80098be6c87@linaro.org> (raw)
In-Reply-To: <20221119203758.888207-5-luca@z3ntu.xyz>
On 19.11.2022 21:37, Luca Weiss wrote:
> From: Sireesh Kodali <sireeshkodali1@gmail.com>
>
> Add device tree for the Motorola G5 Plus (potter) smartphone. This
> device is based on Snapdragon 625 (msm8953) SoC.
>
> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Changes in v2:
> * address review comments from v1
>
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/msm8953-motorola-potter.dts | 305 ++++++++++++++++++
> 2 files changed, 306 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 6bc1be0d525a..eb3cfbac6b82 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -21,6 +21,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-grandmax.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-101.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8992-msft-lumia-octagon-talkman.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts b/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts
> new file mode 100644
> index 000000000000..e890fd53c454
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts
> @@ -0,0 +1,305 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2022, Sireesh Kodali
> + */
> +/dts-v1/;
> +
> +#include "msm8953.dtsi"
> +#include "pm8953.dtsi"
> +#include "pmi8950.dtsi"
> +
> +/delete-node/ &cont_splash_mem;
> +/delete-node/ &qseecom_mem;
> +
> +/ {
> + model = "Motorola G5 Plus";
> + compatible = "motorola,potter", "qcom,msm8953";
> + chassis-type = "handset";
> + qcom,msm-id = <293 0>;
> + qcom,board-id = <0x46 0x83a0>;
> +
> + chosen {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + framebuffer@90001000 {
> + compatible = "simple-framebuffer";
> + reg = <0 0x90001000 0 (2220 * 1920 * 3)>;
> +
> + width = <1080>;
> + height = <1920>;
> + stride = <(1080 * 3)>;
> + format = "r8g8b8";
> +
> + power-domains = <&gcc MDSS_GDSC>;
> +
> + clocks = <&gcc GCC_MDSS_AHB_CLK>,
> + <&gcc GCC_MDSS_AXI_CLK>,
> + <&gcc GCC_MDSS_VSYNC_CLK>,
> + <&gcc GCC_MDSS_MDP_CLK>,
> + <&gcc GCC_MDSS_BYTE0_CLK>,
> + <&gcc GCC_MDSS_PCLK0_CLK>,
> + <&gcc GCC_MDSS_ESC0_CLK>;
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gpio_key_default>;
> +
> + key-volume-up {
> + label = "Volume Up";
> + gpios = <&tlmm 85 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + };
> + };
> +
> + reserved-memory {
> + qseecom_mem: qseecom@84300000 {
> + reg = <0x0 0x84300000 0x0 0x2000000>;
> + no-map;
> + };
> +
> + cont_splash_mem: cont-splash@90001000 {
> + reg = <0x0 0x90001000 0x0 (1080 * 1920 * 3)>;
> + no-map;
> + };
> +
> + reserved@aefd2000 {
> + reg = <0x0 0xaefd2000 0x0 0x2e000>;
> + no-map;
> + };
> +
> + reserved@eefe4000 {
> + reg = <0x0 0xeefe4000 0x0 0x1c000>;
> + no-map;
> + };
> +
> + ramoops@ef000000 {
> + compatible = "ramoops";
> + reg = <0x0 0xef000000 0x0 0x80000>;
> + console-size = <0x40000>;
> + ftrace-size = <0>;
> + record-size = <0x3f800>;
> + pmsg-size = <0x800>;
> + };
> + };
> +
> + vph_pwr: vph-pwr-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vph_pwr";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +};
> +
> +&hsusb_phy {
> + vdd-supply = <&pm8953_l3>;
> + vdda-pll-supply = <&pm8953_l7>;
> + vdda-phy-dpdm-supply = <&pm8953_l13>;
> +
> + status = "okay";
> +};
> +
> +&i2c_3 {
> + status = "okay";
> +
> + touchscreen@20 {
> + reg = <0x20>;
> + compatible = "syna,rmi4-i2c";
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <65 IRQ_TYPE_EDGE_FALLING>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts_reset>;
> +
> + vdd-supply = <&pm8953_l22>;
> + vio-supply = <&pm8953_l6>;
> +
> + syna,reset-delay-ms = <200>;
> + syna,startup-delay-ms = <500>;
> + };
> +};
> +
> +&pm8953_resin {
> + linux,code = <KEY_VOLUMEDOWN>;
> + status = "okay";
> +};
> +
> +&pmi8950_wled {
> + qcom,current-limit-microamp = <25000>;
> + qcom,num-strings = <3>;
> + qcom,external-pfet;
> + qcom,cabc;
> +
> + status = "okay";
> +};
> +
> +&rpm_requests {
> + regulators {
> + compatible = "qcom,rpm-pm8953-regulators";
> + vdd_s1-supply = <&vph_pwr>;
> + vdd_s2-supply = <&vph_pwr>;
> + vdd_s3-supply = <&vph_pwr>;
> + vdd_s4-supply = <&vph_pwr>;
> + vdd_s5-supply = <&vph_pwr>;
> + vdd_s6-supply = <&vph_pwr>;
> + vdd_s7-supply = <&vph_pwr>;
> + vdd_l1-supply = <&pm8953_s3>;
> + vdd_l2_l3-supply = <&pm8953_s3>;
> + vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>;
> + vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>;
> + vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>;
> +
> + pm8953_s1: s1 {
> + regulator-min-microvolt = <863000>;
> + regulator-max-microvolt = <1152000>;
> + };
> +
> + pm8953_s3: s3 {
> + regulator-min-microvolt = <1224000>;
> + regulator-max-microvolt = <1224000>;
> + };
> +
> + pm8953_s4: s4 {
> + regulator-min-microvolt = <1896000>;
> + regulator-max-microvolt = <2048000>;
> + };
> +
> + pm8953_l1: l1 {
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1100000>;
> + };
> +
> + pm8953_l2: l2 {
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + };
> +
> + pm8953_l3: l3 {
> + regulator-min-microvolt = <925000>;
> + regulator-max-microvolt = <925000>;
> + regulator-allow-set-load;
> + };
> +
> + pm8953_l5: l5 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8953_l6: l6 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + pm8953_l7: l7 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1900000>;
> + };
> +
> + pm8953_l8: l8 {
> + regulator-min-microvolt = <2900000>;
> + regulator-max-microvolt = <2900000>;
> + };
> +
> + pm8953_l9: l9 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + pm8953_l10: l10 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8953_l11: l11 {
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <3000000>;
> + };
> +
> + pm8953_l12: l12 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3000000>;
> + };
> +
> + pm8953_l13: l13 {
> + regulator-min-microvolt = <3075000>;
> + regulator-max-microvolt = <3125000>;
> + };
> +
> + pm8953_l15: l15 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8953_l16: l16 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8953_l17: l17 {
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <3000000>;
> + };
> +
> + pm8953_l19: l19 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1350000>;
> + };
> +
> + pm8953_l22: l22 {
> + regulator-always-on;
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2850000>;
> + };
> +
> + pm8953_l23: l23 {
> + regulator-min-microvolt = <975000>;
> + regulator-max-microvolt = <1225000>;
> + };
> + };
> +};
> +
> +&sdhc_1 {
> + vmmc-supply = <&pm8953_l8>;
> + vqmmc-supply = <&pm8953_l5>;
> +
> + status = "okay";
> +};
> +
> +&sdhc_2 {
> + cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
> +
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>;
> + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
> +
> + vmmc-supply = <&pm8953_l11>;
> + vqmmc-supply = <&pm8953_l12>;
> +
> + status = "okay";
> +};
> +
> +&tlmm {
> + gpio-reserved-ranges = <1 2>, <96 4>, <111 1>, <126 1>;
> +
> + ts_reset: ts-reset-state {
> + pins = "gpio64";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +};
> +
> +&usb3 {
> + status = "okay";
> +};
> +
> +&usb3_dwc3 {
> + dr_mode = "peripheral";
> +};
next prev parent reply other threads:[~2022-11-21 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 20:37 [PATCH v2 0/9] Add a bunch of msm8953 dts files Luca Weiss
2022-11-19 20:37 ` [PATCH v2 1/9] dt-bindings: arm: qcom: document new msm8953-family devices Luca Weiss
2022-11-21 9:15 ` Krzysztof Kozlowski
2022-11-19 20:37 ` [PATCH v2 2/9] arm64: dts: qcom: msm8953: Adjust reserved-memory nodes Luca Weiss
2022-11-21 11:15 ` Konrad Dybcio
2022-11-19 20:37 ` [PATCH v2 3/9] arm64: dts: qcom: sdm450: Add device tree for Motorola Moto G6 Luca Weiss
2022-11-21 11:16 ` Konrad Dybcio
2022-11-19 20:37 ` [PATCH v2 4/9] arm64: dts: qcom: msm8953: Add device tree for Motorola G5 Plus Luca Weiss
2022-11-21 11:17 ` Konrad Dybcio [this message]
2022-11-19 20:37 ` [PATCH v2 5/9] arm64: dts: qcom: msm8953: Add device tree for Xiaomi Mi A2 Lite Luca Weiss
2022-11-21 11:17 ` Konrad Dybcio
2022-11-19 20:37 ` [PATCH v2 6/9] arm64: dts: qcom: msm8953: Add device tree for Xiaomi Redmi Note 4X Luca Weiss
2022-11-21 11:18 ` Konrad Dybcio
2022-11-19 20:37 ` [PATCH v2 7/9] arm64: dts: qcom: msm8953: Add device tree for Xiaomi Mi A1 Luca Weiss
2022-11-21 11:18 ` Konrad Dybcio
2022-11-19 20:37 ` [PATCH v2 8/9] arm64: dts: qcom: msm8953: Add device tree for Xiaomi Redmi 5 Plus Luca Weiss
2022-11-21 11:19 ` Konrad Dybcio
2022-11-19 20:37 ` [PATCH v2 9/9] arm64: dts: qcom: sdm632: Add device tree for Motorola G7 Power Luca Weiss
2022-11-21 11:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c8dc34f-c0db-82df-1fed-b80098be6c87@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sireeshkodali1@gmail.com \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.