All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jiayuan Chen" <jiayuan.chen@linux.dev>
To: "Ihor Solodrai" <ihor.solodrai@linux.dev>,
	ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net,
	eddyz87@gmail.com
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org,
	pabeni@redhat.com, mykolal@fb.com, kernel-team@meta.com
Subject: Re: [PATCH bpf] selftests/bpf: remove sockmap_ktls disconnect_after_delete test
Date: Tue, 15 Apr 2025 16:53:45 +0000	[thread overview]
Message-ID: <3cb523bc8eb334cb420508a84f3f1d37543f4253@linux.dev> (raw)
In-Reply-To: <20250415163332.1836826-1-ihor.solodrai@linux.dev>

April 16, 2025 at 24:33, "Ihor Solodrai" <ihor.solodrai@linux.dev> wrote:
> 
> "sockmap_ktls disconnect_after_delete" test has been failing on BPF CI
> after recent merges from netdev:
> * https://github.com/kernel-patches/bpf/actions/runs/14458537639
> * https://github.com/kernel-patches/bpf/actions/runs/14457178732
> It happens because disconnect has been disabled for TLS [1], and it
> renders the test case invalid. Remove it from the suite.
> [1] https://lore.kernel.org/netdev/20250404180334.3224206-1-kuba@kernel.org/
> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>

Reviewed-by: Jiayuan Chen <jiayuan.chen@linux.dev>

The original selftest patch used disconnect to re-produce the endless
loop caused by tcp_bpf_unhash, which has already been removed.

I hope this doesn't conflict with bpf-next...

Thanks.

  reply	other threads:[~2025-04-15 16:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 16:33 [PATCH bpf] selftests/bpf: remove sockmap_ktls disconnect_after_delete test Ihor Solodrai
2025-04-15 16:53 ` Jiayuan Chen [this message]
2025-04-15 17:00   ` Ihor Solodrai
2025-04-15 17:05     ` Alexei Starovoitov
2025-04-15 17:37       ` Ihor Solodrai
2025-04-16  1:10         ` Jiayuan Chen
2025-04-16  1:43           ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cb523bc8eb334cb420508a84f3f1d37543f4253@linux.dev \
    --to=jiayuan.chen@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.