From: "Christian König" <christian.koenig@amd.com>
To: Xi Ruoyao <xry111@xry111.site>, Icenowy Zheng <uwu@icenowy.me>,
Alex Deucher <alexander.deucher@amd.com>,
Pan Xinhui <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev
Subject: Re: [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content
Date: Mon, 17 Jun 2024 17:53:21 +0200 [thread overview]
Message-ID: <3cc0d360-8f51-4cdd-90fd-1fa0a199c2ba@amd.com> (raw)
In-Reply-To: <e27a5acebe5c7d1e09edbc9dc49f52b672d72988.camel@xry111.site>
Am 17.06.24 um 17:35 schrieb Xi Ruoyao:
> On Mon, 2024-06-17 at 22:30 +0800, Icenowy Zheng wrote:
>>> Two consecutive writes to the same bus address are perfectly legal
>>> from
>>> the PCIe specification and can happen all the time, even without this
>>> specific hw workaround.
>> Yes I know it, and I am not from Loongson, just some user trying to
>> mess around it.
> There are some purposed "workarounds" like reducing the link speed (from
> x16 to x8), tweaking the power management setting, etc. Someone even
> claims improving the heat sink of the LS7A chip can help to work around
> this issue but I'm really skeptical...
Well when it's an ordering problem between writes and interrupts then
nothing else than getting the order right will fix this. Otherwise it
can always be that the CPU doesn't see coherent results from PCIe devices.
In other words if the CPU gets an interrupt but doesn't sees the fence
value written it will assume the work is not done. But since the
hardware won't trigger a second interrupt the CPU will then keep waiting
for the operation to finish forever.
This is not limited to GPUs, but will potentially happen with network or
disk I/O as well.
Regards,
Christian.
next prev parent reply other threads:[~2024-06-17 15:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 10:58 [PATCH 0/2] Fixes of AMD GFX7/8 hang on Loongson platforms Icenowy Zheng
2024-06-17 10:58 ` [PATCH 1/2] drm/amdgpu: make duplicated EOP packet for GFX7/8 have real content Icenowy Zheng
2024-06-17 12:35 ` Christian König
2024-06-17 13:03 ` Icenowy Zheng
2024-06-17 13:09 ` Christian König
2024-06-17 13:43 ` Icenowy Zheng
2024-06-17 13:59 ` Christian König
2024-06-17 14:30 ` Icenowy Zheng
2024-06-17 14:42 ` Christian König
2024-06-17 14:57 ` Icenowy Zheng
2024-06-17 15:07 ` Christian König
2024-06-17 15:35 ` Xi Ruoyao
2024-06-17 15:53 ` Christian König [this message]
2024-06-17 16:09 ` Icenowy Zheng
2024-06-18 6:20 ` Christian König
2024-06-17 10:58 ` [PATCH 2/2] drm/radeon: repeat the same EOP packet for EOP workaround on CIK Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cc0d360-8f51-4cdd-90fd-1fa0a199c2ba@amd.com \
--to=christian.koenig@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chenhuacai@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=uwu@icenowy.me \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.