Re: [PATCH v2 4/6] drm/xe/xe_ras: Add function to get maximum pages firmware can store

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 07-09-2026 15:17, Riana Tauro wrote:
> Add function to get maximum number of pages that firmware can store for
> offline tracking. This will be used in sysfs while reporting bad pages.
> 
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_ras.c       | 4 ++++
>   drivers/gpu/drm/xe/xe_ras.h       | 5 +++++
>   drivers/gpu/drm/xe/xe_ras_types.h | 2 ++
>   3 files changed, 11 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
> index b5b0c1a3a663..7058482e32a9 100644
> --- a/drivers/gpu/drm/xe/xe_ras.c
> +++ b/drivers/gpu/drm/xe/xe_ras.c
> @@ -381,6 +381,7 @@ static void get_offlined_list(struct xe_device *xe)
>   	struct xe_sysctrl_mailbox_command command = {0};
>   	struct xe_ras_offline_list_response response = {0};
>   	struct xe_ras_offline_list_request request = {0};
> +	struct xe_ras_state *state = &xe->ras.state;
>   	u32 count = 0, total_pages = 0;
>   	size_t rlen;
>   	int ret, i;
> @@ -412,6 +413,9 @@ static void get_offlined_list(struct xe_device *xe)
>   		for (i = 0; i < response.pages_returned && i < XE_RAS_NUM_PAGES; i++)
>   			handle_page_offline(xe, response.page_addresses[i], false);
>   
> +		if (!state->max_pages)
> +			state->max_pages = response.max_entries;
> +
>   		count += response.pages_returned;
>   		if (!response.pages_returned)
>   			break;
> diff --git a/drivers/gpu/drm/xe/xe_ras.h b/drivers/gpu/drm/xe/xe_ras.h
> index 6e65443cd262..c411a6cb3731 100644
> --- a/drivers/gpu/drm/xe/xe_ras.h
> +++ b/drivers/gpu/drm/xe/xe_ras.h
> @@ -27,4 +27,9 @@ static inline bool xe_ras_get_disable_page_offline(struct xe_device *xe)
>   	return xe->ras.state.disable_page_offline;
>   }
>   
> +static inline u32 xe_ras_get_max_pages(struct xe_device *xe)
> +{
> +	return xe->ras.state.max_pages;
> +}
> +
>   #endif
> diff --git a/drivers/gpu/drm/xe/xe_ras_types.h b/drivers/gpu/drm/xe/xe_ras_types.h
> index ca459e785add..9f23970fd5a1 100644
> --- a/drivers/gpu/drm/xe/xe_ras_types.h
> +++ b/drivers/gpu/drm/xe/xe_ras_types.h
> @@ -423,5 +423,7 @@ struct xe_ras_set_health_response {
>   struct xe_ras_state {
>   	/** @disable_page_offline: cached configfs policy, immutable after init */
>   	bool disable_page_offline;
> +	/** @max_pages: Total number of pages that can be stored by firmware */
> +	u32 max_pages;

LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   };
>   #endif