Re: [PATCH bpf-next 08/14] selftests/bpf: Add test for arguments without names in static functions

[Alan Maguire <alan.maguire@oracle.com>]

On 30/09/2026 20:31, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
> 
> Check that BTF with a static function that has an argument without a name
> is loaded.
> 
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

Nit: a few extra comments for readability would be no harm (see below), and
it might be useful to add a global function with a vararg parameter (signalled
by a proto parameter with type id 0), since that allows an empty name too.


Acked-by: Alan Maguire <alan.maguire@oracle.com>

> ---
>  tools/testing/selftests/bpf/prog_tests/btf.c | 24 ++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/btf.c b/tools/testing/selftests/bpf/prog_tests/btf.c
> index 21fdeeb23405..751cb14c1949 100644
> --- a/tools/testing/selftests/bpf/prog_tests/btf.c
> +++ b/tools/testing/selftests/bpf/prog_tests/btf.c
> @@ -2819,6 +2819,30 @@ static struct btf_raw_test raw_tests[] = {
>  	.err_str = "Invalid arg#2",
>  },
>  
> +{
> +	.descr = "func (Some arg of static func has no name)",
> +	.raw_types = {

		/* int */
> +		BTF_TYPE_INT_ENC(0, BTF_INT_SIGNED, 0, 32, 4),	/* [1] */
		/* unsigned int */
> +		BTF_TYPE_INT_ENC(0, 0, 0, 32, 4),		/* [2] */
> +		/* void (*)(int a, unsigned int) */
> +		BTF_FUNC_PROTO_ENC(0, 2),			/* [3] */
> +			BTF_FUNC_PROTO_ARG_ENC(NAME_TBD, 1),
> +			BTF_FUNC_PROTO_ARG_ENC(0, 2),
> +		/* static void func(int a, unsigned int) */
> +		BTF_FUNC_ENC(NAME_TBD, 3),			/* [4] */
> +		BTF_END_RAW,
> +	},
> +	.str_sec = "\0a\0func",
> +	.str_sec_size = sizeof("\0a\0func"),
> +	.map_type = BPF_MAP_TYPE_ARRAY,
> +	.map_name = "func_type_check_btf",
> +	.key_size = sizeof(int),
> +	.value_size = sizeof(int),
> +	.key_type_id = 1,
> +	.value_type_id = 1,
> +	.max_entries = 4,
> +},
> +
>  {
>  	.descr = "func (Non zero vlen)",
>  	.raw_types = {