All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Mehmet Fide" <mehmet.fide@gmail.com>,
	"Ping-Ke Shih" <pkshih@realtek.com>
Cc: "Bitterblue Smith" <rtl8821cerfe2@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v8 3/3] wifi: rtw88: time the countdown downloads from the TBTT
Date: Sun, 25 Oct 2026 12:50:44 +0000	[thread overview]
Message-ID: <3d046336002a182f7751814750ddc522a53968e1@linux.dev> (raw)
In-Reply-To: <20261021114543.4132776-4-mehmet.fide@gmail.com>

October 21, 2026 at 1:45 PM, "Mehmet Fide" <mehmet.fide@gmail.com> wrote:


> 
> From: Mehmet Fide <mehmet.fide@screeningeagle.com>
> 
> The countdown downloads are queued one beacon interval apart, with no
> relation to the TBTT. A download that runs late past the next TBTT
> leaves a count out of the air.
> 
> Queue each download 10 ms after the next TBTT, read from the TSF, so it
> may run late by almost a beacon interval; a later one is followed by
> the next at once. A TSF jump, an IBSS merge or a reset, restarts the
> schedule from the next TBTT.
> 
> A TBTT just before the start may already have sent the first count; it
> is taken as the one that did, so no count is sent twice.
> 
> The USB chips raise no TBTT interrupt, so the TSF register is read. The
> beaconing interface is always on port 0: rtw_core_port_switch() moves
> an AP there, an IBSS runs alone.
> 
> Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>

Looking good to me.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

      parent reply	other threads:[~2026-10-25 12:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 11:45 [PATCH rtw-next v8 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-10-21 11:45 ` [PATCH rtw-next v8 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-10-21 11:45 ` [PATCH rtw-next v8 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-10-25 13:24   ` Luka Gejak
2026-10-25 18:47     ` Mehmet Fide
2026-10-27  2:02       ` Ping-Ke Shih
2026-10-27  9:13         ` Mehmet Fide
2026-10-28  1:54           ` Ping-Ke Shih
2026-10-21 11:45 ` [PATCH rtw-next v8 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-10-22  1:57   ` Ping-Ke Shih
2026-10-25 12:50   ` Luka Gejak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d046336002a182f7751814750ddc522a53968e1@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.