From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546632D4B67; Wed, 25 Jun 2025 16:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750869073; cv=none; b=FdPp8pFKND0Cx7bo4kTdBBtwal+LIKe3WRHZEes/YLnb3/LfwGgADX1FKLp+vuDp2NCsq484EXiGdaIhLr3HUve6XvvIrysMTpLL9WoYUh9e/BwxUR48AO7RwvqR2G4fbJkUNWZgKzKOU3fpisg19csNLF6PzGI6oqa+uAq9Ld8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750869073; c=relaxed/simple; bh=9Plc2mchfJSLLakuGSpwC2tchWlUiNQeTbycwDZpd8E=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=rq0kZLHorb78KBRi2rq9GAJ4V7QbK/i+XpfwMashATbaUVDNBz42Brc4pGb8RtafPiArTmqNoCzD40ANLastDt2PyXlSMrvLqcwnF92DyaR937vuhJLOENikrRG9yyMF5fiVmVZ3w/9YY0+h6gir0JOe+iIUWlQ+Sf3pnkJlaBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=d9yfKpap; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="d9yfKpap" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 59E4A25F2D; Wed, 25 Jun 2025 18:31:07 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id f0ZxtAlbNKEs; Wed, 25 Jun 2025 18:31:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1750869065; bh=9Plc2mchfJSLLakuGSpwC2tchWlUiNQeTbycwDZpd8E=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=d9yfKpapXHHKxp9kOOEdSBp99N7NOoXyzrVmdArp9eCp9tmRg/WXJtJPjxEDCae/D 9X780PdaSIChVe50RXfdlyhXnMDaHb2ruJFveI11XxLUIudrW23DeGji5dNWmN9Hv4 Rzvz49xwIr562B4WPHV5ZiDXNhk6tZBZiiGImpgD5NnthDqKfuFftgX44+fRs6wT/c LVtpkoKrreWEhV/MCZG7JE89DfxvQrMy8opuPhv4XtTst6vIKesHtIdlAk0pOKEMzm W08mInmZ3MCu4NhYBDgF6n25hW9+Tg9lPzEchpxaoJW6dMPTPfSq12A/kuU+U7gNYA lAkuH8pWqG58g== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 25 Jun 2025 16:31:04 +0000 From: Kaustabh Chakraborty To: Rob Herring Cc: Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Jessica Zhang , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: document Synaptics TDDI panel driver In-Reply-To: <20250625150804.GA1201460-robh@kernel.org> References: <20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org> <20250625-panel-synaptics-tddi-v2-1-7a62ab1d13c7@disroot.org> <20250625150804.GA1201460-robh@kernel.org> Message-ID: <3d08062eb822e2fdcc1498bc1d34075f@disroot.org> X-Sender: kauschluss@disroot.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2025-06-25 15:08, Rob Herring wrote: > On Wed, Jun 25, 2025 at 03:38:44PM +0530, Kaustabh Chakraborty wrote: >> Document the driver for Synaptics TDDI (Touch/Display Integration) >> panels. > > We document the h/w, not 'the driver'. > >> Along with the MIPI-DSI panel, these devices also have an in-built LED >> backlight device and a touchscreen, all packed together in a single >> chip. >> Also, add compatibles for supported panels - TD4101 and TD4300. >> >> Signed-off-by: Kaustabh Chakraborty >> --- >> .../display/panel/synaptics,td4300-panel.yaml | 89 >> ++++++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/panel/synaptics,td4300-panel.yaml >> b/Documentation/devicetree/bindings/display/panel/synaptics,td4300-panel.yaml >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..10ac24afdfbc43ca6913bf8a343413eed81f12ff >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/display/panel/synaptics,td4300-panel.yaml >> @@ -0,0 +1,89 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: >> http://devicetree.org/schemas/display/panel/synaptics,td4300-panel.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Synaptics TDDI Display Panel Controller >> + >> +maintainers: >> + - Kaustabh Chakraborty >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + enum: >> + - syna,td4101-panel >> + - syna,td4300-panel > > Can a TD4101 be anything other than a panel (controller)? If not, then > '-panel' is redundant. > TDDI devices are display panels and touchscreens in one chip. So I guess it's better to explicitly define that its a panel driver. (Touchscreens are driven by RMI4) >> + >> + reg: >> + maxItems: 1 >> + >> + vio-supply: >> + description: core I/O voltage supply >> + >> + vsn-supply: >> + description: negative voltage supply for analog circuits >> + >> + vsp-supply: >> + description: positive voltage supply for analog circuits >> + >> + backlight-gpios: >> + maxItems: 1 >> + description: backlight enable GPIO >> + >> + reset-gpios: true >> + width-mm: true >> + height-mm: true >> + panel-timing: true >> + >> +required: >> + - compatible >> + - reg >> + - width-mm >> + - height-mm >> + - panel-timing >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + dsi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + panel@0 { >> + compatible = "synaptics,td4300-panel"; >> + reg = <0>; >> + >> + vio-supply = <&panel_vio_reg>; >> + vsn-supply = <&panel_vsn_reg>; >> + vsp-supply = <&panel_vsp_reg>; >> + >> + backlight-gpios = <&gpd3 5 GPIO_ACTIVE_LOW>; >> + reset-gpios = <&gpd3 4 GPIO_ACTIVE_LOW>; >> + >> + width-mm = <68>; >> + height-mm = <121>; >> + >> + panel-timing { >> + clock-frequency = <144389520>; >> + >> + hactive = <1080>; >> + hsync-len = <4>; >> + hfront-porch = <120>; >> + hback-porch = <32>; >> + >> + vactive = <1920>; >> + vsync-len = <2>; >> + vfront-porch = <21>; >> + vback-porch = <4>; >> + }; >> + }; >> + }; >> + >> +... >> >> -- >> 2.49.0 >>