From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B6CC43461 for ; Tue, 15 Sep 2020 09:28:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12BE12080C for ; Tue, 15 Sep 2020 09:28:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgIOJ2J (ORCPT ); Tue, 15 Sep 2020 05:28:09 -0400 Received: from mga06.intel.com ([134.134.136.31]:53723 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbgIOJ2G (ORCPT ); Tue, 15 Sep 2020 05:28:06 -0400 IronPort-SDR: rYTiCGzgd309QTtNs9KO2BZ6PSMcjcrHmOfsTzTEZVDcL0yiT7aknzkr2MwHUqaNKVyti3MZ3h Bxy4gLGLTedg== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="220783202" X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="220783202" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 02:28:05 -0700 IronPort-SDR: 4rwKLeGNVy5cabFduP7pXfH4mBNUqOmLSM+upuBjDAfJ0toswvdkqMdDn8a5P2OiEGVCLWBWAz lUr+gFvuQCjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="331108478" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.170]) ([10.237.72.170]) by fmsmga004.fm.intel.com with ESMTP; 15 Sep 2020 02:28:04 -0700 Subject: Re: [PATCH v2] usb: xhci: add debugfs support for ep with stream To: Jun Li , "mathias.nyman@intel.com" Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , dl-linux-imx References: <1594901321-6992-1-git-send-email-jun.li@nxp.com> <5257ec39-9f59-58fe-661f-a1cd69955f1e@linux.intel.com> From: Mathias Nyman Openpgp: preference=signencrypt Autocrypt: addr=mathias.nyman@linux.intel.com; prefer-encrypt=mutual; keydata= mQINBFMB0ccBEADd+nZnZrFDsIjQtclVz6OsqFOQ6k0nQdveiDNeBuwyFYykkBpaGekoHZ6f lH4ogPZzQ+pzoJEMlRGXc881BIggKMCMH86fYJGfZKWdfpg9O6mqSxyEuvBHKe9eZCBKPvoC L2iwygtO8TcXXSCynvXSeZrOwqAlwnxWNRm4J2ikDck5S5R+Qie0ZLJIfaId1hELofWfuhy+ tOK0plFR0HgVVp8O7zWYT2ewNcgAzQrRbzidA3LNRfkL7jrzyAxDapuejuK8TMrFQT/wW53e uegnXcRJaibJD84RUJt+mJrn5BvZ0MYfyDSc1yHVO+aZcpNr+71yZBQVgVEI/AuEQ0+p9wpt O9Wt4zO2KT/R5lq2lSz1MYMJrtfFRKkqC6PsDSB4lGSgl91XbibK5poxrIouVO2g9Jabg04T MIPpVUlPme3mkYHLZUsboemRQp5/pxV4HTFR0xNBCmsidBICHOYAepCzNmfLhfo1EW2Uf+t4 L8IowAaoURKdgcR2ydUXjhACVEA/Ldtp3ftF4hTQ46Qhba/p4MUFtDAQ5yeA5vQVuspiwsqB BoL/298+V119JzM998d70Z1clqTc8fiGMXyVnFv92QKShDKyXpiisQn2rrJVWeXEIVoldh6+ J8M3vTwzetnvIKpoQdSFJ2qxOdQ8iYRtz36WYl7hhT3/hwkHuQARAQABtCdNYXRoaWFzIE55 bWFuIDxtYXRoaWFzLm55bWFuQGdtYWlsLmNvbT6JAjsEEwECACUCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheABQJTAeo1AhkBAAoJEFiDn/uYk8VJOdIP/jhA+RpIZ7rdUHFIYkHEKzHw tkwrJczGA5TyLgQaI8YTCTPSvdNHU9Rj19mkjhUO/9MKvwfoT2RFYqhkrtk0K92STDaBNXTL JIi4IHBqjXOyJ/dPADU0xiRVtCHWkBgjEgR7Wihr7McSdVpgupsaXhbZjXXgtR/N7PE0Wltz hAL2GAnMuIeJyXhIdIMLb+uyoydPCzKdH6znfu6Ox76XfGWBCqLBbvqPXvk4oH03jcdt+8UG 2nfSeti/To9ANRZIlSKGjddCGMa3xzjtTx9ryf1Xr0MnY5PeyNLexpgHp93sc1BKxKKtYaT0 lR6p0QEKeaZ70623oB7Sa2Ts4IytqUVxkQKRkJVWeQiPJ/dZYTK5uo15GaVwufuF8VTwnMkC 4l5X+NUYNAH1U1bpRtlT40aoLEUhWKAyVdowxW4yGCP3nL5E69tZQQgsag+OnxBa6f88j63u wxmOJGNXcwCerkCb+wUPwJzChSifFYmuV5l89LKHgSbv0WHSN9OLkuhJO+I9fsCNvro1Y7dT U/yq4aSVzjaqPT3yrnQkzVDxrYT54FLWO1ssFKAOlcfeWzqrT9QNcHIzHMQYf5c03Kyq3yMI Xi91hkw2uc/GuA2CZ8dUD3BZhUT1dm0igE9NViE1M7F5lHQONEr7MOCg1hcrkngY62V6vh0f RcDeV0ISwlZWuQINBFMB0ccBEACXKmWvojkaG+kh/yipMmqZTrCozsLeGitxJzo5hq9ev31N 2XpPGx4AGhpccbco63SygpVN2bOd0W62fJJoxGohtf/g0uVtRSuK43OTstoBPqyY/35+VnAV oA5cnfvtdx5kQPIL6LRcxmYKgN4/3+A7ejIxbOrjWFmbWCC+SgX6mzHHBrV0OMki8R+NnrNa NkUmMmosi7jBSKdoi9VqDqgQTJF/GftvmaZHqgmVJDWNrCv7UiorhesfIWPt1O/AIk9luxlE dHwkx5zkWa9CGYvV6LfP9BznendEoO3qYZ9IcUlW727Le80Q1oh69QnHoI8pODDBBTJvEq1h bOWcPm/DsNmDD8Rwr/msRmRyIoxjasFi5WkM/K/pzujICKeUcNGNsDsEDJC5TCmRO/TlvCvm 0X+vdfEJRZV6Z+QFBflK1asUz9QHFre5csG8MyVZkwTR9yUiKi3KiqQdaEu+LuDD2CGF5t68 xEl66Y6mwfyiISkkm3ETA4E8rVZP1rZQBBm83c5kJEDvs0A4zrhKIPTcI1smK+TWbyVyrZ/a mGYDrZzpF2N8DfuNSqOQkLHIOL3vuOyx3HPzS05lY3p+IIVmnPOEdZhMsNDIGmVorFyRWa4K uYjBP/W3E5p9e6TvDSDzqhLoY1RHfAIadM3I8kEx5wqco67VIgbIHHB9DbRcxQARAQABiQIf BBgBAgAJBQJTAdHHAhsMAAoJEFiDn/uYk8VJb7AQAK56tgX8V1Wa6RmZDmZ8dmBC7W8nsMRz PcKWiDSMIvTJT5bygMy1lf7gbHXm7fqezRtSfXAXr/OJqSA8LB2LWfThLyuuCvrdNsQNrI+3 D+hjHJjhW/4185y3EdmwwHcelixPg0X9EF+lHCltV/w29Pv3PiGDkoKxJrnOpnU6jrwiBebz eAYBfpSEvrCm4CR4hf+T6MdCs64UzZnNt0nxL8mLCCAGmq1iks9M4bZk+LG36QjCKGh8PDXz 9OsnJmCggptClgjTa7pO6040OW76pcVrP2rZrkjo/Ld/gvSc7yMO/m9sIYxLIsR2NDxMNpmE q/H7WO+2bRG0vMmsndxpEYS4WnuhKutoTA/goBEhtHu1fg5KC+WYXp9wZyTfeNPrL0L8F3N1 BCEYefp2JSZ/a355X6r2ROGSRgIIeYjAiSMgGAZMPEVsdvKsYw6BH17hDRzltNyIj5S0dIhb Gjynb3sXforM/GVbr4mnuxTdLXQYlj2EJ4O4f0tkLlADT7podzKSlSuZsLi2D+ohKxtP3U/r 42i8PBnX2oAV0UIkYk7Oel/3hr0+BP666SnTls9RJuoXc7R5XQVsomqXID6GmjwFQR5Wh/RE IJtkiDAsk37cfZ9d1kZ2gCQryTV9lmflSOB6AFZkOLuEVSC5qW8M/s6IGDfYXN12YJaZPptJ fiD/ Message-ID: <3d1cd6bf-b798-cdf4-e30b-3abed0a8c280@linux.intel.com> Date: Tue, 15 Sep 2020 12:31:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 4.9.2020 13.01, Jun Li wrote: > > >> -----Original Message----- >> From: Mathias Nyman >> Sent: Thursday, September 3, 2020 5:39 PM >> To: Jun Li ; mathias.nyman@intel.com >> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; dl-linux-imx >> >> Subject: Re: [PATCH v2] usb: xhci: add debugfs support for ep with stream >> >> On 3.9.2020 10.46, Jun Li wrote: >>> >>>> -----Original Message----- >>>> From: Mathias Nyman >>>> Sent: Thursday, September 3, 2020 3:24 PM >>>> To: Jun Li ; mathias.nyman@intel.com >>>> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; >>>> dl-linux-imx >>>> Subject: Re: [PATCH v2] usb: xhci: add debugfs support for ep with >>>> stream >>>> >>>>>> I think this debugfs code is just called too early. It shouldn't >>>>>> need to check new_ring pointer at all. >>>>>> >>>>>> I wrote a fix that changes the order and makes sure endpoint is >>>>>> enabled and ring pointer is set correctly before we call >>>>>> xhci_debugfs_create_endpoint() >>>>>> >>>>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg >>>>>> it >>>>>> .kernel.o >>>>>> rg%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmnyman%2Fxhci.git%2Fcommit% >>>>>> 2F >>>>>> %3Fh%3Dfo >>>>>> r-usb-linus%26id%3Dcf99aef5624a592fd4f3374c7060bfa1a65f15df&dat >>>>>> a= >>>>>> 02%7C01%7 >>>>>> Cjun.li%40nxp.com%7C73e4663a6f6641fbb8b308d84f3d021a%7C686ea1d3bc2b >>>>>> 4c >>>>>> 6fa92cd99 >>>>>> c5c301635%7C0%7C0%7C637346470803922895&sdata=i4DfCW8EVUSAWnzb8Q >>>>>> l4 >>>>>> jPjAOD5wp >>>>>> tfbaMrO8vKvtDc%3D&reserved=0 >>>>> >>>>> This is a good place for non-zero Eps, but does not cover ep0. >>>>> >>>> >>>> ep0 is special, it's not touched in these add/drop endpoint or check >>>> bandwidth functions. >>>> >>>> ep0 ring is allocated earlier during slot creation in >>>> xhci_alloc_virt_device() >>>> ... >>>> /* Allocate endpoint 0 ring */ >>>> dev->eps[0].ring = xhci_ring_alloc(xhci, 2, 1, TYPE_CTRL, 0, >>>> flags); >>>> >>>> and for debugfs ep00 is added manually together with the slot >>>> xhci_debugfs_create_slot() >>>> ... >>>> xhci_debugfs_create_ring_dir(xhci, &dev->eps[0].ring, "ep00", >>>> priv->root); >>>> >>>> So regarding ep0 the change should be ok. >>> >>> Sorry, I forgot debugfs of ep0 is created via xhci_debugfs_create_slot(). >>> >>> Then I think your change is OK, also I gave a test with my stream/UAS >>> device on top of your patch and it can work fine. >>> >>> Do you need I post a new version of my patch(to remove touch of .new_ring)? >> >> If you could yes, and also change to a double pointer: >> >> struct xhci_ep_priv { >> ... >> + struct xhci_ring **show_ring; > > With current: struct xhci_ring *show_ring; > As I use one trb file to show different trb rings for one EP, so I need get > the addr of trb ring pointed by show_ring(which can be updated). > > If I change it to be **show_ring, then I am passing the addr of dev->eps[i].ring > to debugfs so I can't use show_ring's update value when show trb, makes me > not easy to get the addr of target trb ring. Right, ok, lets not use the douple pointer. We just have to trust epriv->show_ring is up to date. -Mathias