From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyi3d-0000Or-Uz for qemu-devel@nongnu.org; Thu, 13 Apr 2017 12:57:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyi3Z-0001RL-3i for qemu-devel@nongnu.org; Thu, 13 Apr 2017 12:57:22 -0400 References: <20170412174920.8744-1-eblake@redhat.com> <20170412174920.8744-4-eblake@redhat.com> <44a88413-bbe0-c67f-8700-d3777888647c@redhat.com> <43ec2498-b32f-b3c1-37cb-e5bce27844be@redhat.com> <077cd9f0-110a-f2ea-fcf9-31b6f4c8b2c1@virtuozzo.com> From: John Snow Message-ID: <3d2bce13-66cd-4d2c-3382-9964fc70400a@redhat.com> Date: Thu, 13 Apr 2017 12:57:00 -0400 MIME-Version: 1.0 In-Reply-To: <077cd9f0-110a-f2ea-fcf9-31b6f4c8b2c1@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, Max Reitz On 04/13/2017 05:19 AM, Vladimir Sementsov-Ogievskiy wrote: > 13.04.2017 02:40, John Snow wrote: >> >> On 04/12/2017 07:36 PM, Eric Blake wrote: >>> On 04/12/2017 05:47 PM, John Snow wrote: >>>> >>>> On 04/12/2017 01:49 PM, Eric Blake wrote: >>>>> We had several functions that no one was using, and which used >>>>> sector-based interfaces. I'm trying to convert towards byte-based >>>>> interfaces, so it's easier to just drop the unused functions: >>>>> >>>>> bdrv_dirty_bitmap_size >>>>> bdrv_dirty_bitmap_get_meta >>>>> bdrv_dirty_bitmap_reset_meta >>>>> bdrv_dirty_bitmap_meta_granularity >>>>> >>>>> Signed-off-by: Eric Blake >>>>> --- >>>>> include/block/dirty-bitmap.h | 8 -------- >>>>> block/dirty-bitmap.c | 34 ---------------------------------- >>>>> 2 files changed, 42 deletions(-) >>>>> >>>> I think it's likely Vladimir is or at least was relying on some of >>>> these >>>> for his migration and persistence series. >>>> >>>> Might be nice to let him chime in to see how much of a hassle this is. >>> Then let's add him in cc ;) >>> >> Err... I can't just summon people by mentioning them? >> >>> I'm okay if these functions stay because they have a user, but it would >>> also be nice if they were properly byte-based (like everything else in >>> dirty-bitmap at the end of my series). So even if we remove them here, >>> we can revert the removal, and re-add them but with a sane interface. >>> >> OK, but I will offer to do the work in the interest of not slowing >> things down any further. >> >> Do you use any of these, Vladimir? >> >> --js > HI all! > > only bdrv_dirty_bitmap_size() is used. No problem to add it back with my > series next update > > Excellent, thanks! In that case: Reviewed-by: John Snow Should be for the whole series, IIRC. --js