From: Yonghong Song <yonghong.song@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: Add a selftest for x86 jit convergence issues
Date: Wed, 4 Sep 2024 11:28:55 -0700 [thread overview]
Message-ID: <3d3f7579-5749-487f-aa13-81bedca8d15e@linux.dev> (raw)
In-Reply-To: <CAADnVQKEbSrRjautnd7eb+zvNfRintUZTVfACKhVmsrfvN6pfg@mail.gmail.com>
On 9/4/24 9:58 AM, Alexei Starovoitov wrote:
> On Tue, Sep 3, 2024 at 4:00 PM Yonghong Song <yonghong.song@linux.dev> wrote:
>> +#include <linux/bpf.h>
>> +#include <bpf/bpf_helpers.h>
>> +#include "bpf_misc.h"
>> +
>> +#if defined(__TARGET_ARCH_x86)
> Does our test framework need this ifdef and dummy_test below?
> There is __arch_x86_64 below.
> Isn't it enough?
It should be enough. Other arch should be correct although
they do not have convergence issue.
Let me remove above "#if defined(__TARGET_ARCH_x86)" and
do a test again to ensure everything is okay.
>
>> +SEC("socket")
>> +__description("bpf_jit_convergence je <-> jmp")
>> +__success __retval(0)
>> +__arch_x86_64
next prev parent reply other threads:[~2024-09-04 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 22:59 [PATCH bpf-next v2 1/2] bpf, x64: Fix a jit convergence issue Yonghong Song
2024-09-03 22:59 ` [PATCH bpf-next v2 2/2] selftests/bpf: Add a selftest for x86 jit convergence issues Yonghong Song
2024-09-04 16:58 ` Alexei Starovoitov
2024-09-04 18:28 ` Yonghong Song [this message]
2024-09-04 16:56 ` [PATCH bpf-next v2 1/2] bpf, x64: Fix a jit convergence issue Alexei Starovoitov
2024-09-04 18:32 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d3f7579-5749-487f-aa13-81bedca8d15e@linux.dev \
--to=yonghong.song@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.