From: Usama Arif <usamaarif642@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
shakeel.butt@linux.dev, david@redhat.com, ying.huang@intel.com,
hughd@google.com, willy@infradead.org, yosryahmed@google.com,
nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v7 1/2] mm: store zero pages to be swapped out in a bitmap
Date: Fri, 5 Jul 2024 10:41:36 +0100 [thread overview]
Message-ID: <3d56d422-8d12-4ba7-9aec-704f08ecf07d@gmail.com> (raw)
In-Reply-To: <20240704162256.f64fa9b6752d0d5e003f9c18@linux-foundation.org>
On 05/07/2024 02:22, Andrew Morton wrote:
> On Mon, 1 Jul 2024 20:15:46 +0300 Usama Arif <usamaarif642@gmail.com> wrote:
>
>> Changes from v7 (Johannes):
>> - Give overview and explain how locking works in zeromap in comments
>> - Add comment for why last word is checked first when checking if
>> folio is zero-filled
>> - Merge is_folio_zero_filled and is_folio_page_zero_filled into
>> 1 function.
>> - Use folio_zero_range to fill a folio with zero at readtime.
>> - Put swap_zeromap_folio_clear in an else branch (even if checkpatch
>> gives warning) and add comment to make it explicitly clear that it
>> needs to happen if folio is not zero filled.
>> - add missing kvfree for zeromap incase swapon fails.
>
> I queued the below as a delta against what was in mm-unstable.
>
> Can we please get this nailed down?
Thanks, yes its finished. There won't be anymore changes on this anymore.
next prev parent reply other threads:[~2024-07-05 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 10:55 [PATCH v7 0/2] mm: store zero pages to be swapped out in a bitmap Usama Arif
2024-06-27 10:55 ` [PATCH v7 1/2] " Usama Arif
2024-06-27 16:18 ` Johannes Weiner
2024-06-28 15:30 ` Usama Arif
2024-07-01 15:01 ` Usama Arif
2024-07-01 15:37 ` Usama Arif
2024-07-01 17:15 ` Usama Arif
2024-07-04 23:22 ` Andrew Morton
2024-07-05 9:41 ` Usama Arif [this message]
2024-06-27 10:55 ` [PATCH v7 2/2] mm: remove code to handle same filled pages Usama Arif
2024-06-27 16:19 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d56d422-8d12-4ba7-9aec-704f08ecf07d@gmail.com \
--to=usamaarif642@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.