From: "Huang, ZhiminX" <zhiminx.huang@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix PROT filed for rss hash
Date: Tue, 3 Nov 2020 08:31:04 +0000 [thread overview]
Message-ID: <3d65f8ecbe2c4fd3990166a0d5b75ce2@intel.com> (raw)
In-Reply-To: <20201103073433.22492-1-jia.guo@intel.com>
Tested-by: Huang, ZhiminX <zhiminx.huang@intel.com>
Regards,
HuangZhiMin
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jeff Guo
> Sent: Tuesday, November 3, 2020 3:35 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: [dpdk-dev] [PATCH v2] net/iavf: fix PROT filed for rss hash
>
> Add PROT field into IPv4 and IPv6 protocol headers for rss hash.
>
> Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
> v2:
> add prot into the new hdr replace of function modify
> ---
> drivers/net/iavf/iavf_hash.c | 32 ++++++++++++++++++++++++--------
> 1 file changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index
> b56152c5b8..804deec5fe 100644
> --- a/drivers/net/iavf/iavf_hash.c
> +++ b/drivers/net/iavf/iavf_hash.c
> @@ -101,11 +101,23 @@ iavf_hash_parse_pattern_action(struct
> iavf_adapter *ad,
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) | \
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST),
> {BUFF_NOUSED} }
>
> +#define proto_hdr_ipv4_with_prot { \
> + VIRTCHNL_PROTO_HDR_IPV4, \
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) | \
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) | \
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT),
> {BUFF_NOUSED} }
> +
> #define proto_hdr_ipv6 { \
> VIRTCHNL_PROTO_HDR_IPV6, \
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) | \
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST),
> {BUFF_NOUSED} }
>
> +#define proto_hdr_ipv6_with_prot { \
> + VIRTCHNL_PROTO_HDR_IPV6, \
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) | \
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) | \
> + FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT),
> {BUFF_NOUSED} }
> +
> #define proto_hdr_udp { \
> VIRTCHNL_PROTO_HDR_UDP, \
> FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) | \ @@ -
> 151,13 +163,15 @@ struct virtchnl_proto_hdrs outer_ipv4_tmplt = {
>
> struct virtchnl_proto_hdrs outer_ipv4_udp_tmplt = {
> TUNNEL_LEVEL_OUTER, 5,
> - {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv4,
> + {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
> + proto_hdr_ipv4_with_prot,
> proto_hdr_udp}
> };
>
> struct virtchnl_proto_hdrs outer_ipv4_tcp_tmplt = {
> TUNNEL_LEVEL_OUTER, 5,
> - {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv4,
> + {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
> + proto_hdr_ipv4_with_prot,
> proto_hdr_tcp}
> };
>
> @@ -174,13 +188,15 @@ struct virtchnl_proto_hdrs outer_ipv6_tmplt = {
>
> struct virtchnl_proto_hdrs outer_ipv6_udp_tmplt = {
> TUNNEL_LEVEL_OUTER, 5,
> - {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv6,
> + {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
> + proto_hdr_ipv6_with_prot,
> proto_hdr_udp}
> };
>
> struct virtchnl_proto_hdrs outer_ipv6_tcp_tmplt = {
> TUNNEL_LEVEL_OUTER, 5,
> - {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv6,
> + {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
> + proto_hdr_ipv6_with_prot,
> proto_hdr_tcp}
> };
>
> @@ -195,11 +211,11 @@ struct virtchnl_proto_hdrs inner_ipv4_tmplt = { };
>
> struct virtchnl_proto_hdrs inner_ipv4_udp_tmplt = {
> - TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4, proto_hdr_udp}
> + TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4_with_prot,
> proto_hdr_udp}
> };
>
> struct virtchnl_proto_hdrs inner_ipv4_tcp_tmplt = {
> - TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4, proto_hdr_tcp}
> + TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4_with_prot,
> proto_hdr_tcp}
> };
>
> struct virtchnl_proto_hdrs inner_ipv4_sctp_tmplt = { @@ -211,11 +227,11
> @@ struct virtchnl_proto_hdrs inner_ipv6_tmplt = { };
>
> struct virtchnl_proto_hdrs inner_ipv6_udp_tmplt = {
> - TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6, proto_hdr_udp}
> + TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6_with_prot,
> proto_hdr_udp}
> };
>
> struct virtchnl_proto_hdrs inner_ipv6_tcp_tmplt = {
> - TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6, proto_hdr_tcp}
> + TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6_with_prot,
> proto_hdr_tcp}
> };
>
> struct virtchnl_proto_hdrs inner_ipv6_sctp_tmplt = {
> --
> 2.20.1
prev parent reply other threads:[~2020-11-03 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 7:34 [dpdk-dev] [PATCH v2] net/iavf: fix PROT filed for rss hash Jeff Guo
2020-11-03 8:31 ` Huang, ZhiminX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d65f8ecbe2c4fd3990166a0d5b75ce2@intel.com \
--to=zhiminx.huang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.