Re: [PATCH v1] lsefi: fixed memory leaks

From: sudhakar <sudhakar@linux.ibm.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: "Renaud Métrich" <rmetrich@redhat.com>, dkiper@net-space.pl
Subject: Re: [PATCH v1] lsefi: fixed memory leaks
Date: Tue, 10 Jun 2025 23:17:29 +0530	[thread overview]
Message-ID: <3d664fcb19b51a19c451e5033fc9e878@linux.ibm.com> (raw)
In-Reply-To: <20250610095239.93779-1-rmetrich@redhat.com>

On 2025-06-10 15:22, Renaud Métrich via Grub-devel wrote:
> Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
> ---
>  grub-core/commands/efi/lsefi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/grub-core/commands/efi/lsefi.c 
> b/grub-core/commands/efi/lsefi.c
> index 7b8316d41..a70f243d0 100644
> --- a/grub-core/commands/efi/lsefi.c
> +++ b/grub-core/commands/efi/lsefi.c
> @@ -1,6 +1,6 @@
>  /*
>   *  GRUB  --  GRand Unified Bootloader
> - *  Copyright (C) 2012  Free Software Foundation, Inc.
> + *  Copyright (C) 2025  Free Software Foundation, Inc.
>   *
>   *  GRUB is free software: you can redistribute it and/or modify
>   *  it under the terms of the GNU General Public License as published 
> by
> @@ -127,8 +127,12 @@ grub_cmd_lsefi (grub_command_t cmd __attribute__
> ((unused)),
>  	    grub_printf ("  %pG\n", protocols[j]);
>  	}
> 
> +      if (protocols)
> +	grub_efi_free_pool (protocols);

Hi Renaud Métrich,

better to use like this

      if (protocols != NULL)
        grub_efi_free_pool (protocols);

thanks,
Sudhakar

>      }
> 
> +  grub_free (handles);
> +
>    return 0;
>  }

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel