From: Adriana Kobylak <anoo@linux.ibm.com>
To: Eddie James <eajames@linux.ibm.com>
Cc: openbmc@lists.ozlabs.org
Subject: Re: USB Gadget Vendor ID
Date: Fri, 12 Apr 2019 10:52:49 -0500 [thread overview]
Message-ID: <3d670716e684620dfcce63d0f5d50ad1@linux.vnet.ibm.com> (raw)
In-Reply-To: <fdb92e78-6cdf-04e3-9b4f-6ca3d36b73e8@linux.ibm.com>
On 2019-04-12 10:24, Eddie James wrote:
> On 4/12/19 10:17 AM, Adriana Kobylak wrote:
>> Hi Eddie,
>>
>> I have a script to initialize the USB gadget for Virtual Media and
>> there was a comment that the Vendor ID should be provided by the Linux
>> Foundation -
>> https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .
>>
>> In your ikvm script you use a Vendor ID with the comment "Linux
>> Foundation" -
>> https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18
>>
>> Is this an ID that came from the LF, and if so could I use it in my
>> script?
>
>
> Hi,
>
> Since OpenBMC is a LF project, I just used their vendor ID... and I
> just invented a serial number. This might not be the proper way to do
> it... Since the devices are virtual, I'm not sure anyone will care
> though?
>
>
Thanks that helps. Forgot to ask about the the product id (echo 0x0104 >
idProduct # Multifunction Composite Gadget), is it also a LF number or
documented somewhere?
>>
>> As a side question, were there any discussions about the serial number
>> value in the ikvm script? I have a similar hard-coded value for the
>> virtual media one but there were questions in the review about how
>> useful could it be having a non-generated value and to have it removed
>> instead.
>
>
> I think there were similar comments about the serial number but in the
> end it was decided to worry about it later I think.
>
> Thanks, Eddie
next prev parent reply other threads:[~2019-04-12 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:17 USB Gadget Vendor ID Adriana Kobylak
2019-04-12 15:24 ` Eddie James
2019-04-12 15:52 ` Adriana Kobylak [this message]
2019-04-12 16:43 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d670716e684620dfcce63d0f5d50ad1@linux.vnet.ibm.com \
--to=anoo@linux.ibm.com \
--cc=eajames@linux.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.