From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C80BC04AB4 for ; Thu, 16 May 2019 08:26:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 412452082E for ; Thu, 16 May 2019 08:26:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 412452082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:50557 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRBiF-0002ju-D7 for qemu-devel@archiver.kernel.org; Thu, 16 May 2019 04:26:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRBhI-0002G1-4K for qemu-devel@nongnu.org; Thu, 16 May 2019 04:25:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRBeu-0008Uc-9G for qemu-devel@nongnu.org; Thu, 16 May 2019 04:22:37 -0400 Received: from 7.mo179.mail-out.ovh.net ([46.105.61.94]:38812) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRBeu-0008TS-1q for qemu-devel@nongnu.org; Thu, 16 May 2019 04:22:36 -0400 Received: from player688.ha.ovh.net (unknown [10.109.143.223]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id C20E512925D for ; Thu, 16 May 2019 10:22:32 +0200 (CEST) Received: from kaod.org (lfbn-1-10649-41.w90-89.abo.wanadoo.fr [90.89.235.41]) (Authenticated sender: clg@kaod.org) by player688.ha.ovh.net (Postfix) with ESMTPSA id 164545BB8434; Thu, 16 May 2019 08:22:26 +0000 (UTC) To: Satheesh Rajendran , Greg Kurz References: <155799221739.527449.14907564571096243745.stgit@bahia.lan> <20190516074551.GB25414@sathnaga86> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <3d7a99b9-5f31-e18d-5cd8-a20c4361efc2@kaod.org> Date: Thu, 16 May 2019 10:22:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190516074551.GB25414@sathnaga86> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 2145965224295369555 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddttddgtddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.61.94 Subject: Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/16/19 9:45 AM, Satheesh Rajendran wrote: > On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: >> Let's suggest to the user how the machine should be configured to allow >> the guest to boot successfully. >> >> Suggested-by: Satheesh Rajendran >> Signed-off-by: Greg Kurz >> --- >> hw/ppc/spapr_hcall.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-and-Tested-by: Satheesh Rajendran you should use two different tags. I don't think patchwork understand compounds. C. > 2019-05-16T07:42:43.018771Z qemu-system-ppc64: Guest requested unavailable interrupt mode (XICS), either don't set the ic-mode machine property or try ic-mode=xics or ic-mode=dual > 2019-05-16 07:42:43.394+0000: shutting down, reason=crashed > >> >> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c >> index 63a55614b83d..aae9fd2b3e6d 100644 >> --- a/hw/ppc/spapr_hcall.c >> +++ b/hw/ppc/spapr_hcall.c >> @@ -1646,12 +1646,12 @@ static target_ulong h_client_architecture_support(PowerPCCPU *cpu, >> */ >> if (guest_xive) { >> if (spapr->irq->ov5 == SPAPR_OV5_XIVE_LEGACY) { >> - error_report("Guest requested unavailable interrupt mode (XIVE)"); >> + error_report("Guest requested unavailable interrupt mode (XIVE), try the ic-mode=xive or ic-mode=dual machine property"); >> exit(EXIT_FAILURE); >> } >> } else { >> if (spapr->irq->ov5 == SPAPR_OV5_XIVE_EXPLOIT) { >> - error_report("Guest requested unavailable interrupt mode (XICS)"); >> + error_report("Guest requested unavailable interrupt mode (XICS), either don't set the ic-mode machine property or try ic-mode=xics or ic-mode=dual"); >> exit(EXIT_FAILURE); >> } >> } >> >