Re: [PATCH] tools top level makefile cleanup

[Christian Limpach <christian.limpach@gmail.com>]

On Tue, 22 Mar 2005 15:10:21 -0600, Jerone Young <jyoung5@us.ibm.com> wrote:
> I cleaned up the top level makefile in the tools directory. No major
> changes. Except I have it so that ioemmu is compiled only with x86_32.

I think the change below changes the behaviour:

> +SUBDIRS :=
> +SUBDIRS += check
...
> -install:
> -       $(MAKE) -C check
> -       $(MAKE) -C libxutil install
...
> +install:
> +       @for subdir in $(SUBDIRS); do \
> +               $(MAKE) -C $$subdir $@ || exit -1; \
> +       done

You're calling ``make -C check install'' while we want to call ``make
-C check''.  See the comments in tools/check/Makefile why we want
this...
# Check this machine is OK for installing on.
# DO NOT use this check from 'make install' in the parent
# directory, as that target can be used to make an installable
# copy rather than actually installing.

At least you didn't try to go down the insane "try to make everything
build in parallel" road, it might work for the tools but you need to
be careful to make sure that targets which other targets depend on get
built first.  None of the fancy Makefile tricks which other people
have posted seem to take this into account :-(

    christian


-------------------------------------------------------
This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005
Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
Embedded(r) & Windows Mobile(tm) platforms, applications & content.  Register
by 3/29 & save $300 http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click