From: Christian Limpach <christian.limpach@gmail.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: xen-devel@lists.sourceforge.net,
Dan Magenheimer <dan.magenheimer@hp.com>
Subject: Re: Re: [patch] final header fixes
Date: Thu, 24 Mar 2005 21:24:26 +0000 [thread overview]
Message-ID: <3d8eece2050324132438c4ca3b@mail.gmail.com> (raw)
In-Reply-To: <200503241503.19423.hollisb@us.ibm.com>
On Thu, 24 Mar 2005 15:03:19 -0600, Hollis Blanchard <hollisb@us.ibm.com> wrote:
> On Thursday 24 March 2005 14:40, Dan Magenheimer wrote:
> > This second patch looks good to me, though I would prefer
> > to change to '#include <asm/regs.h>' from 'struct xen_regs;'
> > as xen_regs is #define'd to pt_regs on ia64 and the explicit
> > use of struct xen_regs in a header could cause header ordering
> > problems later. Will that work for ppc?
>
> Ah, sure... I was just trying to avoid extra dependency trees where possible.
> Apparently it is not possible here. :)
>
> So that should be #include <public/xen.h> (which includes arch-*.h which
> defines xen_regs). It looks like we may want to move ia64's #define to
> arch-ia64.h ...
Could you please include asm/regs.h or public/xen.h wherever you want
to include keyhandler.h? Thanks.
christian
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-24 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 22:01 [patch] final header fixes Hollis Blanchard
2005-03-24 8:54 ` Keir Fraser
2005-03-24 14:47 ` Hollis Blanchard
2005-03-24 20:40 ` Dan Magenheimer
2005-03-24 21:03 ` Hollis Blanchard
2005-03-24 21:24 ` Christian Limpach [this message]
2005-03-25 16:22 ` Hollis Blanchard
2005-03-26 2:15 ` Christian Limpach
-- strict thread matches above, loose matches on Subject: below --
2005-03-24 21:17 Magenheimer, Dan (HP Labs Fort Collins)
2005-03-25 16:57 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d8eece2050324132438c4ca3b@mail.gmail.com \
--to=christian.limpach@gmail.com \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=dan.magenheimer@hp.com \
--cc=hollisb@us.ibm.com \
--cc=xen-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.