Re: [patch] pagetable cleanups

[Christian Limpach <christian.limpach@gmail.com>]

On 4/12/05, Gerd Knorr <kraxel@bytesex.org> wrote:
> Index: xen/arch/x86/shadow.c
> ===================================================================
> --- xen.orig/arch/x86/shadow.c  2005-04-12 17:01:41.000000000 +0200
> +++ xen/arch/x86/shadow.c       2005-04-12 17:33:01.000000000 +0200
> @@ -333,9 +333,8 @@ free_shadow_hl2_table(struct domain *d,
> 
>     for ( i = 0; i < limit; i++ )
>     {
> -        unsigned long hl2e = l1_pgentry_val(hl2[i]);
> -        if ( hl2e & _PAGE_PRESENT )
> -            put_page(pfn_to_page(hl2e >> PAGE_SHIFT));
> +        if ( l1e_get_flags(*hl2) & _PAGE_PRESENT )
> +            put_page(pfn_to_page(l1e_get_pfn(*hl2)));
>     }
> 
>     unmap_domain_mem(hl2);

This hunk seems incorrect, you need to use hl2[i] instead of *hl2.
We need to be careful not to introduce bugs when making cleanups like
this one...  It would be good if a few more people looked through the
patch before we commit it, thanks!

    christian