From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Limpach <christian.limpach@gmail.com>
Subject: Re: [PATCH] x86-64-phys-ma.patch
Date: Thu, 12 May 2005 23:04:42 +0100
Message-ID: <3d8eece20505121504ff23632@mail.gmail.com>
References: <20050512210714.GA29374@intel.com>
	<3d8eece205051214305076efc5@mail.gmail.com>
	<4283D10A.5080007@intel.com>
Reply-To: Christian.Limpach@cl.cam.ac.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4283D10A.5080007@intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Arun Sharma <arun.sharma@intel.com>
Cc: Ian Pratt <Ian.Pratt@cl.cam.ac.uk>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 5/12/05, Arun Sharma <arun.sharma@intel.com> wrote:
> Christian Limpach wrote:
> > On 5/12/05, Arun Sharma <arun.sharma@intel.com> wrote:
> >
> >>phys is machine physical already. So we shouldn't try to convert guest =
physical to machine physical.
> >
> >
> > Are you sure that the test a few lines further down shouldn't use (a
> > to be defined -- see i386) pte_val_ma to compare the currently
> > installed pte with the to-be-installed one?  You might be comparing
> > random values otherwise...
> >
>=20
> Sounds reasonable. I tested that this incremental patch doesn't cause
> any new regressions.

Thanks -- checked in.

     christian