From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Limpach Subject: Re: [PATCH] make domu_debug run-time option + fix int3 handling for MP Date: Mon, 16 May 2005 22:55:49 +0100 Message-ID: <3d8eece20505161455119d8dc2@mail.gmail.com> References: Reply-To: Christian.Limpach@cl.cam.ac.uk Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kip Macy Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 5/16/05, Kip Macy wrote: > I'm not entirely thrilled with the interfaces used to get the domu_debug = option > into xen, but adding yet another argument xc_linux_build and/or adding a > separate handler for domu_debug didn't seem that clean either. The debug = support > doesn't seem like something Ron would use, so I didn't update the Plan 9 > builder. Looks allright -- except that the debugger.h changes break the non-domu_debug usages. Even if you fix that, I'm not sure we want debugger_trap_entry to be domu_debug only. Could you please explain what the intent is and resend as separate patches? Maybe a debug_trap_entry wrapper which tests the DOMF_debug flag and either calls the domu_debug function or the other debugger function would be better? Please also leave the #if/#elif construct for easy switching between the different debugger stubs... christian