From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Limpach <christian.limpach@gmail.com>
Subject: Re: [PATCH] Fix TypeError when starting VMX domains
Date: Tue, 9 Aug 2005 12:00:40 +0100
Message-ID: <3d8eece20508090400634ddb30@mail.gmail.com>
References: <42F7DEDA.4000400@intel.com>
Reply-To: Christian.Limpach@cl.cam.ac.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <42F7DEDA.4000400@intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Arun Sharma <arun.sharma@intel.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 8/8/05, Arun Sharma <arun.sharma@intel.com> wrote:
>=20
> The attached patch fixes this traceback:

When does this happen?  It seems that the fix will only hide the real
cause of the failure and I'd rather fix the underlying bug.  It's odd
that we have initialized the store_channel but not figured out what
the store_mfn is.

    christian

> Traceback (most recent call last):
>   File "/usr/lib/python/xen/xend/XendDomainInfo.py", line 510, in constru=
ct
>     self.construct_image()
>   File "/usr/lib/python/xen/xend/XendDomainInfo.py", line 574, in
> construct_image
>     self.store_channel)
>   File "/usr/lib/python/xen/xend/xenstore/xsobj.py", line 310, in
> introduceDomain
>     log.info("DBMap>introduceDomain> %d %d %s %s" %(dom, page, evtchn,
> path))
> TypeError: int argument required
>=20
> --- a/tools/python/xen/xend/XendDomainInfo.py   Mon Aug  8 20:22:16 2005
> +++ b/tools/python/xen/xend/XendDomainInfo.py   Mon Aug  8 15:00:19 2005
> @@ -239,7 +239,7 @@
>=20
>          self.channel =3D None
>          self.store_channel =3D None
> -        self.store_mfn =3D None
> +        self.store_mfn =3D 0
>          self.controllers =3D {}
>=20
>=20
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>