From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Limpach <christian.limpach@gmail.com>
Subject: Re: [PATCH] Xenstore testsuite robustness: save output
	rather than rerun on failure.
Date: Tue, 23 Aug 2005 20:59:17 +0100
Message-ID: <3d8eece2050823125941faeb0@mail.gmail.com>
References: <1124608205.27838.9.camel@localhost.localdomain>
Reply-To: Christian.Limpach@cl.cam.ac.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1124608205.27838.9.camel@localhost.localdomain>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Xen Mailing List <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Thanks!

On 8/21/05, Rusty Russell <rusty@rustcorp.com.au> wrote:
> "make check" reruns a test which fails with more verbosity.  If the test
> fails intermittently, that doesn't work well: save the output and simply
> dump it if the test fails.
>=20
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>=20
> # HG changeset patch
> # User Rusty Russell <rusty@rustcorp.com.au>
> # Node ID 07b986fec159c8bd18f7f109ca78c5b1250ee07c
> # Parent  68ace2715cbc988c27c494a44a3154dbfcf83d0e
> Rather than re-run on failure, record and replay (needed for occasional f=
ailures)
>=20
> diff -r 68ace2715cbc -r 07b986fec159 tools/xenstore/testsuite/test.sh
> --- a/tools/xenstore/testsuite/test.sh  Sat Aug 20 05:53:26 2005
> +++ b/tools/xenstore/testsuite/test.sh  Sun Aug 21 06:29:47 2005
> @@ -52,11 +52,10 @@
>     case `basename $f` in $MATCH) RUN=3D1;; esac
>     [ -n "$RUN" ] || continue
>=20
> -    if run_test $f > /dev/null; then
> +    if run_test $f -x >/tmp/out; then
>        echo -n .
>     else
> -       echo Test $f failed, running verbosely...
> -       run_test $f -x || true
> +       cat /tmp/out
>        # That will have filled the screen, repeat message.
>        echo Test $f failed
>        exit 1
>=20
> --
> A bad analogy is like a leaky screwdriver -- Richard Braakman
>=20
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>