All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Limpach <christian.limpach@gmail.com>
To: "Ling, Xiaofeng" <xiaofeng.ling@intel.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] fix the control panel problem for latest tree
Date: Fri, 16 Sep 2005 19:51:17 +0100	[thread overview]
Message-ID: <3d8eece205091611511f17b6e1@mail.gmail.com> (raw)
In-Reply-To: <3ACA40606221794F80A5670F0AF15F84098454E1@pdsmsx403>

Thanks!

On 9/16/05, Ling, Xiaofeng <xiaofeng.ling@intel.com> wrote:
> The new image handling structure break the vmx guest loading, this patch
> fix it.
> 
> Signed-off-by: Xiaofeng Ling <xiaofeng.ling@intel.com>
> 
> diff -r fe916b4a7d74 -r 089ec1b6817c tools/python/xen/xend/image.py
> --- a/tools/python/xen/xend/image.py    Fri Sep 16 02:53:39 2005
> +++ b/tools/python/xen/xend/image.py    Fri Sep 16 06:30:21 2005
> @@ -271,9 +271,10 @@
>     def configure(self, config):
>         ImageHandler.configure(self, config)
>         if not config:
> -            self.memmap, self.dmargs, self.device_model, self.display = self.vm.gatherVm(
> +            self.memmap, dmargs, self.device_model, self.display = self.vm.gatherVm(
>                 ("image/memmap"), ("image/dmargs"), ("image/device-model"),
>                 ("image/display"))
> +            self.dmargs = dmargs.split(' ')
>             return
> 
>         self.memmap = sxp.child_value(config, 'memmap')
> @@ -283,10 +284,10 @@
>             raise VmError("vmx: missing device model")
>         self.display = sxp.child_value(config, 'display')
> 
> -        self.storeVm(("image/memmap", self.memmap),
> -                     ("image/dmargs", self.dmargs),
> -                     ("image/device-model", self.device_model),
> -                     ("image/display", self.display))
> +        self.vm.storeVm(("image/memmap", self.memmap),
> +                        ("image/dmargs", " ".join(self.dmargs)),
> +                        ("image/device-model", self.device_model),
> +                        ("image/display", self.display))
> 
>     def createImage(self):
>         """Create a VM for the VMX environment.
> @@ -346,7 +347,7 @@
>                 ret.append("%s" % v)
> 
>         # Handle disk/network related options
> -        devices = sxp.children(config, 'device')
> +        devices = sxp.children(self.vm.config, 'device')
>         for device in devices:
>             name = sxp.name(sxp.child0(device))
>             if name == 'vbd':
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
> 
> 
>

  reply	other threads:[~2005-09-16 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-16  9:47 [PATCH] fix the control panel problem for latest tree Ling, Xiaofeng
2005-09-16 18:51 ` Christian Limpach [this message]
2005-09-20  4:53   ` Xiaofeng Ling
2005-09-20  9:44     ` Christian Limpach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d8eece205091611511f17b6e1@mail.gmail.com \
    --to=christian.limpach@gmail.com \
    --cc=Christian.Limpach@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    --cc=xiaofeng.ling@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.