From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Limpach Subject: Re: [PATCH] Fix another race condition in xm destroy Date: Fri, 16 Sep 2005 20:00:39 +0100 Message-ID: <3d8eece20509161200674eff54@mail.gmail.com> References: <432A4D3A.6060300@us.ibm.com> Reply-To: Christian.Limpach@cl.cam.ac.uk Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <432A4D3A.6060300@us.ibm.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 9/16/05, Anthony Liguori wrote: > There's a race condition in xm destroy that gets triggered when > xc_domain_destroy results in a domain disappearing before we invoke the > cleanup routines. Specifically, the saveToDB routines will through a No > such process error. >=20 > Christian, I'd appreciate if you could sanity check this before > committing. I think it's okay because starting the cleanup shouldn't > have any adverse effects. Having another pair of eyes confirm it would > make me feel better though :-) How does it fail for you? I fixed one issue where we were clearing the store event channel and writing that back to the store was failing. I'd prefer to keep doing the cleanup after destroy_domain. christian