From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Limpach Subject: Re: [Xen-tools] [PATCH] Clean up dom_get() usage Date: Fri, 16 Sep 2005 20:22:14 +0100 Message-ID: <3d8eece20509161222782a9051@mail.gmail.com> References: <87irx2xnf3.fsf@us.ibm.com> Reply-To: Christian.Limpach@cl.cam.ac.uk Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <87irx2xnf3.fsf@us.ibm.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Smith Cc: Xen Tools Developers , Xen Developers List-Id: xen-devel@lists.xenproject.org On 9/15/05, Dan Smith wrote: The 1st hunk adds a random empty line, please avoid hunks like that in the future. > This patch adds sanity checks everywhere dom_get() is used. I don't think the 3rd hunk is needed. It would make more sense to have a patch which replaces the magic dom0 domid by a global variable indicating the domid of the domain where xend is running. > In the case of XendDomainInfo.update(), if we get None back from > dom_get(), we destroy ourselves. I believe that this should be the > desired behavior, but arguments to the contrary are welcome. It's possibly a sensible behaviour, but I'd like to move away from code which does stuff as a side effect. We don't want to end up with countless places doing random actions just because they happen to notice a state change first. christian