Re: [PATCH] Prevent xend from starting duplicate domains

[Christian Limpach <christian.limpach@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

On 9/13/05, Dan Smith <danms@us.ibm.com> wrote:
> The attached patch puts a simple check in domain_create() which
> prevents starting a domain if there is already one of the same name in
> the domain list.
> 
> This fixes the problem of getting the following error message from xm
> while creating a domain soon after destroying one with the same name:
> 
>  xen.xend.XendProtocol.XendError: (3, 'No such process')

There is already a check for domains with the same name in
XendDomainInfo.check_name.  We should fix that check instead of adding
another check.  Could you try the attached patch which removes the
check if a domain "is terminated" and thus allows creation of a domain
with the same name?

It's arguable if this should be allowed or not, but if we allow it,
then we need to find the root cause of the error you're seeing...

    christian

[-- Attachment #2: fix-name-check.patch --]
[-- Type: application/octet-stream, Size: 474 bytes --]

diff -r 4490e39fc322 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py	Fri Sep 16 19:11:39 2005
+++ b/tools/python/xen/xend/XendDomainInfo.py	Fri Sep 16 20:40:23 2005
@@ -635,8 +635,6 @@
         # my domain id.
         if not dominfo:
             return
-        if dominfo.is_terminated():
-            return
         if not self.domid or (dominfo.domid != self.domid):
             raise VmError('vm name clash: ' + name)
         

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel