From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Limpach <christian.limpach@gmail.com>
Subject: Re: [Xen-tools] Re: [PATCH] Make xend reject duplicates
	and rename zombies
Date: Fri, 16 Sep 2005 20:52:05 +0100
Message-ID: <3d8eece205091612523cf7b900@mail.gmail.com>
References: <87br2uz5yj.fsf@us.ibm.com> <4329C366.2070006@us.ibm.com>
Reply-To: Christian.Limpach@cl.cam.ac.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4329C366.2070006@us.ibm.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Xen Tools Developers <xen-tools@lists.xensource.com>, Dan Smith <danms@us.ibm.com>, Xen Developers <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 9/15/05, Anthony Liguori <aliguori@us.ibm.com> wrote:
> I think this is not the right solution to the problem at hand.  The
> problem stems from the fact that xm destroy is just a call to
> xc_domain_destroy which is really just a request to the hypervisor to
> destroy the domain.

Indeed.

> Therefore, there is a race condition if you assume that the domain is
> dead after xm destroy returns.  This patch renames the domain name which
> prevents a name class but does not solve the general problem.  Consider,
> for instance, if a domain is using a block device and you do an xm
> destroy.  It is not safe to create a new domain with that same block
> device until you know that the previously mentioned domain is gone.

I think renaming would make sense if a domain is crashed.  You might
want to keep the domain around to attach a debugger to it but at the
same time restart a fresh copy as soon as possible.

> This patch would allow:
> xm destroy xmexample1 && xm create /etc/xen/xmexample1
>=20
> I think the right solution is to make xm destroy not return until the
> domain has actually gone away and add a flag to xm destroy to return
> immediately if that behavior is ever desired.

Sounds good.

> I'll work up a patch tonight after class.

Thanks!

     christian