From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73895C0015E for ; Tue, 1 Aug 2023 09:48:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 106BC86BAF; Tue, 1 Aug 2023 11:48:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="kYFK9Lv2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6B1A986BB0; Tue, 1 Aug 2023 11:48:03 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F156586B01 for ; Tue, 1 Aug 2023 11:48:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=devarsht@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3719lwlF003740; Tue, 1 Aug 2023 04:47:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690883278; bh=5xV4NolGqK9Kj3eRNiALlixcyZokcwWGJ/LaIjVtKhk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=kYFK9Lv2h00biFwyJy++WaABs9WgqNBNk86fh4yYo6DYqc9/IOoo/iKxv/hRcXmH3 vY+QJ/FZmFkJd0cW8ZbQcgKq2rJs3YfwDXfjjs1FHgpP1tGD2fjiWBpda13nQoLMxG i/ghFZtwmvEsJMlFuNPEEbMcB5Tb9dLPluZ7n/lM= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3719lwJG130112 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Aug 2023 04:47:58 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 1 Aug 2023 04:47:58 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 1 Aug 2023 04:47:58 -0500 Received: from [172.24.227.6] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3719luAh008877; Tue, 1 Aug 2023 04:47:57 -0500 Message-ID: <3da318a2-a175-3819-2fbb-32f0ff690217@ti.com> Date: Tue, 1 Aug 2023 15:17:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] drivers: video: tidss: tidss_drv: Change remove method Content-Language: en-US To: "Jain, Nikhil" , "u-boot@lists.denx.de" CC: "trini@konsulko.com" , "Raghavendra, Vignesh" , "Nori, Sekhar" References: <20230727063126.53347-1-n-jain1@ti.com> <20230727063126.53347-2-n-jain1@ti.com> From: Devarsh Thakkar In-Reply-To: <20230727063126.53347-2-n-jain1@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 27/07/23 12:01, Jain, Nikhil wrote: > Change remove method of DSS video driver to disable video port instead > of performing a soft reset, as soft reset takes longer duration. Video > port is disabled by setting enable bit of video port to 0. > > Signed-off-by: Nikhil M Jain Reviewed-by: Devarsh Thakkar > --- > drivers/video/tidss/tidss_drv.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/video/tidss/tidss_drv.c b/drivers/video/tidss/tidss_drv.c > index 078e3e82e3..623bf4cf31 100644 > --- a/drivers/video/tidss/tidss_drv.c > +++ b/drivers/video/tidss/tidss_drv.c > @@ -901,19 +901,9 @@ static int tidss_drv_probe(struct udevice *dev) > > static int tidss_drv_remove(struct udevice *dev) > { > - u32 val; > - int ret; > struct tidss_drv_priv *priv = dev_get_priv(dev); > > - priv->base_common = dev_remap_addr_index(dev, 0); > - REG_FLD_MOD(priv, DSS_SYSCONFIG, 1, 1, 1); > - /* Wait for reset to complete */ > - ret = readl_poll_timeout(priv->base_common + DSS_SYSSTATUS, > - val, val & 1, 5000); > - if (ret) { > - dev_warn(priv->dev, "failed to reset priv\n"); > - return ret; > - } > + VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0); > return 0; > } >