diff for duplicates of <3db1be098d362d554ebcd31ced83eefc5134aa8f.camel@mediatek.com> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..09ac635 --- /dev/null +++ b/N1/2.bin @@ -0,0 +1,82 @@ +<html><body><p> +<pre> +On Wed, 2024-10-09 at 08:41 -0700, Guillaume Ranquet wrote: +>    +> External email : Please do not click links or open attachments until +> you have verified the sender or the content. +>  On Fri, 27 Sep 2024 11:03, Liankun Yang <liankun.yang@mediatek.com> +> wrote: +> >If the len is 0, kernel crash will occur when performing operations. +> >Add the len check conditions to prevent kernel crash. +> > +> >Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort +> driver") +> >Signed-off-by: Liankun Yang <liankun.yang@mediatek.com> +> >--- +> >Changes in V2: +> >- Fix the commit title. +> >- Remove blank line between the Fixes and Signe-off-by. +> >- Modify the judgment writing method. +> >Per suggestion from the previous thread: +> > +> https://patchwork.kernel.org/project/linux-mediatek/patch/20240925084116.28848-1-liankun.yang@mediatek.com/ +> >--- +> > drivers/gpu/drm/mediatek/mtk_dp.c | 2 +- +> > 1 file changed, 1 insertion(+), 1 deletion(-) +> > +> >diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c +> b/drivers/gpu/drm/mediatek/mtk_dp.c +> >index d8796a904eca..9ecdf62398ee 100644 +> >--- a/drivers/gpu/drm/mediatek/mtk_dp.c +> >+++ b/drivers/gpu/drm/mediatek/mtk_dp.c +> >@@ -1082,7 +1082,7 @@ static void mtk_dp_get_calibration_data(struct +> mtk_dp *mtk_dp) +> > buf = (u32 *)nvmem_cell_read(cell, &len); +> > nvmem_cell_put(cell); +> > +> >-if (IS_ERR(buf) || ((len / sizeof(u32)) != 4)) { +> >+if (IS_ERR(buf) || !len || ((len / sizeof(u32)) != 4)) { +> > dev_warn(dev, "Failed to read nvmem_cell_read\n"); +>  +> Hello Liankun, +> Would you be able to describe the crash with more details? +>  +> I'm afraid I don't understand the fix? +>  +> if len is 0, dividing 0 by sizeof(u32) is 0 and thus != 4 +> So to me, checking for len != 0 is redundant? +>  +> Thx, +> Guillaume. + +Hello Guillaume, + +Thank you for your correction. + +The check for len != 0 is redundant. + +I did not review this patch carefully, and will review it again next +time. + +Thx, +Liankun. + +> > +> > if (!IS_ERR(buf)) +> >-- +> >2.45.2 + +</pre> +</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ******************** +The information contained in this e-mail message (including any +attachments) may be confidential, proprietary, privileged, or otherwise +exempt from disclosure under applicable laws. It is intended to be +conveyed only to the designated recipient(s). Any use, dissemination, +distribution, printing, retaining or copying of this e-mail (including its +attachments) by unintended recipient(s) is strictly prohibited and may +be unlawful. If you are not an intended recipient of this e-mail, or believe +that you have received this e-mail in error, please notify the sender +immediately (by replying to this e-mail), delete any and all copies of +this e-mail (including any attachments) from your system, and do not +disclose the content of this e-mail to any other person. Thank you! +</pre><!--}--> diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..da1f671 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: text/html; + charset="utf-8" +Content-Transfer-Encoding: base64 diff --git a/a/content_digest b/N1/content_digest index 70da954..3c74d77 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -21,7 +21,7 @@ linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org> linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> " Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com>\0" - "\00:1\0" + "\01:1\0" "b\0" "On Wed, 2024-10-09 at 08:41 -0700, Guillaume Ranquet wrote:\n" "> \t \n" @@ -88,5 +88,89 @@ "> > if (!IS_ERR(buf))\n" "> >--\n" > >2.45.2 + "\01:2\0" + "b\0" + "<html><body><p>\r\n" + "<pre>\r\n" + "On Wed, 2024-10-09 at 08:41 -0700, Guillaume Ranquet wrote:\r\n" + ">   \r\n" + "> External email : Please do not click links or open attachments until\r\n" + "> you have verified the sender or the content.\r\n" + ">  On Fri, 27 Sep 2024 11:03, Liankun Yang <liankun.yang@mediatek.com>\r\n" + "> wrote:\r\n" + "> >If the len is 0, kernel crash will occur when performing operations.\r\n" + "> >Add the len check conditions to prevent kernel crash.\r\n" + "> >\r\n" + "> >Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort\r\n" + "> driver")\r\n" + "> >Signed-off-by: Liankun Yang <liankun.yang@mediatek.com>\r\n" + "> >---\r\n" + "> >Changes in V2:\r\n" + "> >- Fix the commit title.\r\n" + "> >- Remove blank line between the Fixes and Signe-off-by.\r\n" + "> >- Modify the judgment writing method.\r\n" + "> >Per suggestion from the previous thread:\r\n" + "> >\r\n" + "> https://patchwork.kernel.org/project/linux-mediatek/patch/20240925084116.28848-1-liankun.yang@mediatek.com/\r\n" + "> >---\r\n" + "> > drivers/gpu/drm/mediatek/mtk_dp.c | 2 +-\r\n" + "> > 1 file changed, 1 insertion(+), 1 deletion(-)\r\n" + "> >\r\n" + "> >diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c\r\n" + "> b/drivers/gpu/drm/mediatek/mtk_dp.c\r\n" + "> >index d8796a904eca..9ecdf62398ee 100644\r\n" + "> >--- a/drivers/gpu/drm/mediatek/mtk_dp.c\r\n" + "> >+++ b/drivers/gpu/drm/mediatek/mtk_dp.c\r\n" + "> >@@ -1082,7 +1082,7 @@ static void mtk_dp_get_calibration_data(struct\r\n" + "> mtk_dp *mtk_dp)\r\n" + "> > buf = (u32 *)nvmem_cell_read(cell, &len);\r\n" + "> > nvmem_cell_put(cell);\r\n" + "> >\r\n" + "> >-if (IS_ERR(buf) || ((len / sizeof(u32)) != 4)) {\r\n" + "> >+if (IS_ERR(buf) || !len || ((len / sizeof(u32)) != 4)) {\r\n" + "> > dev_warn(dev, "Failed to read nvmem_cell_read\n");\r\n" + "> \r\n" + "> Hello Liankun,\r\n" + "> Would you be able to describe the crash with more details?\r\n" + "> \r\n" + "> I'm afraid I don't understand the fix?\r\n" + "> \r\n" + "> if len is 0, dividing 0 by sizeof(u32) is 0 and thus != 4\r\n" + "> So to me, checking for len != 0 is redundant?\r\n" + "> \r\n" + "> Thx,\r\n" + "> Guillaume.\r\n" + "\r\n" + "Hello Guillaume,\r\n" + "\r\n" + "Thank you for your correction.\r\n" + "\r\n" + "The check for len != 0 is redundant.\r\n" + "\r\n" + "I did not review this patch carefully, and will review it again next\r\n" + "time.\r\n" + "\r\n" + "Thx,\r\n" + "Liankun.\r\n" + "\r\n" + "> >\r\n" + "> > if (!IS_ERR(buf))\r\n" + "> >--\r\n" + "> >2.45.2\r\n" + "\r\n" + "</pre>\r\n" + "</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************\r\n" + "The information contained in this e-mail message (including any \r\n" + "attachments) may be confidential, proprietary, privileged, or otherwise\r\n" + "exempt from disclosure under applicable laws. It is intended to be \r\n" + "conveyed only to the designated recipient(s). Any use, dissemination, \r\n" + "distribution, printing, retaining or copying of this e-mail (including its \r\n" + "attachments) by unintended recipient(s) is strictly prohibited and may \r\n" + "be unlawful. If you are not an intended recipient of this e-mail, or believe \r\n" + "that you have received this e-mail in error, please notify the sender \r\n" + "immediately (by replying to this e-mail), delete any and all copies of \r\n" + "this e-mail (including any attachments) from your system, and do not\r\n" + "disclose the content of this e-mail to any other person. Thank you!\r\n" + </pre><!--}--> -9c5850338c16b0efe5934ca46602d6f8be371637441a750111ec9c7edd7ded95 +d6b341edee6fb6372d0cdcc5a9eb6aa8b8b5e2d3de9f025cb630b8bb04ebbb48
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.