From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933276AbcLNUUy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Dec 2016 15:20:54 -0500
Received: from mail-pg0-f52.google.com ([74.125.83.52]:35749 "EHLO
        mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933073AbcLNUUw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Dec 2016 15:20:52 -0500
Subject: Re: CVE-2016-7097 causes acl leak
To: Greg KH <gregkh@linuxfoundation.org>
References: <bb7177d2-08dc-d75c-9012-26e3b2888461@android.com>
 <CAM_iQpX59wQ+ngjLG3WhBXHG5hiHUFDU9SDmz9V2HCGDTRTMXw@mail.gmail.com>
 <3a180415-2f02-c9c0-e1e6-519b5d3115b7@android.com>
 <CAM_iQpUp2rFhsu+VZ_FN5RJyTA69mEbqvFju2+0O2VjeLKj5jg@mail.gmail.com>
 <5c0398cb-9ef2-42f3-0c46-e2e65fe92da9@android.com>
 <20161214000005.GA29963@kroah.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, aneesh.kumar@linux.vnet.ibm.com,
        Jan Kara <jack@suse.cz>
From: Mark Salyzyn <salyzyn@android.com>
Message-ID: <3db72683-e810-38f8-87c8-dc7fa6a50aa6@android.com>
Date: Wed, 14 Dec 2016 12:20:50 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161214000005.GA29963@kroah.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/13/2016 04:00 PM, Greg KH wrote:
> On Tue, Dec 13, 2016 at 03:42:58PM -0800, Mark Salyzyn wrote:
>> On 12/12/2016 10:26 PM, Cong Wang wrote:
>>> On Mon, Dec 12, 2016 at 4:26 PM, Mark Salyzyn <salyzyn@android.com> wrote:
>>>> The leaks were introduced in 9p, gfs2, jfs and xfs drivers only.
>>> Only the 9p case is obvious to me:
>>>
>>> diff --git a/fs/9p/acl.c b/fs/9p/acl.c
>>> index b3c2cc7..082d227 100644
>>> --- a/fs/9p/acl.c
>>> +++ b/fs/9p/acl.c
>>> @@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const struct
>>> xattr_handler *handler,
>>>           case ACL_TYPE_ACCESS:
>>>                   if (acl) {
>>>                           struct iattr iattr;
>>> +                       struct posix_acl *old_acl = acl;
>>>
>>>                           retval = posix_acl_update_mode(inode,
>>> &iattr.ia_mode, &acl);
>>>                           if (retval)
>>> @@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const struct
>>> xattr_handler *handler,
>>>                                    * by the mode bits. So don't
>>>                                    * update ACL.
>>>                                    */
>>> +                               posix_acl_release(old_acl);
>>>                                   value = NULL;
>>>                                   size = 0;
>>>                           }
>>>
>>>
>>> The rest are anti-pattern (modifying parameters on stack via address)
>>> but look correct.
>> Greg KH: Beware that this similar fix needs to be applied to _backports_ to
>> stable kernel trees on other filesystem driver that have the same pattern
>> (with local posix_acl_release(acl) calls). I have found that depending on
>> vintage these would include this driver 9p, and possibly gfs2, jfs and xfs.
>> Be aware.
> I don't understand what you mean here.  What needs to be "backported" to
> the stable tree?  What commit in Linus's tree do I pick?  If not a
> commit there, where is it?
>
> totally confused,
>
> greg k-h

In 3.10-stable if you took the original CVE-2016-7097 fix it could break 
four file system drivers, the fix for each would 'look like' this one 
fix for the 9p driver.

-- Mark