From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A852C35274 for ; Thu, 17 Sep 2020 14:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40F93206DB for ; Thu, 17 Sep 2020 14:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbgIQOWD (ORCPT ); Thu, 17 Sep 2020 10:22:03 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:13242 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727392AbgIQOMH (ORCPT ); Thu, 17 Sep 2020 10:12:07 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DD669CF5D799BBBDFFC7; Thu, 17 Sep 2020 22:11:59 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Thu, 17 Sep 2020 22:11:57 +0800 Subject: Re: [bug report] RDMA/hns: Avoid unncessary initialization To: Dan Carpenter CC: References: <20200916143940.GA766708@mwanda> From: oulijun Message-ID: <3dbe4539-2c7a-1ef2-3923-0f18567d4265@huawei.com> Date: Thu, 17 Sep 2020 22:11:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20200916143940.GA766708@mwanda> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Thanks. I will fix it. ÔÚ 2020/9/16 22:39, Dan Carpenter дµÀ: > Hello Lijun Ou, > > The patch a2f3d4479fe9: "RDMA/hns: Avoid unncessary initialization" > from Sep 8, 2020, leads to the following static checker warning: > > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:282 hns_roce_v1_post_send() > error: uninitialized symbol 'ps_opcode'. > > drivers/infiniband/hw/hns/hns_roce_hw_v1.c > 256 switch (wr->opcode) { > 257 case IB_WR_RDMA_READ: > 258 ps_opcode = HNS_ROCE_WQE_OPCODE_RDMA_READ; > 259 set_raddr_seg(wqe, rdma_wr(wr)->remote_addr, > 260 rdma_wr(wr)->rkey); > 261 break; > 262 case IB_WR_RDMA_WRITE: > 263 case IB_WR_RDMA_WRITE_WITH_IMM: > 264 ps_opcode = HNS_ROCE_WQE_OPCODE_RDMA_WRITE; > 265 set_raddr_seg(wqe, rdma_wr(wr)->remote_addr, > 266 rdma_wr(wr)->rkey); > 267 break; > 268 case IB_WR_SEND: > 269 case IB_WR_SEND_WITH_INV: > 270 case IB_WR_SEND_WITH_IMM: > 271 ps_opcode = HNS_ROCE_WQE_OPCODE_SEND; > 272 break; > 273 case IB_WR_LOCAL_INV: > ^^^^^^^^^^^^^^^^^^^^ > "ps_opcode" is not initialized for this case statement. > > 274 break; > 275 case IB_WR_ATOMIC_CMP_AND_SWP: > 276 case IB_WR_ATOMIC_FETCH_AND_ADD: > 277 case IB_WR_LSO: > 278 default: > 279 ps_opcode = HNS_ROCE_WQE_OPCODE_MASK; > 280 break; > 281 } > 282 ctrl->flag |= cpu_to_le32(ps_opcode); > ^^^^^^^^^ > Uninitialized. > > 283 wqe += sizeof(struct hns_roce_wqe_raddr_seg); > 284 > 285 dseg = wqe; > > regards, > dan carpenter > . >