From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2D0F277CA5 for ; Fri, 7 Aug 2026 01:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786065471; cv=none; b=rrjfqi9fzsFYeINF3fp7iYGGkt9BiK4cgp/MjpJi1ilRIlPvnH4fxYeLZ3lfLSbFcukpfJ0yG6LhhwZcHbWZxobrhpM/VZ5kiV1yRamGmfM01iYw2MPAJ4Np+qCqj9D+Q+knLmV4VEfujsuz96JKRg7uRy8mm2Ghu2OvbohN+HM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786065471; c=relaxed/simple; bh=wSdXLXPR7akUTbbGU1AYxnDsAhBsSPrvPGF1eR8XBIY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=VcFZJk5WQDMkbkfver0f1T5sZfiBst4UB73UiWT7UszS18/oUF+f0R2BFt0wVE+PlCFCUA2B015dD/GoOvqgRqMojY7+CnP9RhBpZQ2AQ62mgXPOWsl0NdA5VGZZLHgiKAPxLDClvaGFPlP4FyDdsIwtmd2brZP/T9tkDPJ5X6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com Received: from omf17.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F1449A2569; Fri, 7 Aug 2026 01:17:47 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA id 9D52D18; Fri, 7 Aug 2026 01:17:45 +0000 (UTC) Message-ID: <3dccf110a71f2459dcbc44684b6ebbbff16986e4.camel@perches.com> Subject: Re: [PATCH] checkpatch: add NOKPROBE_SYMBOL to the whitelist of lines that can occur immediately after functions From: Joe Perches To: Paul Walmsley , apw@canonical.com, linux-kernel@vger.kernel.org, Andrew Morton Cc: Nam Cao , Jisheng Zhang Date: Thu, 06 Aug 2026 18:17:44 -0700 In-Reply-To: <130be7db-6098-86a4-60fe-0c1a5d9e30ba@kernel.org> References: <130be7db-6098-86a4-60fe-0c1a5d9e30ba@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: kf4757qzwf6814j1h8iez359zcmhtenh X-Rspamd-Server: rspamout06 X-Rspamd-Queue-Id: 9D52D18 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19jFCHJaWgm1vXms2QPsNqpqM88xVAqvx0= X-HE-Tag: 1786065465-412363 X-HE-Meta: U2FsdGVkX191bwz19yLwzSqZPJrfQk+PDZdjj9t13MCU4aA1ZPQXtxM/mZbOBc4Ac8S/3uGVuK4BdqSxDL+cNHl1BC3jujWea96SvYF7R9KgfO1JgYbpA+Dt1mPVuKOmkyubS5bf2ghYe4ZzS2r/nltc5lbd0+3zo/ATqtlQg5lHTN0F9+MWGSSg9Otv5lO7FiSe8Yjk0OIR9zYqvbXVcjMrQOU7dS6/rlCrX2kbMdLxENF35Wz5zbzr3ifS6jtGZXixulzwIopXYZBS7hBA7T8eXwDwCuniuYzY7svYSCimVSdVdZFM7U7iLGOpuxyY5dhe/3U2YJjrepH4E2RSwtnacXrdCiCuQZAd2SMSwcPjB8qfKcaoxT6tLz9YjnYUi4phCHrvL3lJ/ZJOP087Lg== On Thu, 2026-08-06 at 19:00 -0600, Paul Walmsley wrote: > It's customary for NOKPROBE_SYMBOL() macro usage to appear immedately immediate typo. Andrew can you please fix it when applying? Anyway, this is completely sensible, thanks. Acked-by: Joe Perches > after a function's final closing brace, but checkpatch doesn't know > that yet. As a result, checkpatch --strict incorrectly flags this > common kernel pattern, e.g., >=20 > CHECK: Please use a blank line after function/struct/union/enum declarati= ons > 33: FILE: arch/riscv/kernel/traps.c:273: > } > +NOKPROBE_SYMBOL(probe_single_step_handler); >=20 > Fix by adding NOKPROBE_SYMBOL to the whitelist of patterns that are > cleared to appear immediately after functions. >=20 > Cc: Nam Cao <[namcao@linutronix.de](mailto:namcao@linutronix.de)> > Cc: Jisheng Zhang <[jszhang@kernel.org](mailto:jszhang@kernel.org)> > Signed-off-by: Paul Walmsley <[pjw@kernel.org](mailto:pjw@kernel.org)> > --- > scripts/checkpatch.pl | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 2b7a42bbdd94..f8a57ed71f34 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -4148,6 +4148,7 @@ sub process { > $line =3D~ /^\+[a-z_]*init/ || > $line =3D~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || > $line =3D~ /^\+\s*DECLARE/ || > + $line =3D~ /^\+\s*NOKPROBE_SYMBOL/ || > $line =3D~ /^\+\s*builtin_[\w_]*driver/ || > $line =3D~ /^\+\s*__setup/)) { > if (CHK("LINE_SPACING", >=20 > ```