From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1E7DC25B4F for ; Mon, 6 May 2024 14:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kqAQm9J0MMwp/qsADJ8HxNjtkGhbT1zQQHRLqPU2adE=; b=LkKbCqycejlBZm 7sCYDLvJZXzd8jS2vVOnH9ZFd2SoSUEiDZW+auFTWGoC7QNRrH5w7i28AzfogtaMAXu3tLpXsNnHa fXmjMc9ieL5f9bXojin+7PnaEQ9cLXQKvEcKIzrkKgrutRcAriq7yA8ypetcfau6J+gRVJ1WrNI4n 8aG4YDKJ+8m9GOkIItxNSjjOmadvccL/6OsQcIsod7gz2BDe4e0N7vafdKqlQLuqOjImCFn8rXwgy bMqMZwWNzKbHyuGMBbTAO43a1AVng0n9RMMUPuMoIHE/H/acthLONli9rVPPo+bykDhG78S1qr+Tz bAGTQbGvWYUd38NqWc5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3zUJ-00000007h81-2NjZ; Mon, 06 May 2024 14:38:43 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3zUF-00000007h6n-2xYw; Mon, 06 May 2024 14:38:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715006316; bh=KGPDfZwI4ubFEcvrrWnuUTNMJQCXV8Ilj2eLN3CMFYk=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=FLCl/YV3TJSICHUDZL5pxebArkcfqWznV0LA/FTCX5sNREJSSLO+gHG07AcCkfvdT 0gmBg4LSzEFFoKzCVkPbvoqQhCn0x4nwpYtW5jUET+ib7no9Lfb8ZBjosbe08r+Z9P u2jBplgHw9tqT8Rv2O6HpGlmrrbRHqt/cYnnBlBtvqCgegZsH+JbqvYhW2icaAS+nh bS3YheixnaWj3WY1SGzkuoR6ZN0VchuaBnY3VWEIXJtP1pCbyPUUWFjNFM37cZsLHl szq8g7lx9zv3fJdwBjJsg7AUyEj9BhB/mWbaoi1r9QUUgcNvnX6FhZSwEszzRVjgpk 3Wa9VzavpqEVw== Received: from [100.93.89.217] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BC0FA3781107; Mon, 6 May 2024 14:38:35 +0000 (UTC) Message-ID: <3dde932a-1b62-4824-a9e0-722f82faaaa6@collabora.com> Date: Mon, 6 May 2024 16:38:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: verisilicon: Fix auxiliary buffers allocation size From: Benjamin Gaignard To: Nicolas Dufresne , ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org, heiko@sntech.de Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20240328093439.18712-1-benjamin.gaignard@collabora.com> <20240328093439.18712-2-benjamin.gaignard@collabora.com> <2a3b897a-71f7-4a94-a13c-1aa8b2d96e78@collabora.com> Content-Language: en-US In-Reply-To: <2a3b897a-71f7-4a94-a13c-1aa8b2d96e78@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240506_073839_904349_221960A7 X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org CkxlIDA1LzA0LzIwMjQgw6AgMTA6MTMsIEJlbmphbWluIEdhaWduYXJkIGEgw6ljcml0wqA6Cj4K PiBMZSAwNC8wNC8yMDI0IMOgIDIwOjAwLCBOaWNvbGFzIER1ZnJlc25lIGEgw6ljcml0wqA6Cj4+ IEhpLAo+Pgo+PiBMZSBqZXVkaSAyOCBtYXJzIDIwMjQgw6AgMTA6MzQgKzAxMDAsIEJlbmphbWlu IEdhaWduYXJkIGEgw6ljcml0wqA6Cj4+PiBVc2UgdjRsMl9hdjFfdGlsZV9pbmZvLT50aWxlX2Nv bHMgdG8ga25vdyB0aGUgbnVtYmVyIG9mIGNvbG9ucwo+Pj4gaW4gdGhlIGZyYW1lLiBUaGlzIG1h ZGUgYXV4aWxpYXJ5IGJ1ZmZlcnMgbWVvcnkgc2l6ZSBjb21wdXRhdGlvbgo+Pj4gbW9yZSBhY2N1 cmF0ZS4KPj4gU2VlbXMgbGlrZSB0aGlzIGlzIHBvdGVudGlhbGx5IGdvaW5nIHRvIGltcGFjdCBz b21lIGNvbmZvcm1hbmNlIAo+PiB0ZXN0cy4gQW55dGhpbmcKPj4gdG8gcmVwb3J0IGZyb20gZmx1 c3RlciByZXN1bHRzID8KPgo+IEZsdXN0ZXJzIEFWMSBzY29yZSBpcyB0aGUgc2FtZS4KPiBNYXli ZSB3ZSBoYXZlIGJlZW4gbHVja3kgd2hlbiBhbGxvY2F0aW5nIG1lbW9yeSB1bnRpbCBub3cuCj4g VGhhdCBzYWlkIHRoZSB0ZXN0IHN0cmVhbSBoYXZlIDggdGlsZSBjb2x1bW5zIHdoaWNoIGlzIHVu dXN1YWwgYnV0IAo+IGFkbWl0dGVkIGJ5IEFWMSBzcGVjaWZpY2F0aW9ucy4KCkdlbnRsZSBwaW5n LApSZWdhcmRzLApCZW5qYW1pbgoKPgo+IEJlbmphbWluCj4KPj4KPj4gTmljb2xhcwo+Pgo+Pj4g U2lnbmVkLW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJkQGNvbGxh Ym9yYS5jb20+Cj4+PiBGaXhlczogNzI3YTQwMDY4NmEyICgibWVkaWE6IHZlcmlzaWxpY29uOiBB ZGQgUm9ja2NoaXAgQVYxIGRlY29kZXIiKQo+Pj4gLS0tCj4+PiAuLi4vbWVkaWEvcGxhdGZvcm0v dmVyaXNpbGljb24vcm9ja2NoaXBfdnB1OTgxX2h3X2F2MV9kZWMuYyB8IDMgKystCj4+PiDCoCAx IGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Pgo+Pj4gZGlm ZiAtLWdpdCAKPj4+IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92ZXJpc2lsaWNvbi9yb2NrY2hp cF92cHU5ODFfaHdfYXYxX2RlYy5jIAo+Pj4gYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Zlcmlz aWxpY29uL3JvY2tjaGlwX3ZwdTk4MV9od19hdjFfZGVjLmMKPj4+IGluZGV4IGNjNDQ4Mzg1NzQ4 OS4uNjVlOGYyZDA3NDAwIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 ZXJpc2lsaWNvbi9yb2NrY2hpcF92cHU5ODFfaHdfYXYxX2RlYy5jCj4+PiArKysgYi9kcml2ZXJz L21lZGlhL3BsYXRmb3JtL3ZlcmlzaWxpY29uL3JvY2tjaGlwX3ZwdTk4MV9od19hdjFfZGVjLmMK Pj4+IEBAIC0yNTcsNyArMjU3LDggQEAgc3RhdGljIGludCAKPj4+IHJvY2tjaGlwX3ZwdTk4MV9h djFfZGVjX3RpbGVzX3JlYWxsb2NhdGUoc3RydWN0IGhhbnRyb19jdHggKmN0eCkKPj4+IMKgwqDC oMKgwqAgc3RydWN0IGhhbnRyb19kZXYgKnZwdSA9IGN0eC0+ZGV2Owo+Pj4gwqDCoMKgwqDCoCBz dHJ1Y3QgaGFudHJvX2F2MV9kZWNfaHdfY3R4ICphdjFfZGVjID0gJmN0eC0+YXYxX2RlYzsKPj4+ IMKgwqDCoMKgwqAgc3RydWN0IGhhbnRyb19hdjFfZGVjX2N0cmxzICpjdHJscyA9ICZhdjFfZGVj LT5jdHJsczsKPj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IG51bV90aWxlX2NvbHMgPSAxIDw8IAo+ Pj4gY3RybHMtPnRpbGVfZ3JvdXBfZW50cnktPnRpbGVfY29sOwo+Pj4gK8KgwqDCoCBjb25zdCBz dHJ1Y3QgdjRsMl9hdjFfdGlsZV9pbmZvICp0aWxlX2luZm8gPSAKPj4+ICZjdHJscy0+ZnJhbWUt PnRpbGVfaW5mbzsKPj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IG51bV90aWxlX2NvbHMgPSB0aWxl X2luZm8tPnRpbGVfY29sczsKPj4+IMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGhlaWdodCA9IEFM SUdOKGN0cmxzLT5mcmFtZS0+ZnJhbWVfaGVpZ2h0X21pbnVzXzEgCj4+PiArIDEsIDY0KTsKPj4+ IMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGhlaWdodF9pbl9zYiA9IGhlaWdodCAvIDY0Owo+Pj4g wqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgc3RyaXBlX251bSA9ICgoaGVpZ2h0ICsgOCkgKyA2Mykg LyA2NDsKPj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A943CC10F16 for ; Mon, 6 May 2024 14:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PZjjwZyevlAdLAKGP2I12fr/QJyBEk+xTya6dJU9pDY=; b=m4h1mEAC+umwvw zaQVh3Q+tJbetBL7f5d46/JdDmWOTDtyQdDtJ9aPFhF5H6QXtGpWwSxVcLDnTeLjCodMHSKIqUjoW oSkEQGa/SwjrlJ/90pAeapZELo4EeTvQJAIlIIZkMp2GLmzMcCLtO5ykRkYtk2wy783bNsY6exCCo jmIHhI1lk+k59+d7f+Gnjlu3pCZWFPBcG3VZ6hpe9ERtvcNfA2tCW+8Cs0lkatg4Wf28PEnD9IPpB bo+/FVI08D6cszbcDcnnp9xwV0Qgwg22EnVse041L4o4Eui+7FF6y0Nr0dNeqKKvX9Mo+ZOBvA6ht emS4qH0Rvd+1Lb71JZ7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3zUI-00000007h7f-3SgE; Mon, 06 May 2024 14:38:42 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3zUF-00000007h6n-2xYw; Mon, 06 May 2024 14:38:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715006316; bh=KGPDfZwI4ubFEcvrrWnuUTNMJQCXV8Ilj2eLN3CMFYk=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=FLCl/YV3TJSICHUDZL5pxebArkcfqWznV0LA/FTCX5sNREJSSLO+gHG07AcCkfvdT 0gmBg4LSzEFFoKzCVkPbvoqQhCn0x4nwpYtW5jUET+ib7no9Lfb8ZBjosbe08r+Z9P u2jBplgHw9tqT8Rv2O6HpGlmrrbRHqt/cYnnBlBtvqCgegZsH+JbqvYhW2icaAS+nh bS3YheixnaWj3WY1SGzkuoR6ZN0VchuaBnY3VWEIXJtP1pCbyPUUWFjNFM37cZsLHl szq8g7lx9zv3fJdwBjJsg7AUyEj9BhB/mWbaoi1r9QUUgcNvnX6FhZSwEszzRVjgpk 3Wa9VzavpqEVw== Received: from [100.93.89.217] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BC0FA3781107; Mon, 6 May 2024 14:38:35 +0000 (UTC) Message-ID: <3dde932a-1b62-4824-a9e0-722f82faaaa6@collabora.com> Date: Mon, 6 May 2024 16:38:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: verisilicon: Fix auxiliary buffers allocation size From: Benjamin Gaignard To: Nicolas Dufresne , ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org, heiko@sntech.de Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20240328093439.18712-1-benjamin.gaignard@collabora.com> <20240328093439.18712-2-benjamin.gaignard@collabora.com> <2a3b897a-71f7-4a94-a13c-1aa8b2d96e78@collabora.com> Content-Language: en-US In-Reply-To: <2a3b897a-71f7-4a94-a13c-1aa8b2d96e78@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240506_073839_904349_221960A7 X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CkxlIDA1LzA0LzIwMjQgw6AgMTA6MTMsIEJlbmphbWluIEdhaWduYXJkIGEgw6ljcml0wqA6Cj4K PiBMZSAwNC8wNC8yMDI0IMOgIDIwOjAwLCBOaWNvbGFzIER1ZnJlc25lIGEgw6ljcml0wqA6Cj4+ IEhpLAo+Pgo+PiBMZSBqZXVkaSAyOCBtYXJzIDIwMjQgw6AgMTA6MzQgKzAxMDAsIEJlbmphbWlu IEdhaWduYXJkIGEgw6ljcml0wqA6Cj4+PiBVc2UgdjRsMl9hdjFfdGlsZV9pbmZvLT50aWxlX2Nv bHMgdG8ga25vdyB0aGUgbnVtYmVyIG9mIGNvbG9ucwo+Pj4gaW4gdGhlIGZyYW1lLiBUaGlzIG1h ZGUgYXV4aWxpYXJ5IGJ1ZmZlcnMgbWVvcnkgc2l6ZSBjb21wdXRhdGlvbgo+Pj4gbW9yZSBhY2N1 cmF0ZS4KPj4gU2VlbXMgbGlrZSB0aGlzIGlzIHBvdGVudGlhbGx5IGdvaW5nIHRvIGltcGFjdCBz b21lIGNvbmZvcm1hbmNlIAo+PiB0ZXN0cy4gQW55dGhpbmcKPj4gdG8gcmVwb3J0IGZyb20gZmx1 c3RlciByZXN1bHRzID8KPgo+IEZsdXN0ZXJzIEFWMSBzY29yZSBpcyB0aGUgc2FtZS4KPiBNYXli ZSB3ZSBoYXZlIGJlZW4gbHVja3kgd2hlbiBhbGxvY2F0aW5nIG1lbW9yeSB1bnRpbCBub3cuCj4g VGhhdCBzYWlkIHRoZSB0ZXN0IHN0cmVhbSBoYXZlIDggdGlsZSBjb2x1bW5zIHdoaWNoIGlzIHVu dXN1YWwgYnV0IAo+IGFkbWl0dGVkIGJ5IEFWMSBzcGVjaWZpY2F0aW9ucy4KCkdlbnRsZSBwaW5n LApSZWdhcmRzLApCZW5qYW1pbgoKPgo+IEJlbmphbWluCj4KPj4KPj4gTmljb2xhcwo+Pgo+Pj4g U2lnbmVkLW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJkQGNvbGxh Ym9yYS5jb20+Cj4+PiBGaXhlczogNzI3YTQwMDY4NmEyICgibWVkaWE6IHZlcmlzaWxpY29uOiBB ZGQgUm9ja2NoaXAgQVYxIGRlY29kZXIiKQo+Pj4gLS0tCj4+PiAuLi4vbWVkaWEvcGxhdGZvcm0v dmVyaXNpbGljb24vcm9ja2NoaXBfdnB1OTgxX2h3X2F2MV9kZWMuYyB8IDMgKystCj4+PiDCoCAx IGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Pgo+Pj4gZGlm ZiAtLWdpdCAKPj4+IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92ZXJpc2lsaWNvbi9yb2NrY2hp cF92cHU5ODFfaHdfYXYxX2RlYy5jIAo+Pj4gYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Zlcmlz aWxpY29uL3JvY2tjaGlwX3ZwdTk4MV9od19hdjFfZGVjLmMKPj4+IGluZGV4IGNjNDQ4Mzg1NzQ4 OS4uNjVlOGYyZDA3NDAwIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 ZXJpc2lsaWNvbi9yb2NrY2hpcF92cHU5ODFfaHdfYXYxX2RlYy5jCj4+PiArKysgYi9kcml2ZXJz L21lZGlhL3BsYXRmb3JtL3ZlcmlzaWxpY29uL3JvY2tjaGlwX3ZwdTk4MV9od19hdjFfZGVjLmMK Pj4+IEBAIC0yNTcsNyArMjU3LDggQEAgc3RhdGljIGludCAKPj4+IHJvY2tjaGlwX3ZwdTk4MV9h djFfZGVjX3RpbGVzX3JlYWxsb2NhdGUoc3RydWN0IGhhbnRyb19jdHggKmN0eCkKPj4+IMKgwqDC oMKgwqAgc3RydWN0IGhhbnRyb19kZXYgKnZwdSA9IGN0eC0+ZGV2Owo+Pj4gwqDCoMKgwqDCoCBz dHJ1Y3QgaGFudHJvX2F2MV9kZWNfaHdfY3R4ICphdjFfZGVjID0gJmN0eC0+YXYxX2RlYzsKPj4+ IMKgwqDCoMKgwqAgc3RydWN0IGhhbnRyb19hdjFfZGVjX2N0cmxzICpjdHJscyA9ICZhdjFfZGVj LT5jdHJsczsKPj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IG51bV90aWxlX2NvbHMgPSAxIDw8IAo+ Pj4gY3RybHMtPnRpbGVfZ3JvdXBfZW50cnktPnRpbGVfY29sOwo+Pj4gK8KgwqDCoCBjb25zdCBz dHJ1Y3QgdjRsMl9hdjFfdGlsZV9pbmZvICp0aWxlX2luZm8gPSAKPj4+ICZjdHJscy0+ZnJhbWUt PnRpbGVfaW5mbzsKPj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IG51bV90aWxlX2NvbHMgPSB0aWxl X2luZm8tPnRpbGVfY29sczsKPj4+IMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGhlaWdodCA9IEFM SUdOKGN0cmxzLT5mcmFtZS0+ZnJhbWVfaGVpZ2h0X21pbnVzXzEgCj4+PiArIDEsIDY0KTsKPj4+ IMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGhlaWdodF9pbl9zYiA9IGhlaWdodCAvIDY0Owo+Pj4g wqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgc3RyaXBlX251bSA9ICgoaGVpZ2h0ICsgOCkgKyA2Mykg LyA2NDsKPj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 254B5152E19; Mon, 6 May 2024 14:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715006319; cv=none; b=e/kw+f2x7kZQUUkkvxIfsOnvjndCITSCg5GmU5QEI/ezqVwgvm6IcVDUEFWzjpBeeCrjoG2COhnZ7O31Xl/GAbutWlfxMZCrLPnyfozmCqTKxGk+TzU28MdRUkePrjuh40yvnPnoeW7GH/c4bMrYpXcTLfOCWL/f8z2ENVeQMz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715006319; c=relaxed/simple; bh=KGPDfZwI4ubFEcvrrWnuUTNMJQCXV8Ilj2eLN3CMFYk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=TRjnL7VxohJLzfq+VCQtLiPi/rrPYtrVERfXWFD3xz8Wa70KdyLoS4caPsR3NwESPwFE146389cCe+UeKKQyjp53zlms3448G8eBeRi/acLFShmgzHJSOy+8jtLzatejeidalMGZYz3pXrJvQjtWTes19ZcIssnsM1nyABPigL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=FLCl/YV3; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="FLCl/YV3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715006316; bh=KGPDfZwI4ubFEcvrrWnuUTNMJQCXV8Ilj2eLN3CMFYk=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=FLCl/YV3TJSICHUDZL5pxebArkcfqWznV0LA/FTCX5sNREJSSLO+gHG07AcCkfvdT 0gmBg4LSzEFFoKzCVkPbvoqQhCn0x4nwpYtW5jUET+ib7no9Lfb8ZBjosbe08r+Z9P u2jBplgHw9tqT8Rv2O6HpGlmrrbRHqt/cYnnBlBtvqCgegZsH+JbqvYhW2icaAS+nh bS3YheixnaWj3WY1SGzkuoR6ZN0VchuaBnY3VWEIXJtP1pCbyPUUWFjNFM37cZsLHl szq8g7lx9zv3fJdwBjJsg7AUyEj9BhB/mWbaoi1r9QUUgcNvnX6FhZSwEszzRVjgpk 3Wa9VzavpqEVw== Received: from [100.93.89.217] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BC0FA3781107; Mon, 6 May 2024 14:38:35 +0000 (UTC) Message-ID: <3dde932a-1b62-4824-a9e0-722f82faaaa6@collabora.com> Date: Mon, 6 May 2024 16:38:35 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: verisilicon: Fix auxiliary buffers allocation size From: Benjamin Gaignard To: Nicolas Dufresne , ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org, heiko@sntech.de Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20240328093439.18712-1-benjamin.gaignard@collabora.com> <20240328093439.18712-2-benjamin.gaignard@collabora.com> <2a3b897a-71f7-4a94-a13c-1aa8b2d96e78@collabora.com> Content-Language: en-US In-Reply-To: <2a3b897a-71f7-4a94-a13c-1aa8b2d96e78@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 05/04/2024 à 10:13, Benjamin Gaignard a écrit : > > Le 04/04/2024 à 20:00, Nicolas Dufresne a écrit : >> Hi, >> >> Le jeudi 28 mars 2024 à 10:34 +0100, Benjamin Gaignard a écrit : >>> Use v4l2_av1_tile_info->tile_cols to know the number of colons >>> in the frame. This made auxiliary buffers meory size computation >>> more accurate. >> Seems like this is potentially going to impact some conformance >> tests. Anything >> to report from fluster results ? > > Flusters AV1 score is the same. > Maybe we have been lucky when allocating memory until now. > That said the test stream have 8 tile columns which is unusual but > admitted by AV1 specifications. Gentle ping, Regards, Benjamin > > Benjamin > >> >> Nicolas >> >>> Signed-off-by: Benjamin Gaignard >>> Fixes: 727a400686a2 ("media: verisilicon: Add Rockchip AV1 decoder") >>> --- >>> .../media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c | 3 ++- >>>   1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git >>> a/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c >>> b/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c >>> index cc4483857489..65e8f2d07400 100644 >>> --- a/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c >>> +++ b/drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c >>> @@ -257,7 +257,8 @@ static int >>> rockchip_vpu981_av1_dec_tiles_reallocate(struct hantro_ctx *ctx) >>>       struct hantro_dev *vpu = ctx->dev; >>>       struct hantro_av1_dec_hw_ctx *av1_dec = &ctx->av1_dec; >>>       struct hantro_av1_dec_ctrls *ctrls = &av1_dec->ctrls; >>> -    unsigned int num_tile_cols = 1 << >>> ctrls->tile_group_entry->tile_col; >>> +    const struct v4l2_av1_tile_info *tile_info = >>> &ctrls->frame->tile_info; >>> +    unsigned int num_tile_cols = tile_info->tile_cols; >>>       unsigned int height = ALIGN(ctrls->frame->frame_height_minus_1 >>> + 1, 64); >>>       unsigned int height_in_sb = height / 64; >>>       unsigned int stripe_num = ((height + 8) + 63) / 64; >>