All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gyorgy Sarvari <skandigraun@gmail.com>
To: Ross Burton <Ross.Burton@arm.com>
Cc: "openembedded-devel@lists.openembedded.org"
	<openembedded-devel@lists.openembedded.org>
Subject: Re: [oe] [meta-oe][PATCH] capnproto: remove binary checking from target cmake file
Date: Mon, 3 Feb 2025 08:48:20 +0100	[thread overview]
Message-ID: <3defd464-87cd-40ad-bace-bdf12b96731a@gmail.com> (raw)
In-Reply-To: <D0A3556C-EE0D-409C-9DD1-229006AEA692@arm.com>

On 02.02.25 21:33, Ross Burton wrote:
> On 2 Feb 2025, at 20:06, Gyorgy Sarvari via lists.openembedded.org <skandigraun=gmail.com@lists.openembedded.org> wrote:
>> +do_install:append:class-target() {
>> +  # delete lines checking files in bindir, e.g. this:
>> +  # list(APPEND _cmake_import_check_files_for_CapnProto::capnp_tool "${_IMPORT_PREFIX}/bin/capnp" )
>> +  sed -i "/.*_cmake_import_check_files_for_CapnProto.*bin\/.*/d" ${D}${libdir}/cmake/CapnProto/CapnProtoTargets-noconfig.cmake
>> +}
> A sed like this is incredibly fragile and will silently stop working if the cmake files changes. I recommend using a patch instead, as they fail fast instead of silently.
>
> Ross
>
Looking into it...


      reply	other threads:[~2025-02-03  7:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-02 19:06 [meta-oe][PATCH] capnproto: remove binary checking from target cmake file Gyorgy Sarvari
2025-02-02 20:33 ` [oe] " Ross Burton
2025-02-03  7:48   ` Gyorgy Sarvari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3defd464-87cd-40ad-bace-bdf12b96731a@gmail.com \
    --to=skandigraun@gmail.com \
    --cc=Ross.Burton@arm.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.