From: Damien Le Moal <dlemoal@kernel.org>
To: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 6/6] nvme-ioctl: simplify parameters
Date: Tue, 25 Feb 2025 07:32:05 +0900 [thread overview]
Message-ID: <3defd803-650d-40d1-b1fb-e32a5d4318e4@kernel.org> (raw)
In-Reply-To: <20250224182128.2042061-7-kbusch@meta.com>
On 2/25/25 03:21, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The uring_cmd handler already defines a struct to group all the
> parameters needed to submit a request. Reuse this throughout to simplfy
> the function signature.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-02-24 22:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 18:21 [PATCH 0/6] nvme ioctl cleanups Keith Busch
2025-02-24 18:21 ` [PATCH 1/6] nvme-ioctl: fold open_for_write into flags Keith Busch
2025-02-24 22:17 ` Damien Le Moal
2025-02-24 22:21 ` Chaitanya Kulkarni
2025-02-24 23:10 ` Christoph Hellwig
2025-02-25 9:05 ` Kanchan Joshi
2025-02-24 18:21 ` [PATCH 2/6] nvme-ioctl: use common type for user data addresses Keith Busch
2025-02-24 22:22 ` Damien Le Moal
2025-02-24 22:30 ` Christoph Hellwig
2025-02-24 22:47 ` Keith Busch
2025-02-25 9:07 ` Kanchan Joshi
2025-02-25 14:29 ` Nilay Shroff
2025-02-24 18:21 ` [PATCH 3/6] nvme-ioctl: fold 'vec' into flags Keith Busch
2025-02-24 22:23 ` Damien Le Moal
2025-02-24 22:34 ` Christoph Hellwig
2025-02-25 9:08 ` Kanchan Joshi
2025-02-24 18:21 ` [PATCH 4/6] nvme-ioctl: common user timeout setting Keith Busch
2025-02-24 22:29 ` Damien Le Moal
2025-02-24 22:34 ` Christoph Hellwig
2025-02-25 9:08 ` Kanchan Joshi
2025-02-24 18:21 ` [PATCH 5/6] nvme-ioctl: combine alloc and map Keith Busch
2025-02-24 22:30 ` Damien Le Moal
2025-02-24 22:35 ` Christoph Hellwig
2025-02-25 9:33 ` Kanchan Joshi
2025-02-24 18:21 ` [PATCH 6/6] nvme-ioctl: simplify parameters Keith Busch
2025-02-24 22:32 ` Damien Le Moal [this message]
2025-02-24 22:37 ` Christoph Hellwig
2025-02-25 9:35 ` Kanchan Joshi
2025-02-25 0:44 ` [PATCH 0/6] nvme ioctl cleanups Chaitanya Kulkarni
2025-03-03 20:03 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3defd803-650d-40d1-b1fb-e32a5d4318e4@kernel.org \
--to=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.