From: David Ahern <dsahern@kernel.org>
To: Guillaume Nault <gnault@redhat.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ipv4: Set correct scope in inet_csk_route_*().
Date: Mon, 5 Jun 2023 20:47:06 -0600 [thread overview]
Message-ID: <3df5cd7d-ef75-1397-bb35-d9c56d8acfd2@kernel.org> (raw)
In-Reply-To: <08fb058e8cf99ab1f9178caac52e665f94fcba3c.1685999117.git.gnault@redhat.com>
On 6/5/23 3:55 PM, Guillaume Nault wrote:
> RT_CONN_FLAGS(sk) overloads the tos parameter with the RTO_ONLINK bit
> when sk has the SOCK_LOCALROUTE flag set. This is only useful for
> ip_route_output_key_hash() to eventually adjust the route scope.
>
> Let's drop RTO_ONLINK and set the correct scope directly to avoid this
> special case in the future and to allow converting ->flowi4_tos to
> dscp_t.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
> ---
> net/ipv4/inet_connection_sock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-06-06 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 21:55 [PATCH net-next 0/2] ipv4: Remove RT_CONN_FLAGS() calls in flowi4_init_output() Guillaume Nault
2023-06-05 21:55 ` [PATCH net-next 1/2] ipv4: Set correct scope in inet_csk_route_*() Guillaume Nault
2023-06-06 2:47 ` David Ahern [this message]
2023-06-05 21:55 ` [PATCH net-next 2/2] tcp: Set route scope properly in cookie_v4_check() Guillaume Nault
2023-06-06 2:47 ` David Ahern
2023-06-07 4:20 ` [PATCH net-next 0/2] ipv4: Remove RT_CONN_FLAGS() calls in flowi4_init_output() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df5cd7d-ef75-1397-bb35-d9c56d8acfd2@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.