From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 10/11] drm/i915: Use a preemption timeout to enforce interactivity Date: Tue, 27 Mar 2018 09:35:17 +0100 Message-ID: <3df73d2a-c55e-3e0f-0670-6a263a134199@linux.intel.com> References: <20180326115044.2505-1-chris@chris-wilson.co.uk> <20180326115044.2505-11-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41E3589AC9 for ; Tue, 27 Mar 2018 08:35:20 +0000 (UTC) In-Reply-To: <20180326115044.2505-11-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI2LzAzLzIwMTggMTI6NTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBVc2UgYSBsaWJlcmFs IHRpbWVvdXQgb2YgMjBtcyB0byBlbnN1cmUgdGhhdCB0aGUgcmVuZGVyaW5nIGZvciBhbgo+IGlu dGVyYWN0aXZlIHBhZ2VmbGlwIGlzIHN0YXJ0ZWQgaW4gYSB0aW1lbHkgZmFzaGlvbiwgYW5kIHRo YXQKPiB1c2VyIGludGVyYWN0aW9uIGlzIG5vdCBibG9ja2VkIGJ5IEdQVSwgb3IgQ1BVLCBob2dz LiBUaGlzIGlzIGF0IHRoZSBjb3N0Cj4gb2YgcmVzZXR0aW5nIHdob2V2ZXIgd2FzIGJsb2NraW5n IHRoZSBwcmVlbXB0aW9uLCBsaWtlbHkgbGVhZGluZyB0byB0aGF0Cj4gY29udGV4dC9wcm9jZXNz IGJlaW5nIGJhbm5lZCBmcm9tIHN1Ym1pdHRpbmcgZnV0dXJlIHJlcXVlc3RzLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgIHwgIDMgKystCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgfCAxOCArKysrKysrKysrLS0tLS0tLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE4ICsrKysrKysrKysr KysrKysrLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA4MDAyMzBiYTFjM2IuLjg3 Mzg4ZmViOTczZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0zMTUwLDggKzMx NTAsOSBAQCBpbnQgaTkxNV9nZW1fb2JqZWN0X3dhaXQoc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl Y3QgKm9iaiwKPiAgIAkJCSBzdHJ1Y3QgaW50ZWxfcnBzX2NsaWVudCAqcnBzKTsKPiAgIGludCBp OTE1X2dlbV9vYmplY3Rfd2FpdF9wcmlvcml0eShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq b2JqLAo+ICAgCQkJCSAgdW5zaWduZWQgaW50IGZsYWdzLAo+IC0JCQkJICBpbnQgcHJpb3JpdHkp Owo+ICsJCQkJICBpbnQgcHJpb3JpdHksIHVuc2lnbmVkIGludCB0aW1lb3V0KTsKPiAgICNkZWZp bmUgSTkxNV9QUklPUklUWV9ESVNQTEFZIEk5MTVfUFJJT1JJVFlfTUFYCj4gKyNkZWZpbmUgSTkx NV9QUkVFTVBUSU9OX1RJTUVPVVRfRElTUExBWSAoMjAgKiAxMDAwICogMTAwMCkgLyogMjAgbXMg Ki8KPiAgIAo+ICAgaW50IF9fbXVzdF9jaGVjawo+ICAgaTkxNV9nZW1fb2JqZWN0X3NldF90b193 Y19kb21haW4oc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgYm9vbCB3cml0ZSk7Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggNjc1ZDZiYjU5MzM3Li4yNTJjNmI1OGU3Mzkg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtNDY5LDcgKzQ2OSw4IEBAIGk5MTVf Z2VtX29iamVjdF93YWl0X3Jlc2VydmF0aW9uKHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3QgKnJl c3YsCj4gICAJcmV0dXJuIHRpbWVvdXQ7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgX19mZW5j ZV9zZXRfcHJpb3JpdHkoc3RydWN0IGRtYV9mZW5jZSAqZmVuY2UsIGludCBwcmlvKQo+ICtzdGF0 aWMgdm9pZCBfX2ZlbmNlX3NldF9wcmlvcml0eShzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSwKPiAr CQkJCSBpbnQgcHJpbywgdW5zaWduZWQgaW50IHRpbWVvdXQpCj4gICB7Cj4gICAJc3RydWN0IGk5 MTVfcmVxdWVzdCAqcnE7Cj4gICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+IEBA IC00ODIsMTEgKzQ4MywxMiBAQCBzdGF0aWMgdm9pZCBfX2ZlbmNlX3NldF9wcmlvcml0eShzdHJ1 Y3QgZG1hX2ZlbmNlICpmZW5jZSwgaW50IHByaW8pCj4gICAKPiAgIAlyY3VfcmVhZF9sb2NrKCk7 Cj4gICAJaWYgKGVuZ2luZS0+c2NoZWR1bGUpCj4gLQkJZW5naW5lLT5zY2hlZHVsZShycSwgcHJp bywgMCk7Cj4gKwkJZW5naW5lLT5zY2hlZHVsZShycSwgcHJpbywgdGltZW91dCk7Cj4gICAJcmN1 X3JlYWRfdW5sb2NrKCk7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgZmVuY2Vfc2V0X3ByaW9y aXR5KHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlLCBpbnQgcHJpbykKPiArc3RhdGljIHZvaWQgZmVu Y2Vfc2V0X3ByaW9yaXR5KHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlLAo+ICsJCQkgICAgICAgaW50 IHByaW8sIHVuc2lnbmVkIGludCB0aW1lb3V0KQo+ICAgewo+ICAgCS8qIFJlY3Vyc2Ugb25jZSBp bnRvIGEgZmVuY2UtYXJyYXkgKi8KPiAgIAlpZiAoZG1hX2ZlbmNlX2lzX2FycmF5KGZlbmNlKSkg ewo+IEBAIC00OTQsMTYgKzQ5NiwxNiBAQCBzdGF0aWMgdm9pZCBmZW5jZV9zZXRfcHJpb3JpdHko c3RydWN0IGRtYV9mZW5jZSAqZmVuY2UsIGludCBwcmlvKQo+ICAgCQlpbnQgaTsKPiAgIAo+ICAg CQlmb3IgKGkgPSAwOyBpIDwgYXJyYXktPm51bV9mZW5jZXM7IGkrKykKPiAtCQkJX19mZW5jZV9z ZXRfcHJpb3JpdHkoYXJyYXktPmZlbmNlc1tpXSwgcHJpbyk7Cj4gKwkJCV9fZmVuY2Vfc2V0X3By aW9yaXR5KGFycmF5LT5mZW5jZXNbaV0sIHByaW8sIHRpbWVvdXQpOwo+ICAgCX0gZWxzZSB7Cj4g LQkJX19mZW5jZV9zZXRfcHJpb3JpdHkoZmVuY2UsIHByaW8pOwo+ICsJCV9fZmVuY2Vfc2V0X3By aW9yaXR5KGZlbmNlLCBwcmlvLCB0aW1lb3V0KTsKPiAgIAl9Cj4gICB9Cj4gICAKPiAgIGludAo+ ICAgaTkxNV9nZW1fb2JqZWN0X3dhaXRfcHJpb3JpdHkoc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl Y3QgKm9iaiwKPiAgIAkJCSAgICAgIHVuc2lnbmVkIGludCBmbGFncywKPiAtCQkJICAgICAgaW50 IHByaW8pCj4gKwkJCSAgICAgIGludCBwcmlvLCB1bnNpZ25lZCBpbnQgdGltZW91dCkKPiAgIHsK PiAgIAlzdHJ1Y3QgZG1hX2ZlbmNlICpleGNsOwo+ICAgCj4gQEAgLTUxOCw3ICs1MjAsNyBAQCBp OTE1X2dlbV9vYmplY3Rfd2FpdF9wcmlvcml0eShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq b2JqLAo+ICAgCQkJcmV0dXJuIHJldDsKPiAgIAo+ICAgCQlmb3IgKGkgPSAwOyBpIDwgY291bnQ7 IGkrKykgewo+IC0JCQlmZW5jZV9zZXRfcHJpb3JpdHkoc2hhcmVkW2ldLCBwcmlvKTsKPiArCQkJ ZmVuY2Vfc2V0X3ByaW9yaXR5KHNoYXJlZFtpXSwgcHJpbywgdGltZW91dCk7Cj4gICAJCQlkbWFf ZmVuY2VfcHV0KHNoYXJlZFtpXSk7Cj4gICAJCX0KPiAgIAo+IEBAIC01MjgsNyArNTMwLDcgQEAg aTkxNV9nZW1fb2JqZWN0X3dhaXRfcHJpb3JpdHkoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3Qg Km9iaiwKPiAgIAl9Cj4gICAKPiAgIAlpZiAoZXhjbCkgewo+IC0JCWZlbmNlX3NldF9wcmlvcml0 eShleGNsLCBwcmlvKTsKPiArCQlmZW5jZV9zZXRfcHJpb3JpdHkoZXhjbCwgcHJpbywgdGltZW91 dCk7Cj4gICAJCWRtYV9mZW5jZV9wdXQoZXhjbCk7Cj4gICAJfQo+ICAgCXJldHVybiAwOwo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA0YzMwYzdjMDRmOWMuLjgzMGYy ZDRlNTQwZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTI3 ODYsNyArMTI3ODYsMjMgQEAgaW50ZWxfcHJlcGFyZV9wbGFuZV9mYihzdHJ1Y3QgZHJtX3BsYW5l ICpwbGFuZSwKPiAgIAo+ICAgCXJldCA9IGludGVsX3BsYW5lX3Bpbl9mYih0b19pbnRlbF9wbGFu ZV9zdGF0ZShuZXdfc3RhdGUpKTsKPiAgIAo+IC0JaTkxNV9nZW1fb2JqZWN0X3dhaXRfcHJpb3Jp dHkob2JqLCAwLCBJOTE1X1BSSU9SSVRZX0RJU1BMQVkpOwo+ICsJLyoKPiArCSAqIFJlc2NoZWR1 bGUgb3VyIGRlcGVuZGVuY2llcywgYW5kIGVuc3VyZSB3ZSBydW4gd2l0aGluIGEgdGltZW91dC4K PiArCSAqCj4gKwkgKiBOb3RlIHRoYXQgaWYgdGhlIHRpbWVvdXQgaXMgZXhjZWVkZWQsIHRoZW4g d2hvZXZlciB3YXMgcnVubmluZyB0aGF0Cj4gKwkgKiBwcmV2ZW50ZWQgdXMgZnJvbSBhY3F1aXJp bmcgdGhlIEdQVSBpcyBkZWNsYXJlZCByb2d1ZSBhbmQgcmVzZXQuIEFuCj4gKwkgKiB1bnJlc3Bv bnNpdmUgcHJvY2VzcyB3aWxsIHRoZW4gYmUgYmFubmVkIGluIG9yZGVyIHRvIHByZXNlcnZlCj4g KwkgKiBpbnRlcmFjdGl2aXR5LiBTaW5jZSB0aGlzIGNhbiBiZSBzZWVuIGFzIGEgYml0IGhlYXZ5 LWhhbmRlZCwgd2UKPiArCSAqIHNlbGVjdCBhIHRpbWVvdXQgZm9yIHdoZW4gdGhlIGRyb3BwZWQg ZnJhbWVzIHN0YXJ0IHRvIGJlY29tZSBhCj4gKwkgKiBub3RpY2VhYmxlIG51aXNhbmNlIGZvciB0 aGUgdXNlciAoMjAgbXMsIGkuZS4gcHJlZW1wdGlvbiB3YXMgYmxvY2tlZAo+ICsJICogZm9yIG1v cmUgdGhhbiBhIGZyYW1lKS4gTm90ZSwgdGhpcyBpcyBvbmx5IGEgdGltZW91dCBmb3IgYSBkZWxh eSBpbgo+ICsJICogcHJlZW1wdGluZyB0aGUgY3VycmVudCByZXF1ZXN0IGluIG9yZGVyIHRvIHJ1 biBvdXIgZGVwZW5kZW5jeSBjaGFpbiwKPiArCSAqIG91ciBkZXBlbmRlbmN5IGNoYWluIG1heSBp dHNlbGYgdGFrZSBhIGxvbmcgdGltZSB0byBydW4gdG8gY29tcGxldGlvbgo+ICsJICogYmVmb3Jl IHdlIGNhbiBwcmVzZW50IHRoZSBmcmFtZWJ1ZmZlci4KPiArCSAqLwo+ICsJaTkxNV9nZW1fb2Jq ZWN0X3dhaXRfcHJpb3JpdHkob2JqLCAwLAo+ICsJCQkJICAgICAgSTkxNV9QUklPUklUWV9ESVNQ TEFZLAo+ICsJCQkJICAgICAgSTkxNV9QUkVFTVBUSU9OX1RJTUVPVVRfRElTUExBWSk7CgpBUEkg c2lnbmF0dXJlIGNoYW5nZXMgdG8gYWxsb3cgdGltZW91dHMgYXJlIGZpbmUsIGJ1dCBJIHRoaW5r IHRoaXMgaHVuayAKc2hvdWxkIGJlIHNlcGFyYXRlIHBhdGNoIGF0IHRoZSBlbmQgb2YgdGhlIHNl cmllcy4gKFNpbmNlIGl0IGhhcyB0aGUgCnBvdGVudGlhbCB0byBtYWtlIHRoaW5ncyB3aGljaCB1 c2VkIHRvIHdvcmssIGFsYmVpdCBzdHV0dGVyaW5nbHkgKD8pLCAKc3RhcnQgY3Jhc2hpbmcuCgpS ZWdhcmRzLAoKVHZydGtvCgo+ICAgCj4gICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0 cnVjdF9tdXRleCk7Cj4gICAJaTkxNV9nZW1fb2JqZWN0X3VucGluX3BhZ2VzKG9iaik7Cj4gCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=