From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 4/9] selftests: mptcp: add change_address helper
Date: Tue, 19 Mar 2024 18:01:48 +0100 [thread overview]
Message-ID: <3e0dcb65-d70e-48d0-bd61-8d752a6e922c@kernel.org> (raw)
In-Reply-To: <07d8d4f6ea1988bb56bca312c112deea1fd3e2c4.1710832493.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 19/03/2024 08:16, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> The address that needs to change flags can only be identified by an address
> ID in change_endpoint() helper. This patch adds another helper named
> change_address(), its 2nd parameter is an IP address.
>
> Usage:
> Address ID - change_endpoint $ns id $id $flags
> IP address - change_address $ns $addr $flags
It is confusing, there is no 'change_endpoint' helper.
>
> Use this new helper in pm_netlink.sh to replace all 'pm_nl_ctl set'
> commands.
(...)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-03-19 17:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 7:16 [PATCH mptcp-next v4 0/9] add helpers and vars in mptcp_lib.sh, final Geliang Tang
2024-03-19 7:16 ` [PATCH mptcp-next v4 1/9] selftests: mptcp: export ip_mptcp to mptcp_lib Geliang Tang
2024-03-19 7:16 ` [PATCH mptcp-next v4 2/9] selftests: mptcp: add get_limits helper Geliang Tang
2024-03-19 16:58 ` Matthieu Baerts
2024-03-19 7:16 ` [PATCH mptcp-next v4 3/9] selftests: mptcp: add get_endpoint helper Geliang Tang
2024-03-19 16:59 ` Matthieu Baerts
2024-03-19 7:16 ` [PATCH mptcp-next v4 4/9] selftests: mptcp: add change_address helper Geliang Tang
2024-03-19 17:01 ` Matthieu Baerts [this message]
2024-03-19 7:16 ` [PATCH mptcp-next v4 5/9] selftests: mptcp: join: update endpoint ops Geliang Tang
2024-03-19 7:16 ` [PATCH mptcp-next v4 6/9] selftests: mptcp: export pm_nl " Geliang Tang
2024-03-19 7:16 ` [PATCH mptcp-next v4 7/9] selftests: mptcp: use " Geliang Tang
2024-03-19 7:16 ` [PATCH mptcp-next v4 8/9] selftests: mptcp: ip_mptcp option for more scripts Geliang Tang
2024-03-19 7:16 ` [PATCH mptcp-next v4 9/9] selftests: mptcp: netlink: drop disable=SC2086 Geliang Tang
2024-03-19 8:07 ` [PATCH mptcp-next v4 0/9] add helpers and vars in mptcp_lib.sh, final MPTCP CI
2024-03-19 16:58 ` Matthieu Baerts
2024-03-19 17:43 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0dcb65-d70e-48d0-bd61-8d752a6e922c@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.