From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E1331A262D for ; Mon, 19 May 2025 18:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747677869; cv=none; b=fGamBwQ9ikUEPdP0AWU2yLoZ0rp3yIjfm2tuNYsON4QUPqafDw5GBM02/d3WAeAJHg7JFXTxK9boNG/aNZLbpMdOc30dy1NZaH74DwhElHXiwVJXIJ53cHX2dl08sF0YtiF3lL7d0j7uzc/UkyWADJ7TI+yI/vvQrzoMkePnhV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747677869; c=relaxed/simple; bh=zo8+/r1dolubNS9VK5Z/jU0dVzT1dnbZmTG0syHsfqQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Xr9Rx/oA52JrJK/1qQJlBsPoCbWrG8F0OBI8DSIw+CPXbiLCKu3xDHX66/qCBWWQu4gY5UP9bqQ6sn/MAAnRrVhu62rWh82BMx3p8OfLDP6XUfJOAIrjSrW3OaiSIc3WEU05BhuBBAJXHmFKwrGYyqfZ4BsYP0MZBRB3YXK+3z8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QShakyjK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QShakyjK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747677867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ylxl7a4tP8gYAwM6KLUB1+rIzOrluynBjKOFtEAvyJk=; b=QShakyjKiMnvkYScOISCTlMBg46XH9wZCoNYo+T8uAXtiv/8lyre7hYy9WU5lUSF+ypF6c QP0tHfncCnGWklHVo31Jxy0kmVNQsdHoNifTw3T/30HQU5hN0vfScdUd5SldiS2EoPQJlt gsPBhAPE6TPbjPHveM9lffF19mkEeJI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-8bAmBaOuOUWptT1RXFUA6g-1; Mon, 19 May 2025 14:04:25 -0400 X-MC-Unique: 8bAmBaOuOUWptT1RXFUA6g-1 X-Mimecast-MFC-AGG-ID: 8bAmBaOuOUWptT1RXFUA6g_1747677864 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so30121675e9.0 for ; Mon, 19 May 2025 11:04:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747677864; x=1748282664; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ylxl7a4tP8gYAwM6KLUB1+rIzOrluynBjKOFtEAvyJk=; b=vkrP3tVoTPmL/IvNGDg9R+W4cUhmhl4w2Bf225HPxcgIXd5lHchOxWELKlzfh14uWW X/M+8hNFyMLMTylD60yl7o4fSmseLRAjIK5eaxmj6E0E/Mz7Uyv/g3TI9r51TuMXEY1r xhEVh5lEc8kjVRbOGBxUnVstU+joDCc4fkCZVC7pTmSwqJwbfji641bwXIYPmTIHuj1f gGunGpbpK+ZzSdnx36FregzTdEiPcMkNDONisMoJTaDs5v8vBd61M260nmyPv8UEs9yj Xmba5mMODBTOTdMkFM53IvLzMMColiZoTvmUiTpRZBkCm+R1o/AgtcI7bVbpUn5XMx0i Hr8w== X-Forwarded-Encrypted: i=1; AJvYcCUqJDNPokVzObaAMWN+OJm1nyqKWpgOcfWSiYwuO9WbGdY4DLA9iAH2wIaLtEyk62C2ajo4XiL3tK1hgGS9@vger.kernel.org X-Gm-Message-State: AOJu0YwrhRpCFky7FKqWvhHy4JMBDZkuEbWaROxi7pUmfpGDxzdbl4gC NuMgwvWivWZqdHQvHnBr5ri37WvCBwEbUVxuNAtjUEIU9Z4tY81avkoAiRRhbZCqjofkM5WvjgS zZjg23fz6C017uJcMJ6b5DZsL5bnaeK8SxFcO9+0xBGmmUQYgQZ6trmyXwp2cegXIX7k= X-Gm-Gg: ASbGncsfTaEt5ZHrjYchUjAGRipq1ekN9bp+EIJw3Vsm88eUr8hevLucx95RdvkrEdr ukAW8WtbxQz8ISMB9+wGAnbFikB+YlSKSI5sr4fhgo6kaNjRaC4lEtti8XtWXby3n9bl2eL8pRm gGEpgUTivgGl73xiftcO0GVqSAmkyzvGjiwY2W69nlJjic5GfG0FGj1SqPnb9GK4bTWr+611nn+ U/u2Y6zvgcWKqMjnqTkruZc6r+T23b0SUkiLuFnbVWP3eL+YZihWMjDziOqA+0q0rLGuHCMnCIL VvxaUAgiJrdQhd7+ZTHFle3ibqMgnpZ+AacCoxv04zBWvRnNMjxIJHFGcT1MO6MKEewtWja1o5M ilN4z8O2immDoPZkcpaqvJrl+SsMkRgqtcgzxVeg= X-Received: by 2002:a05:600c:8215:b0:441:b5cb:4f94 with SMTP id 5b1f17b1804b1-442fd606ba6mr131278195e9.5.1747677864479; Mon, 19 May 2025 11:04:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqEHR0p47D6A7BByJuurOL3YWvqVix3j4p7J+y+K5WxZtOIn9b26frZGNIjwvHtGZbvgcUzA== X-Received: by 2002:a05:600c:8215:b0:441:b5cb:4f94 with SMTP id 5b1f17b1804b1-442fd606ba6mr131277925e9.5.1747677864153; Mon, 19 May 2025 11:04:24 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca888fcsm14274343f8f.78.2025.05.19.11.04.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 11:04:23 -0700 (PDT) Message-ID: <3e2d3bbb-8610-41d3-9aee-5a7bba3f2ce8@redhat.com> Date: Mon, 19 May 2025 20:04:22 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: prevent KSM from completely breaking VMA merging From: David Hildenbrand To: Lorenzo Stoakes , Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <418d3edbec3a718a7023f1beed5478f5952fc3df.1747431920.git.lorenzo.stoakes@oracle.com> Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> +/* >> + * Are we guaranteed no driver can change state such as to preclude KSM merging? >> + * If so, let's set the KSM mergeable flag early so we don't break VMA merging. >> + * >> + * This is applicable when PR_SET_MEMORY_MERGE has been set on the mm_struct via >> + * prctl() causing newly mapped VMAs to have the KSM mergeable VMA flag set. >> + * >> + * If this is not the case, then we set the flag after considering mergeability, >> + * which will prevent mergeability as, when PR_SET_MEMORY_MERGE is set, a new >> + * VMA will not have the KSM mergeability VMA flag set, but all other VMAs will, >> + * preventing any merge. > > Hmmm, so an ordinary MAP_PRIVATE of any file (executable etc.) will get > VM_MERGEABLE set but not be able to merge? > > Probably these are not often expected to be merged ... > > Preventing merging should really only happen because of VMA flags that > are getting set: VM_PFNMAP, VM_MIXEDMAP, VM_DONTEXPAND, VM_IO. > > > I am not 100% sure why we bail out on special mappings: all we have to > do is reliably identify anon pages, and we should be able to do that. > > GUP does currently refuses any VM_PFNMAP | VM_IO, and KSM uses GUP, > which might need a tweak then (maybe the solution could be to ... not > use GUP but a folio_walk). Oh, someone called "David" already did that. Nice :) So we *should* be able to drop * VM_PFNMAP: we correctly identify CoWed pages * VM_MIXEDMAP: we correctly identify CoWed pages * VM_IO: should not affect CoWed pages * VM_DONTEXPAND: no idea why that should even matter here -- Cheers, David / dhildenb