From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Date: Mon, 7 Nov 2016 17:53:42 +0100 Message-ID: <3e2dfdfd-9d87-b49a-4012-6027bdca10f5@gmail.com> References: <1472280263-18177-1-git-send-email-jitao.shi@mediatek.com> <1472280263-18177-2-git-send-email-jitao.shi@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Kurtz Cc: Enric Balletbo Serra , Jitao Shi , David Airlie , Thierry Reding , Mark Rutland , stonea168-9Onoh4P/yGk@public.gmane.org, dri-devel , Andy Yan , Ajay Kumar , Vincent Palatin , cawa cheng , =?UTF-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , Russell King , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sascha Hauer , Pawel Moll , Ian Campbell List-Id: linux-mediatek@lists.infradead.org On 05/11/16 00:21, Daniel Kurtz wrote: > On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger > wrote: >> >> On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote: >> [...] >>>> --- /dev/null >>>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c >> [...] >>>> >>>> + >>>> +/* Firmware */ >>>> +#define PS_FW_NAME "ps864x_fw.bin" >>>> + >>> >>> From where I can download this firmware image? >> >> I suppose this FW bits have to be added to linux-firmware repository first, before this patch can be accepted. > > All PS8640 devices should already ship with working firmware. > The firmware update procedure is only used in the unlikely event where > one wants to update the bridge to a different firmware provided by > Parade. > > Why must the lack of firmware really block landing this driver? > > If this is really so, can we just land the functional part of the > driver first, and add the firmware update in a follow-up patch. > After checking other users of request_firmware and check them against linux-firmware I think we don't need the FW in linux-firmware to get the driver merged. Especially as there already is a working FW stored on the device. Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Mon, 7 Nov 2016 17:53:42 +0100 Subject: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge In-Reply-To: References: <1472280263-18177-1-git-send-email-jitao.shi@mediatek.com> <1472280263-18177-2-git-send-email-jitao.shi@mediatek.com> Message-ID: <3e2dfdfd-9d87-b49a-4012-6027bdca10f5@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/11/16 00:21, Daniel Kurtz wrote: > On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger > wrote: >> >> On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote: >> [...] >>>> --- /dev/null >>>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c >> [...] >>>> >>>> + >>>> +/* Firmware */ >>>> +#define PS_FW_NAME "ps864x_fw.bin" >>>> + >>> >>> From where I can download this firmware image? >> >> I suppose this FW bits have to be added to linux-firmware repository first, before this patch can be accepted. > > All PS8640 devices should already ship with working firmware. > The firmware update procedure is only used in the unlikely event where > one wants to update the bridge to a different firmware provided by > Parade. > > Why must the lack of firmware really block landing this driver? > > If this is really so, can we just land the functional part of the > driver first, and add the firmware update in a follow-up patch. > After checking other users of request_firmware and check them against linux-firmware I think we don't need the FW in linux-firmware to get the driver merged. Especially as there already is a working FW stored on the device. Regards, Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753488AbcKGQxt (ORCPT ); Mon, 7 Nov 2016 11:53:49 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36361 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbcKGQxr (ORCPT ); Mon, 7 Nov 2016 11:53:47 -0500 Subject: Re: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge To: Daniel Kurtz References: <1472280263-18177-1-git-send-email-jitao.shi@mediatek.com> <1472280263-18177-2-git-send-email-jitao.shi@mediatek.com> Cc: Enric Balletbo Serra , Jitao Shi , David Airlie , Thierry Reding , Mark Rutland , stonea168@163.com, dri-devel , Andy Yan , Ajay Kumar , Vincent Palatin , cawa cheng , =?UTF-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , Russell King , "devicetree@vger.kernel.org" , Sascha Hauer , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Yingjoe Chen , =?UTF-8?B?RWRkaWUgSHVhbmcgKOm7g+aZuuWCkSk=?= , "linux-arm-kernel@lists.infradead.org" , Rahul Sharma , srv_heupstream , linux-kernel , Philipp Zabel , Kumar Gala , Sean Paul From: Matthias Brugger Message-ID: <3e2dfdfd-9d87-b49a-4012-6027bdca10f5@gmail.com> Date: Mon, 7 Nov 2016 17:53:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/16 00:21, Daniel Kurtz wrote: > On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger > wrote: >> >> On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote: >> [...] >>>> --- /dev/null >>>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c >> [...] >>>> >>>> + >>>> +/* Firmware */ >>>> +#define PS_FW_NAME "ps864x_fw.bin" >>>> + >>> >>> From where I can download this firmware image? >> >> I suppose this FW bits have to be added to linux-firmware repository first, before this patch can be accepted. > > All PS8640 devices should already ship with working firmware. > The firmware update procedure is only used in the unlikely event where > one wants to update the bridge to a different firmware provided by > Parade. > > Why must the lack of firmware really block landing this driver? > > If this is really so, can we just land the functional part of the > driver first, and add the firmware update in a follow-up patch. > After checking other users of request_firmware and check them against linux-firmware I think we don't need the FW in linux-firmware to get the driver merged. Especially as there already is a working FW stored on the device. Regards, Matthias