From: "Bo Liu (刘波)-浪潮信息" <liubo03@inspur.com>
To: "hsiangkao@linux.alibaba.com" <hsiangkao@linux.alibaba.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"brauner@kernel.org" <brauner@kernel.org>,
"bfoster@redhat.com" <bfoster@redhat.com>
Cc: "linux-erofs@lists.ozlabs.org" <linux-erofs@lists.ozlabs.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"djwong@kernel.org" <djwong@kernel.org>
Subject: Re: [PATCH -next] iomap: fix inline data on buffered read
Date: Wed, 19 Mar 2025 06:40:06 +0000 [thread overview]
Message-ID: <3e2e3c7edcec403fb824e973953a10ad@inspur.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
>Previously, iomap_readpage_iter() returning 0 would break out of the loops
of
>iomap_readahead_iter(), which is what iomap_read_inline_data() relies on.
>
>However, commit d9dc477ff6a2 ("iomap: advance the iter directly on buffered
>read") changes this behavior without calling iomap_iter_advance(), which
>causes EROFS to get stuck in iomap_readpage_iter().
>
>It seems iomap_iter_advance() cannot be called in
>iomap_read_inline_data() because of the iomap_write_begin() path, so handle
>this in iomap_readpage_iter() instead.
>
>Reported-by: Bo Liu <liubo03@inspur.com>
>Fixes: d9dc477ff6a2 ("iomap: advance the iter directly on buffered read")
>Cc: Brian Foster <bfoster@redhat.com>
>Cc: Christoph Hellwig <hch@lst.de>
>Cc: "Darrick J. Wong" <djwong@kernel.org>
>Cc: Christian Brauner <brauner@kernel.org>
>Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Tested-by: Bo Liu <liubo03@inspur.com>
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3777 bytes --]
next reply other threads:[~2025-03-19 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 6:40 Bo Liu (刘波)-浪潮信息 [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-19 2:59 [PATCH -next] iomap: fix inline data on buffered read Gao Xiang
2025-03-19 8:17 ` Christoph Hellwig
2025-03-19 8:23 ` Christoph Hellwig
2025-03-19 8:34 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2e3c7edcec403fb824e973953a10ad@inspur.com \
--to=liubo03@inspur.com \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.