From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
Subject: Re: [PATCH v6 2/3] dt-bindings: power: reset: fix minimum reg count for pmk8350-pon
Date: Tue, 28 Jul 2026 12:20:12 +0200 [thread overview]
Message-ID: <3e50d846-e850-4c85-97c2-60a34b66e976@kernel.org> (raw)
In-Reply-To: <20260728101223.5uvgmqmpwgvjvysz@hu-kotarake-hyd.qualcomm.com>
On 28/07/2026 12:12, Rakesh Kota wrote:
> On Mon, Jul 27, 2026 at 08:36:38AM +0200, Krzysztof Kozlowski wrote:
>> On Fri, Jul 24, 2026 at 03:44:12PM +0530, Rakesh Kota wrote:
>>> The GEN3 PON peripheral requires two register address spaces: "hlos"
>>> for the primary PON block and "pbs" for the address needs to be
>>> specified to facilitate software debouncing. Set minItems: 2 for reg
>>
>> That's ABI break and I do not underestand if this was broken before or
>> not. Driver ignores the PBS, so everything was working fine, no? Then
>> why PBS is required now? Is it actually working or not?
>>
>
> Not an ABI break. All in-tree GEN3 DTs using qcom,pmk8350-pon have
> always specified both "hlos" and "pbs" reg entries — pmk8350.dtsi,
That's not related to ABI.
What about my DTS?
> pmk8550.dtsi, pmk8850.dtsi, sc8280xp-pmics.dtsi. No issues were seen
> precisely because PBS was never omitted on any GEN3 platform.
>
> minItems: 2 simply enforces in the schema what has always been present
> in practice, ensuring future GEN3 DTs cannot accidentally omit the PBS
> address space which is a GEN3 hardware requirement.
This does not answer my questions.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-28 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 10:14 [PATCH v6 0/3] monaco: Add PMM8654AU PON support Rakesh Kota
2026-07-24 10:14 ` [PATCH v6 1/3] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU Rakesh Kota
2026-07-27 6:37 ` Krzysztof Kozlowski
2026-07-24 10:14 ` [PATCH v6 2/3] dt-bindings: power: reset: fix minimum reg count for pmk8350-pon Rakesh Kota
2026-07-27 6:36 ` Krzysztof Kozlowski
2026-07-28 10:12 ` Rakesh Kota
2026-07-28 10:20 ` Krzysztof Kozlowski [this message]
2026-07-24 10:14 ` [PATCH v6 3/3] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs Rakesh Kota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e50d846-e850-4c85-97c2-60a34b66e976@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.