From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C20E7716A for ; Sun, 15 Dec 2024 06:24:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D4446B007B; Sun, 15 Dec 2024 01:24:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 384676B0083; Sun, 15 Dec 2024 01:24:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24B756B0085; Sun, 15 Dec 2024 01:24:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 086626B007B for ; Sun, 15 Dec 2024 01:24:29 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B1BD123103 for ; Sun, 15 Dec 2024 06:24:28 +0000 (UTC) X-FDA: 82896203922.28.E414BEE Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf26.hostedemail.com (Postfix) with ESMTP id D98E414000A for ; Sun, 15 Dec 2024 06:24:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jb17N2DX; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734243840; a=rsa-sha256; cv=none; b=dpYjKSpUQNcJI8itt8tbpYe0+nOTp+So5IS+XHLM9d306RM1mS3gphyDvXE2dbVGPBIxhk 7Fn7s67Zqo7M85U6wAsvUZgM/uz973C8dqpdS2WQhVTJfLyzzewPifHpFFt+Rs/RGN0xvj Bq9JCUQjoLG9r10hQ3x01tbSPsw2jJk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jb17N2DX; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734243840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4SAJQvXzymBH1K/3pvDxzFBA5BN9QQVDFta4CsgF/cA=; b=eiYH6S3452YvhtRJsOljqtIx5Ug9arwtZHs6tdO4LCOnMxzcHtJENthnt7DL/17B64QGlj p0J1yG0+VXSmwRBsx/6jPrEARMAt52kImb80Df4LUBS/KxM65RsixzPawJAv0oL/dilRq4 Xd3e8F7q7egwWCODT7iKBM2ijlv2meY= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-21649a7bcdcso28679845ad.1 for ; Sat, 14 Dec 2024 22:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734243864; x=1734848664; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4SAJQvXzymBH1K/3pvDxzFBA5BN9QQVDFta4CsgF/cA=; b=jb17N2DXzeQp/VJjum6CRHgfv9tYDxX/3asnVZQGuOaib3m+qV9psoAJJscwZxYH2l 9wwNSdRR7JbHQuBzxdFJbeuwsxKMRBPzEeWPQWOOfgr3Ewx0YFyHxkoPbjw3+c/DD2WX meE2ej1VwY3/0zdBnj7oWEn8QUPCm1ykQNEKFgnRmHoGGs6DNDYIqJJrcN2cLdNU1B7J tkrDXml7lm8ggou5uotldCkNyqElF3f9eLyVpf2wMyMzY2ldJaaLroCr8AEjGXTGgc5a VLi6AqSU9KQslVSl3TrvvcZZ7MED4HK2XYzDeEtOn39BdhFKGQi6oDHTV2+TxPzO25oP xZAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734243864; x=1734848664; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4SAJQvXzymBH1K/3pvDxzFBA5BN9QQVDFta4CsgF/cA=; b=oFwpM6AbVrAgJFf3JD0/1XwCTBosGQKuHnvyKY+WVppcksqq7VPoWw+IhCrOwXLtBD jX8/ffRUSZExZRmw/f6Crblb/ij+q0sV/iUp+ClnECTXURyhHmhdh3CNYoEy9zhXgqqn 1g0mN/G5Ldzq7y1YglWzlyJ5wMPoeYg21eXTUupIO1DS/sxVpaumupdVVDJ+K++/9g5n i1CUbsBxlyeuPvoJkOLJE59wLrG9CN6oMIu+CuNZC0YdPHwgfDbNlmuXydqZ9SGBIMSZ h5NRh+QIL4CHGRSkwQDkeHKahvAMlXtY2wi4Zd3B5jRw/Xjcmt8ISRMZbED6nkHw4jBa RVOw== X-Forwarded-Encrypted: i=1; AJvYcCUuBLXkx5b4uswj5M+PczuvoNh89/OoWqAWJrrX5hm1xda2o+EMuFQppa/rSuvt1kpL7xM+yrkSWQ==@kvack.org X-Gm-Message-State: AOJu0Ywzj0z9wzdjdLu6PB8x2LUCYnzxSobh6esKJBaOmR/wYFd2BXAA C1yuBNHq/ZbYCyJYg4d7U/EaacoStzFrPi0K0cxyCpUw5UwgFxyTHU59Z5vWiuw= X-Gm-Gg: ASbGnctIglnAD2/Ajfhr/j3gNHeWrYGOq3okMOJqTY/FHxqdc6MlzY9k2QsJmjPPYpy WGGb+KtIJXsDyiOZ/syt6vT0LD2PnDr40leMB8s3swKlQKdSlJHZxNFkSk1rL1TfmCGteSBWFY4 WrzjG2pnQrf2KaAsVIwELK7c2L663Dx2MwUdVBQEnWkEM9NdLEs2yOf7TcRcA6Nc17mthsWRI/n Ekgut8tl4nm+UsZG7TklBZbpglX6tstwfrPBmJMdLJCUNjgt9hQNrBoB/3j2NYRFqbvWTlMkbNA LS5A41ofJ6PrgXA39yLrvTeUuiGm4412qeJy1djI5hxVfqNck/n/7fc= X-Google-Smtp-Source: AGHT+IEJMRdDDD6ihEEKBvCjk//M8WTTQOqdmcPzFG0Vq6NdBzL99WFtGq34scEZzQIahLUfq8EbyA== X-Received: by 2002:a17:902:f646:b0:216:1ad4:d8fd with SMTP id d9443c01a7336-2189298a2bfmr127837275ad.8.1734243864448; Sat, 14 Dec 2024 22:24:24 -0800 (PST) Received: from ?IPV6:2409:8a28:f4f:a9a4:11bc:4825:e7fe:2e0e? ([2409:8a28:f4f:a9a4:11bc:4825:e7fe:2e0e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e50a97sm21471645ad.149.2024.12.14.22.23.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Dec 2024 22:24:23 -0800 (PST) Message-ID: <3e790063-dea0-4ba2-9d25-4abcc072fba4@bytedance.com> Date: Sun, 15 Dec 2024 14:23:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/12] move pagetable_*_dtor() to __tlb_remove_table() To: Peter Zijlstra Cc: tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241214185511.GF10560@noisy.programming.kicks-ass.net> From: Qi Zheng Content-Language: en-US In-Reply-To: <20241214185511.GF10560@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 969nrz6b79q6tdnjs16zufemcchee1uu X-Rspam-User: X-Rspamd-Queue-Id: D98E414000A X-Rspamd-Server: rspam08 X-HE-Tag: 1734243844-605696 X-HE-Meta: U2FsdGVkX18pF5/nCJ93uPGO5HUybAAZISEwQSQwxMF3BBR629xKiD9MhLl70fF+0BoiyJh0xaaqhTv+B2NbAEXSAqU2xKyheyPeQ5Nq2jF0pP0y2wN7sQGRi6PUTjNgMo8m2biN+SfjKNcBg+IDtgxM40kjj0pAGN06482px5W0CYQ1tEYbEO/cIcqMQwgfJF40/2nAnXtxaC6PQ5ZEIQChdfKakNAyJbmYoPC3zBUu4ttRboamKRCPJyPO7K36HnFCE+bQhG4+frwKsXVvYc25cIeiTtVFfErMupqB4Eqio6LLdYQO49cQjmnXWdNgTNYU0OyUKLbd/rh16a9l4L+++AsaEo5v1SrPnSxgXLZAPjtrCvB8wScSbxBAeZhbNUJKj2BIeFLm4GB5/2BqGbCwFTH/DuLr/R4vef7IoLBw5dB35p1fsJmwKeA90kdsNMPPF3XWYa3MN3tCYtLqPe+ssnnh0fmF/eSygtSwuudM3taz1Ag69uLKGcMrBRIE8I8+pIbqwNDoRRLUos/BXXRDR117WiOe3dyHx7Vewo7SvDJJSHYnK/QrREig5JxxhaUZlKuu8qxsF9OTVS7AbY4z1r8LdLrB4xhU2tVx42ZtoawPgUtHuySPcT1uoqgEuertRIC+oo2JU07OtM2WVQ8rMezrE/lAPz4gt+sI7D7shO/r828bB1/OKQAb8jybWiGDQj6RcWyaCzlTfdt0JefRgIT7lW8IzqeOmnVoHF5npn30P3Tz9Z3sxW7FPxjSzYXwWFLlCDONi4ByV7YgV3f+j+i+osesDayP9nMcvkloHm/lNwc3Dnyug/nIOPYmD9CK2dnMhnuQiqbEw/LoVneWmfvpERbwlRfNySDBZ1HzGZKIaLc+WNKx+5j0S5zt1OVRIVBtIeE1YoorqKAmnecO96ji6dRsd43eXoSqK63geQutBDWrzqp7/cI9y19/ds/8MDKb4p8d7UfznZ0 +/JfGdN+ Scyi2Bc0DPTRDmFWjq99f7l+ihid1jJzu+4MZIJWs0pFkadwM0mlKgI1E8hrokwTCwz/xXCruEDNU+PYXPHhwsoiu8RPLdB55Kv3L2A5HQ4WthB0u5n52uAQIHmu1vjoA3OrEA3wos8KzAY9zgDcWMvaIZyvVxvhEIsuMk8TK2YoWT5PqSltQXgWkskggaCWvNC05IgE98upyBt2ad25/TVKzRCjEswvlppqeA2FOuMg5qvOnRClgJ1CjZU1ahWZ+CCyNb6kpYdnUh+yqlf5fBm5j3CJvjCd8y32urwW24Sb7reh5KzAQ6aBSJhm8kbNgefS82oyp8d+9Fo5uqWkCXB/AOA+ozGqasS0cFKSk+nDoUc6+In9JDRG0oq7GGuqED7Vhd44uJq0jYFiOpqetqcJ2lW2CnKmKDch2EB6bsHe8O9orIUqoEEUYqqeN7KiJl43DJKpt4boAzbAbgtrfQAe5c3E9A8uRSfN+n0SkZbgz59s= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.488797, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/15 02:55, Peter Zijlstra wrote: > On Sat, Dec 14, 2024 at 05:02:46PM +0800, Qi Zheng wrote: > >> As proposed [1] by Peter Zijlstra below, this patch series aims to move >> pagetable_*_dtor() into __tlb_remove_table(). This will cleanup pagetable_*_dtor() >> a bit and more gracefully fix the UAF issue [2] reported by syzbot. > > I'll go over the patches in more detail on Monday, but at least the > first few patches should probably carry something like: > > Originally-by: Peter Zijlstra (Intel) Right! Will add this for [PATCH 02/12], [PATCH 03/12] and [PATCH 05/12], > > Since you extracted it from my half-baked patch, the rest could probably > do with: > > Suggested-by: Peter Zijlstra (Intel) and add this for [PATCH 04/12], [PATCH 06|07|08|09|10/12]. > > Anyway, thanks for doing this, and so quicky! As said, I'll read more on > Monday. Thanks!