Re: [PATCH] net: stmmac: add support for dwmac 5.20

[Yanteng Si <si.yanteng@linux.dev>]

在 6/30/25 2:26 AM, Andrew Lunn 写道:
> On Sun, Jun 29, 2025 at 05:44:25PM +0800, Jisheng Zhang wrote:
>> The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
>> compatibility flag, and extend coverage of the dwmac-generic driver
>> for the 5.20 IP.
>>
>> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
>> ---
>>   drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> index b9218c07eb6b..cecce6ed9aa6 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> @@ -59,6 +59,7 @@ static const struct of_device_id dwmac_generic_match[] = {
>>   	{ .compatible = "snps,dwmac-3.72a"},
>>   	{ .compatible = "snps,dwmac-4.00"},
>>   	{ .compatible = "snps,dwmac-4.10a"},
>> +	{ .compatible = "snps,dwmac-5.20"},
>>   	{ .compatible = "snps,dwmac"},
>>   	{ .compatible = "snps,dwxgmac-2.10"},
>>   	{ .compatible = "snps,dwxgmac"},
> 
> I can see a compatible flag being added. But what about the extending
> the coverage of the dwmac-generic driver part?
I don't think the timing is ripe yet (including the patch itself).
Maybe it would be better to do this when a hardware driver is to
be introduced into the kernel.

Thanks,
Yanteng