From: Shuah Khan <skhan@linuxfoundation.org>
To: Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org
Cc: mhocko@suse.com, rientjes@google.com, willy@infradead.org,
hannes@cmpxchg.org, guro@fb.com, minchan@kernel.org,
kirill@shutemov.name, aarcange@redhat.com, brauner@kernel.org,
hch@infradead.org, oleg@redhat.com, david@redhat.com,
jannh@google.com, shakeelb@google.com, peterx@redhat.com,
jhubbard@nvidia.com, shuah@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, kernel-team@android.com,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/3] mm: drop oom code from exit_mmap
Date: Tue, 10 May 2022 09:46:05 -0600 [thread overview]
Message-ID: <3e847a15-e8c0-41fd-9518-2ae3d4a39092@linuxfoundation.org> (raw)
In-Reply-To: <20220510030014.3842475-2-surenb@google.com>
On 5/9/22 9:00 PM, Suren Baghdasaryan wrote:
> With the oom-killer being able to operate on locked pages, exit_mmap
> does not need to ensure that oom_reap_task_mm is done before it can
> proceed. Instead it can rely on mmap_lock write lock to prevent
> oom-killer from operating on the vma tree while it's freeing page
> tables. exit_mmap can hold mmap_lock read lock when unmapping vmas
> and then take mmap_lock write lock before freeing page tables.
>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> ---
> include/linux/oom.h | 2 --
> mm/mmap.c | 25 ++++++-------------------
> mm/oom_kill.c | 2 +-
> 3 files changed, 7 insertions(+), 22 deletions(-)
>
How does this improve the test? Include the information on why this
change is needed as opposed describing what this does?
thanks,
-- Shuah
next prev parent reply other threads:[~2022-05-10 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:00 [PATCH 1/3] selftests: vm: add process_mrelease tests Suren Baghdasaryan
2022-05-10 3:00 ` [PATCH 2/3] mm: drop oom code from exit_mmap Suren Baghdasaryan
2022-05-10 13:05 ` Michal Hocko
2022-05-10 16:31 ` Suren Baghdasaryan
2022-05-10 20:53 ` Michal Hocko
2022-05-10 20:59 ` Suren Baghdasaryan
2022-05-10 15:46 ` Shuah Khan [this message]
2022-05-10 16:35 ` Suren Baghdasaryan
2022-05-10 3:00 ` [PATCH 3/3] mm: delete unused MMF_OOM_VICTIM flag Suren Baghdasaryan
2022-05-10 13:08 ` Michal Hocko
2022-05-16 2:46 ` Suren Baghdasaryan
2022-05-10 15:51 ` Shuah Khan
2022-05-10 16:10 ` Suren Baghdasaryan
2022-05-10 15:43 ` [PATCH 1/3] selftests: vm: add process_mrelease tests Shuah Khan
2022-05-10 16:29 ` Suren Baghdasaryan
2022-05-10 16:35 ` Shuah Khan
2022-05-10 16:42 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e847a15-e8c0-41fd-9518-2ae3d4a39092@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=kernel-team@android.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oleg@redhat.com \
--cc=peterx@redhat.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.