From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8217285584740667862==" MIME-Version: 1.0 From: David Hildenbrand To: kbuild-all@lists.01.org Subject: Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? Date: Tue, 05 May 2020 17:46:44 +0200 Message-ID: <3eaebd8d-750a-d046-15f5-706fb00a196e@redhat.com> In-Reply-To: <20200505114433-mutt-send-email-mst@kernel.org> List-Id: --===============8217285584740667862== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 05.05.20 17:44, Michael S. Tsirkin wrote: > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: >> On 05.05.20 16:15, kbuild test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git v= host >>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 >>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Par= avirtualized memory hotplug >>> config: x86_64-randconfig-b002-20200505 (attached as .config) >>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 >>> reproduce: >>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0 >>> # save the attached .config to linux build tree >>> make ARCH=3Dx86_64 = >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kbuild test robot >>> >>> All error/warnings (new ones prefixed by >>): >>> >>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': >>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of f= unction 'kzalloc'; did you mean 'vzalloc'? [-Werror=3Dimplicit-function-dec= laration] >>> vdev->priv =3D vm =3D kzalloc(sizeof(*vm), GFP_KERNEL); >>> ^~~~~~~ >>> vzalloc >>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointe= r from integer without a cast [-Wint-conversion] >>> vdev->priv =3D vm =3D kzalloc(sizeof(*vm), GFP_KERNEL); >>> ^ >>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of fu= nction 'kfree'; did you mean 'vfree'? [-Werror=3Dimplicit-function-declarat= ion] >>> kfree(vm); >>> ^~~~~ >>> vfree >>> cc1: some warnings being treated as errors >>> >>> vim +1375 drivers/virtio/virtio_mem.c >> >> Guess we simply need >> >> #include >> >> to make it work for that config. > = > = > OK I added that in the 1st commit that introduced virtio-mem. Thanks. I have some addon-patches ready, what's the best way to continue with these? -- = Thanks, David / dhildenb --===============8217285584740667862==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? Date: Tue, 5 May 2020 17:46:44 +0200 Message-ID: <3eaebd8d-750a-d046-15f5-706fb00a196e@redhat.com> References: <202005052221.83QerHmG%lkp@intel.com> <7dea2810-85cf-0892-20a8-bba3e3a2c133@redhat.com> <20200505114433-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200505114433-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: "Michael S. Tsirkin" Cc: Pankaj Gupta , kbuild-all@lists.01.org, kbuild test robot , kvm@vger.kernel.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On 05.05.20 17:44, Michael S. Tsirkin wrote: > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: >> On 05.05.20 16:15, kbuild test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost >>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 >>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug >>> config: x86_64-randconfig-b002-20200505 (attached as .config) >>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 >>> reproduce: >>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0 >>> # save the attached .config to linux build tree >>> make ARCH=x86_64 >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kbuild test robot >>> >>> All error/warnings (new ones prefixed by >>): >>> >>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': >>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); >>> ^~~~~~~ >>> vzalloc >>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion] >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); >>> ^ >>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] >>> kfree(vm); >>> ^~~~~ >>> vfree >>> cc1: some warnings being treated as errors >>> >>> vim +1375 drivers/virtio/virtio_mem.c >> >> Guess we simply need >> >> #include >> >> to make it work for that config. > > > OK I added that in the 1st commit that introduced virtio-mem. Thanks. I have some addon-patches ready, what's the best way to continue with these? -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E71C47257 for ; Tue, 5 May 2020 15:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06EAF20746 for ; Tue, 5 May 2020 15:47:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RflT+Pjm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730504AbgEEPrb (ORCPT ); Tue, 5 May 2020 11:47:31 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:46543 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730457AbgEEPra (ORCPT ); Tue, 5 May 2020 11:47:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588693648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CXSDb19dE2QCf06dgi6foK1UYMiGs0Wvb6l4Uj5Is34=; b=RflT+PjmXoPp+NMHgRIS4OoDHGBniAScZKmZPhc+wm271skNnohLs4o+GEpJpiPeP71win w6ypQew5yQXG+lNeZaBmOgdhkpwXWDbWrqpHBODHYyJWckw7p9IGeKCDrlmuYfsOoOG6kW rKiG0X+1v+XULfI+EN91oE4On44m7ws= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-o4HH4TSGOqaZJZTJUYbsFw-1; Tue, 05 May 2020 11:47:23 -0400 X-MC-Unique: o4HH4TSGOqaZJZTJUYbsFw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1DDC6190B696; Tue, 5 May 2020 15:46:47 +0000 (UTC) Received: from [10.36.114.14] (ovpn-114-14.ams2.redhat.com [10.36.114.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 717C619C4F; Tue, 5 May 2020 15:46:45 +0000 (UTC) Subject: Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? To: "Michael S. Tsirkin" Cc: kbuild test robot , kbuild-all@lists.01.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Pankaj Gupta References: <202005052221.83QerHmG%lkp@intel.com> <7dea2810-85cf-0892-20a8-bba3e3a2c133@redhat.com> <20200505114433-mutt-send-email-mst@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <3eaebd8d-750a-d046-15f5-706fb00a196e@redhat.com> Date: Tue, 5 May 2020 17:46:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200505114433-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 05.05.20 17:44, Michael S. Tsirkin wrote: > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: >> On 05.05.20 16:15, kbuild test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost >>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 >>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug >>> config: x86_64-randconfig-b002-20200505 (attached as .config) >>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 >>> reproduce: >>> git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0 >>> # save the attached .config to linux build tree >>> make ARCH=x86_64 >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kbuild test robot >>> >>> All error/warnings (new ones prefixed by >>): >>> >>> drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': >>>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); >>> ^~~~~~~ >>> vzalloc >>>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion] >>> vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); >>> ^ >>>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] >>> kfree(vm); >>> ^~~~~ >>> vfree >>> cc1: some warnings being treated as errors >>> >>> vim +1375 drivers/virtio/virtio_mem.c >> >> Guess we simply need >> >> #include >> >> to make it work for that config. > > > OK I added that in the 1st commit that introduced virtio-mem. Thanks. I have some addon-patches ready, what's the best way to continue with these? -- Thanks, David / dhildenb