From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810B3175A91 for ; Thu, 18 Jun 2026 23:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781825951; cv=fail; b=k99bU1qx8d7NZOxndA79l/SCRwMMtrNxDKyQN3jZeMMErmkVOQ/cDQSvSijNBQgu9alX21V456pDn1REFmbl09C+ReZ2iiZ7/TPJgDl149PDPIn2jMhwZE08Hu+qQk3KVioSRcV/nhjM8Ntjl2vNRODJQMAJNGFRfV/El7829zM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781825951; c=relaxed/simple; bh=YFJfQ5RVXMCk73xZh56c8/nNu33xJ10GaO02LS7ZvJE=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=ISj9eoC7gp0o8ycjVr/z/0/hSdSxb2a26MR2gNUGAroyyG7Le63Xj6NawDmxV4wjkEIL2qy+yAOM8PAW7zluundmfMwv2mQ86grl5hbqGfutLdb/e2JY2FCHue7H8xBCUd7hfo3lX70lu2+3noFlRPDCexXRmotXmU7LGYOZJzw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VbHYHA0M; arc=fail smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VbHYHA0M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781825951; x=1813361951; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YFJfQ5RVXMCk73xZh56c8/nNu33xJ10GaO02LS7ZvJE=; b=VbHYHA0MVVywNCkQyKXpj2Gg1uL7qYRl6Lv/Iasin8c936rap5l2WkOR dVXm0NaTYPQmZ/QQ0jvlvMN8S0CPaWFJRso9Nuycziofb8fgCuoJwYPLa dffCc827qIPzr3QxP1e36FtoxTwE4iWs2U3TnAUZF6KbebuAtxIoSm81v d3kAeN8Q6sSkXBvBFXtKeRA/7uwv1o/dAuHEwlA+gnlWdYKA78qiJzQyx ejpKYPhs9OjBquNt8I3R5PMVHrbepIZ5MekRgwVhoxVEWST4phqyey4B6 jE5cAIFrUu5505533YtUb+zq+vIaIuSZzngOSAa7h672xEjUIAxsxgopG A==; X-CSE-ConnectionGUID: N2lWAdKwQ6qNbV1Uc1Hnuw== X-CSE-MsgGUID: sK+FeG0fTbG6Gs9aGMM6KQ== X-IronPort-AV: E=McAfee;i="6800,10657,11821"; a="94179108" X-IronPort-AV: E=Sophos;i="6.24,212,1774335600"; d="scan'208";a="94179108" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2026 16:39:10 -0700 X-CSE-ConnectionGUID: TWOy2tPQSqWAfH+IA1YJSQ== X-CSE-MsgGUID: LCM/wxmHRoqsQ2LW5HwS8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,212,1774335600"; d="scan'208";a="248356687" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2026 16:39:10 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 18 Jun 2026 16:39:09 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Thu, 18 Jun 2026 16:39:09 -0700 Received: from SN4PR2101CU001.outbound.protection.outlook.com (40.93.195.3) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 18 Jun 2026 16:39:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=igQeFuTxnOwwEjdx636SHvnyX+nyFyaONApPsqiQ2auWqM6h3UfN9/kcAlCBDnM3G3iCzIzZCVkTFE9t8CU1OhP5zliDFitytvbVY+fjblPpWID4HlP1RadUM85Ix2851iIUvYdQTmkQtGwsQvrDutbcwBzGcLqxbS4Lp2j8ogPPthOZW9vKojgCdBcfCHPNu3Z2lMbL9RS7BY6X4b4/MkkqLtnhF7sSOcjRg5ZVOvgO0IFd8+iiMZHV3igxgqLnMFjc2RgglAayjWJqFh8y4AwNec3ySlM/k5rDyZNnOZvYtW0ViSP95sBG+shEW2B1rUTeXnbeTjcyOHTwFrbkWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IXXBQan6fox3DZCcv4rFZRKcKs9lvvPO5RaiPWExhi0=; b=ZpY7lLf3MhX8Y8l0hzvLHGSVstR9myVv4MvTEZzKUJf6JLzf8QoSDSGQgFFqZDBSAKOqHF+WpxmKSYTAK9Ftl2Cspl84cFQja6+Qv2fsll9WoISpAImRZlT2iGTbK5qa7guqay1BKR9OAigKrqL2gIzEfiO1Fnc6Y69JDw2FXkuMpmm4PkKoFvY8zQvIdGpfscUHXir1TGwb/KZIkkaMBbJYk8viJJxfhOZxudEKNahweTStSrbEy1FLkQT9ZZPufK12iokJW4BdSb30XGIKw6SEGZhFAWZuqsGa3z7YZHW8zmU8WkrGfHwaIyZLtY4prDGcGOAlyAFBcAcv6bqfOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by SJ5PPF8A49C4DF4.namprd11.prod.outlook.com (2603:10b6:a0f:fc02::83f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.11; Thu, 18 Jun 2026 23:39:06 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0113.015; Thu, 18 Jun 2026 23:39:06 +0000 Message-ID: <3ee018f0-689d-4175-bfd2-dda62a4aa45b@intel.com> Date: Thu, 18 Jun 2026 16:39:04 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] x86/resctrl: Rename prev_msr to prev_mon_val To: Chen Yu , CC: , , , , , , , , , , , References: <2e9bd6a1a012b937e9205908ab6bbb09a21e0f71.1781332698.git.yu.c.chen@intel.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <2e9bd6a1a012b937e9205908ab6bbb09a21e0f71.1781332698.git.yu.c.chen@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0307.namprd04.prod.outlook.com (2603:10b6:303:82::12) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|SJ5PPF8A49C4DF4:EE_ X-MS-Office365-Filtering-Correlation-Id: b56aec03-2e00-4dc1-4af9-08decd92c969 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7416014|23010399003|18002099003|22082099003|4143699003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: 7gDODwXnqEkIKRHM8EB2OELDTr4E4jS1Jx2I9ij7F3kPzVv70A4YYwmZB8qV3CRNuDFXvcXcY2eQnU8IC5zT/4J2Yojyy6G/7Wm0znrggOuGOZFPbkWAi+WRWdjYCZ20o9mbHCoRRD9pFYMFCJusmvZpoixFu9PaErk7EPgX3IQYshL2+GRPJ//qCLooquzt2mXOETwHEFsmUsGI9oTnWzODa1nf+CAth44hpnE01NBdR6vBv6YGX3JXHLR6BIohPrlez5XJ577EC341/Bvo/Bs+1DAvQwsEzKAMnRtYGRE2UIfBCIBnErgbdAqebmo8k7hDZK8T3H90EGWTPOmoS+yqiwqJ2rwzLiWoLg/dm1ZxWwelqSlZ1AvQHwMLi+8nyMVy5rv2/8PUjT6DVvQsnj//XnoRVDRA+Ob0ewy+gHEwfVIUNoRST6L09mn9fskdXtFLf0yrVlJDwz1Yfl0pZNs2qJVSjmQy51SheicqcR4TEBUZvmFkEUOWerZQzb7AtohgGX+KP2n4JTBV3hFBrys7RSqCqiybr7Rkdh1/XA+6TGmk3OoGQ6sfJF6x65IRXD9SS4dFs9z2q9oLEzAVNfmhs6f87eD7EdKtI0zN+DHAXcaSZtkxsx/4JnAk10mOtjwMyPvps/3oRFk+2q9AGyOF+0hTixuSSXkES2CE+5I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7416014)(23010399003)(18002099003)(22082099003)(4143699003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlhTWG5JUEkrT1NKR0gvaUpZSUFtYTYvNlBUN2FVM0QxMWcxbEM3VUxLMzc5?= =?utf-8?B?bUh0V21hN3BrSFAxSUZtTWFYUjhxVmYyYWZLZ0NvU2FzS1hXNlZxZFkyd0gv?= =?utf-8?B?d3lscVRQb1BaRlA5VlRSZTQvTmRSU0ZMS3ljOWlkbE5INjZNVUh5THRibTZW?= =?utf-8?B?bjhPejVtS0F6NG52QlFmSnRvbEczdGhVSmJxa3BWd3J3SVlSMXJLUXB0OWRh?= =?utf-8?B?Z0ROL3M3d09lblBaYi9Dck9ZTnFQU0F4dmUzclVuUGNYSUFlRXE2TmFvbXNE?= =?utf-8?B?RjNvVHhoRXZYaVZ5Rkl3OGp2TS9OUlVSekFmV2VqNWp3NUhaRldZTkRWSDQr?= =?utf-8?B?NldvMjcraGlnTEJxOGxxMDR5Uk5SMEpTY2ZvMmwrVUlUSmUrMU5XT0krR0lP?= =?utf-8?B?VGY5Zk9Ia2xRRk9YZ3UyOG9ib0RpL21Cd09ReUg4T2MxN25tUEFGZmZIM2kz?= =?utf-8?B?U3liZzRVcXhPZE1SUVlnMUdKeitzNXV2LzA3djlaamExZmxxbE9FMXZiZHd6?= =?utf-8?B?MkRRWENBcU9PZHZFTm1zUThnQVlWbmE0V2tOR1BySGpUUUhZQ05xOUQwM3hN?= =?utf-8?B?ZDRYdWRTMnI5Qjl3N3VKZVJwbTBJTGxoUkppb1dDL0NmS0MvdjlGMmQ1eVlQ?= =?utf-8?B?bXZZLzZxbVovVTVSRjE4d0JsTHlxNWgzbWJzekh0NzZCNTZiZ2xYYTNLOEdp?= =?utf-8?B?KzJTbHREQVRudXBGSmg0dHBXT0xzRm91N0t0bE8vR1p0ZS9SdmlXZG9hWUFk?= =?utf-8?B?YTkzdzBhQ1lBNjQwOFNPSEYzeSttUEhCZVhtbzEwK21taTc3Yk1QN3pHV1Bz?= =?utf-8?B?aFRYdDQ2Mnc5aXlORWtBbE5FMWJQdFJRc1lWT2lPOUswaUdsQ2ovM1RDNnBx?= =?utf-8?B?MHNucFNZbzhEZUVZaSt6c2laQm80ZnpFRGMzQUZhckh5dGtQOGlJY2RJcjNZ?= =?utf-8?B?YjU2a3gzRVY0UFNkeER4SjlVdUxYOWsxV1g2TThuR2Q2ZzlIL3doU0t6TE1t?= =?utf-8?B?Vng0Y2FmUmZhdWw3SzJ3bkxWZmttVis3N3hCUFJKYVFzckUrcGNjMlVDbWhn?= =?utf-8?B?MmF1Uzh3eVFGOFcwNFVQZlAxZlMvUEtqTERlRHJFeERhQURtQzNINit5KzJV?= =?utf-8?B?QXE0NzRjY1hYQ3pKTFJLcjY0Skd3eGZ3TUFENkpnbHlKODlOWDNCNFREdmh0?= =?utf-8?B?aEpyV3RtRldlYTBkNGw2M0JQRStWcFkwWlM1eG0zNHgxRUhxbWhoYWFiNGpT?= =?utf-8?B?WHEydFZZNEgyV3JzWmpnN21NRklESmVtaDMzZ2lyZUVab3NnaFVCdkpKKytY?= =?utf-8?B?c0FWWW9lY2xuVWo0VmVCb24vUW84ZGR2T2V0RnQ2emV6TnZtb09YVnY2bGhq?= =?utf-8?B?dHdnRm5weWlLZWF1RnlNakRsMyt0TlpJTXZua3VJK0ZGSzlkMDBoamRyellw?= =?utf-8?B?MDZWdlhEMWwveDVQWjJ1SVMvNCtsemlpc2FJV1N5TzBHVEZ0U0duZ29JSEh3?= =?utf-8?B?eFBPU0dnOEVkWGphL3lBbWRWb0Rad2FUK1ZSYkUzWi8wd29rV05EU2dMbGJn?= =?utf-8?B?ZFBzT0RNYjRrSmpJMjZLL2xHaGNXMzYxeDdHdEh3MlpEc2E1S1hMV0xtVlU0?= =?utf-8?B?emdkditOSDZIeldaSnRpWUlUeGZ5V052TFBFZjRVbndLYU1sbWNOaFo4WGNT?= =?utf-8?B?Sm11UUFaQmRTbDZBd3RDR0VNUTRxRGFrNlRTUmU1cVFzM0Jya1RvZjVibnl1?= =?utf-8?B?ZmQ0M0NVRTE1azRzNWc0YUgwR0hyeXhkWUg1TU9zVjI0UGtUcHhWUnlrU1pL?= =?utf-8?B?WWw0dys2YTc2NmlMRG1UWUdXZ1o4cnA3a0pBako0TXNaTE1ZdkpkYm9zMGp3?= =?utf-8?B?ZXlGS1lDNVYydGdFTWY3Y3ZVeDNZMGhNQ09Kd0NneTFnSnUxN3dyaHBBN1hD?= =?utf-8?B?alVsdStKMVBGZGx2SEt6UUFKQ2h0VFU1b2ZNVGg5Y3lYRkFDZ1p2VzdNcUpI?= =?utf-8?B?K1NRUkxVR3dxcklOKytGQ2RFTFovaEJxVlgwTWpaWVZOU0hEdmJMZmcwNUhm?= =?utf-8?B?WWgzMFo4UDRtRlhtemg0TGZuRllUT2NmWjNGNkxNQ0VKTzI3MGRDWlpwcS9L?= =?utf-8?B?ODUycFJ1Q1BuMVY0QURTb3pZQm1EWmxKMFBrOVVFVmJqck14UmladjYzdk0r?= =?utf-8?B?eVlSREFiQlk3eU5WMkVWRHNIbGFmR0t2MXdMMlV6am9OQXM5R1R1SXQxZjdk?= =?utf-8?B?ZHhsK2NLL0JhR2RFSm5SUCtCSURoN0FqWmh1RURyQ0JXcjIrZSs4MGpkcGU4?= =?utf-8?B?VmJrZFdVWDlud1NmcEhCcE45NXd6TVFCRzZYQ0JwRXFnZklXQjBwK0N4MExU?= =?utf-8?Q?pfBAKvmoWaub3XVk=3D?= X-Exchange-RoutingPolicyChecked: gOAb0m2GrgKuqk0wCtN9DSHMvUp79JnUA6Z3ohNGVMPx4kzJS3Ypbjz7nveIANXBntIFbO8VLkWm8HzpB0uDCWLF2uAZ7bIFL5PCmPkZBslK9blheKBvu31fiVgHWKQCJfvg9DwBjphLJmhN0/G6kesg89V5hwfTi8M4r12vAn/7uM+h8AT8LOBC9lJPyRu1Itv+PbCkhSjmTSBaYXiS9sPakrfnkJekcjym40iAEK1FziHF8uKYJZW5Hlg9pxXTXU3bksYHjpbHm0XfkYctC12M4CYE0PQLdm4Yz9ixoPCIe0B1v5XCKIG0LIwYBfFj+3SbFa93G7ZyHiwtja+rRQ== X-MS-Exchange-CrossTenant-Network-Message-Id: b56aec03-2e00-4dc1-4af9-08decd92c969 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2026 23:39:06.2567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p2EHlCPTVoHXBmrbkx2V61DsbkJH1rs7uXoIxs4ND2HwFu/YgBM7sHAkCEdkXjg5tN4y8+9yDg3XqyBci1gQYBKRW+Eqh8aGMCpJZvGAk6Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF8A49C4DF4 X-OriginatorOrg: intel.com Hi Chenyu, On 6/13/26 12:57 AM, Chen Yu wrote: > Rename the prev_msr field in struct arch_mbm_state to prev_mon_val. This change as described seems out of place when considering the following from cover letter: This patch set focuses on the first part: enabling MMIO-based access for Cache Monitoring Technology (CMT), *while CAT/MBM/MBA are still using MSR*. It is thus confusing to find a change related to switching MBM to use MSR in a series that claims that it does not do this. The patch looks fine but reading the changelog and the first few hunks makes this patch look out of place. Could you please update the changelog to be accurate about what this patch does? > With ERDT, the previous monitor value may come from an MMIO > register rather than from an MSR, so the "msr" suffix is no longer > accurate. The new name describes the field by its meaning (the > previous monitor value) instead of by the access method. > > This is preparation for ERDT support, which reads monitoring > counters via MMIO. > > No functional change. > Reinette