From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56318C433F5 for ; Mon, 7 Mar 2022 08:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbiCGIeQ (ORCPT ); Mon, 7 Mar 2022 03:34:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbiCGIeQ (ORCPT ); Mon, 7 Mar 2022 03:34:16 -0500 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6200865D9; Mon, 7 Mar 2022 00:33:22 -0800 (PST) Received: by mail-ed1-f51.google.com with SMTP id o1so17701078edc.3; Mon, 07 Mar 2022 00:33:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=5XjBMZm3BOMlJHves0LjGps2D/xDmp5OOs9Q8HXzMWA=; b=mllPxIkcpXTBHjFkV8NafkRN2akSPjlSsO7JRBy0s7xIX1w3vA2M8XG9g2XZELo9cd tSm8RATq/nZZq/wy9yeznpAOPPke5v8KWgZj8Zt3OexOQul08kHSIurRlDbjHDy8JbuM ZqYLV1G/UNB0Fkgz3Fc6eeWk7F9DFz5Zcu2ozg/geEWxj6XclrjaY4nvCtQVWNyziy4y DNPzWKzVsM3x3RcsVcFHWqX5d+G6qEPj1mT7kWTM5kFdmg7Ls/Y+ICG+OmAfkyEjGDck ZRMAqaLXcrogrDcGaVnZXuQBDH0cSthLZuuxWvLMBeH5QUP12gBsAn0K2SJz+7tECDJ+ W27Q== X-Gm-Message-State: AOAM533inppaNq7v95MqVgJv2k06v5idZDJ81nJKJ8x9r7wce28Ne8zL jw3CjgFdLiQ5T2vFKuIOyac= X-Google-Smtp-Source: ABdhPJxZX4jq5ETB6RUWSrtsGt6mSRLj9NeemrHaPEG5IZwX6bD1jcI6KNoxfQTjw2bwuQNulKojjQ== X-Received: by 2002:a05:6402:50d2:b0:413:1cd8:e08e with SMTP id h18-20020a05640250d200b004131cd8e08emr10061302edb.276.1646642000886; Mon, 07 Mar 2022 00:33:20 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id y19-20020a1709064b1300b006dabe44a6edsm3248931eju.141.2022.03.07.00.33.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 00:33:20 -0800 (PST) Message-ID: <3eecfcea-8eeb-3ea2-566b-704c314af718@kernel.org> Date: Mon, 7 Mar 2022 09:33:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2 3/7] tty: serial: samsung: constify s3c24xx_serial_drv_data Content-Language: en-US To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220307080810.53847-1-krzysztof.kozlowski@canonical.com> <20220307080925.54131-2-krzysztof.kozlowski@canonical.com> From: Jiri Slaby In-Reply-To: <20220307080925.54131-2-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 07. 03. 22, 9:09, Krzysztof Kozlowski wrote: > The driver data (struct s3c24xx_serial_drv_data) is only used to > initialize the driver properly and is not modified. Make it const. ... > @@ -2755,9 +2755,9 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { > }, > .fifosize = { 256, 64, 16, 16 }, > }; > -#define S5PV210_SERIAL_DRV_DATA ((kernel_ulong_t)&s5pv210_serial_drv_data) > +#define S5PV210_SERIAL_DRV_DATA (&s5pv210_serial_drv_data) > #else > -#define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL > +#define S5PV210_SERIAL_DRV_DATA NULL Yet, I still don't see why the switch from ulong->ptr happens in this "constify it" patch? thanks, -- -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9196AC433EF for ; Mon, 7 Mar 2022 08:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3UPoX3dataD637kdu3j8rtTtN1zfKMUqYZKe6Dmtvhw=; b=LvL/EDR+C0UPFvJJu1VsIL9dMB Y/sCqKhm4QuN8C8Jl4nB6bVyeJZDw5FGIXVxup6p8OoukNuy2DVo/to4/mS/klhJvl+ik0Ap0IcAI MzZKP9FCZC4M//h/PSQcer8ta0XMdhdWGpbiw4kTVr9qkxiz1mrw1GT8Ulscop2Oo/1vWW4lbeMss 7bSrVw7Ch+8d+ZRDz+Ta+3hSO3uoVrx4vjR7iOFcLh7xQkqDoBPBg3n6RuLcPCzffNXflDIuR+s2A A84RebdQDRfTA9Mg/h5UZfSSp3ZVZhJ8sy/hwH4ZhiHzxjBTovzZERBJ6w4cm2wXlLebZvahRHk2V BAqH4CTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR8o3-00GTU9-TL; Mon, 07 Mar 2022 08:33:28 +0000 Received: from mail-ed1-f49.google.com ([209.85.208.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR8ny-00GTT8-UG for linux-arm-kernel@lists.infradead.org; Mon, 07 Mar 2022 08:33:26 +0000 Received: by mail-ed1-f49.google.com with SMTP id g3so6553811edu.1 for ; Mon, 07 Mar 2022 00:33:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=5XjBMZm3BOMlJHves0LjGps2D/xDmp5OOs9Q8HXzMWA=; b=QlFMve4ivj/S7eY4SLCWZqi19iZvVfp2NXWMKm5wif9wZDc44iU5jp1w7XVmT5TU9j WGf0qm7TItuvq88k54TKfBbiDTl3VbGcVq5dr+rfNgZzNlGpB22WwkmuxoQxZXjDe2Sb rqOMQLEuhBEUHU4j4BpDOnzDtlJR086hm+hUQz33PyajXP9r/Kw00irKpJdNGd/GFtV+ LZcZEW6lIRW0zXBPT6P52a3kLfpF66+x0B3swnbML7w7P8ipOkbNtBPKWMvOemDWVIbS QP34h/ASMUdBDkXu7J7dPPnVWhRyzUVpfaextWLN+dALk1srdVsYu/FjaoLnCfCwIxob NV/g== X-Gm-Message-State: AOAM533bwoKKrGwK6ypUQkbucjfbgT5lUqPY63sNLWPuHMNXGhQ7d3wp HrcWDV++QzcvsLRoAe+0FX0= X-Google-Smtp-Source: ABdhPJxZX4jq5ETB6RUWSrtsGt6mSRLj9NeemrHaPEG5IZwX6bD1jcI6KNoxfQTjw2bwuQNulKojjQ== X-Received: by 2002:a05:6402:50d2:b0:413:1cd8:e08e with SMTP id h18-20020a05640250d200b004131cd8e08emr10061302edb.276.1646642000886; Mon, 07 Mar 2022 00:33:20 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id y19-20020a1709064b1300b006dabe44a6edsm3248931eju.141.2022.03.07.00.33.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 00:33:20 -0800 (PST) Message-ID: <3eecfcea-8eeb-3ea2-566b-704c314af718@kernel.org> Date: Mon, 7 Mar 2022 09:33:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2 3/7] tty: serial: samsung: constify s3c24xx_serial_drv_data Content-Language: en-US To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220307080810.53847-1-krzysztof.kozlowski@canonical.com> <20220307080925.54131-2-krzysztof.kozlowski@canonical.com> From: Jiri Slaby In-Reply-To: <20220307080925.54131-2-krzysztof.kozlowski@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_003323_021269_E7D15895 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07. 03. 22, 9:09, Krzysztof Kozlowski wrote: > The driver data (struct s3c24xx_serial_drv_data) is only used to > initialize the driver properly and is not modified. Make it const. ... > @@ -2755,9 +2755,9 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { > }, > .fifosize = { 256, 64, 16, 16 }, > }; > -#define S5PV210_SERIAL_DRV_DATA ((kernel_ulong_t)&s5pv210_serial_drv_data) > +#define S5PV210_SERIAL_DRV_DATA (&s5pv210_serial_drv_data) > #else > -#define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL > +#define S5PV210_SERIAL_DRV_DATA NULL Yet, I still don't see why the switch from ulong->ptr happens in this "constify it" patch? thanks, -- -- js suse labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel